Merge rust-bitcoin#4684: bitcoin: Remove re-export of Denomination

496d7df bitcoin: Remove re-export of Denomination (Tobin C. Harding)

Pull request description:

  `units::Denomination` does not exist, it is only at `units::amount::Denomination`. Our policy is to make the following three equivalent `bitcoin::Foo`, `primitives::Foo`, and `units::Foo` therefor we should not re-export `Denomination` at the crate root of `bitcoin`.


ACKs for top commit:
  apoelstra:
    ACK 496d7df; successfully ran local tests; will one-ACK merge; seems trivially correct


Tree-SHA512: b16f0b4bd0c8f118f062b51cde0473f8ffdae594dddc55bf4e2247968c02cd25c7693b32814378370b97434abb91f95caf4ed55aa8e2f0cce70a0cd0e7c7359c

Author: apoelstra

bitcoin/src/lib.rs

@@ -131,7 +131,7 @@ pub use primitives::{
 };
 #[doc(inline)]
 pub use units::{
-    amount::{Amount, Denomination, SignedAmount},
+    amount::{Amount, SignedAmount},
     block::{BlockHeight, BlockHeightInterval, BlockMtp},
     fee_rate::FeeRate,
     time::{self, BlockTime},

bitcoin/tests/bip_174.rs

@@ -3,6 +3,7 @@
 
 use std::collections::BTreeMap;
 
+use bitcoin::amount::{Amount, Denomination};
 use bitcoin::bip32::{Fingerprint, IntoDerivationPath, KeySource, Xpriv, Xpub};
 use bitcoin::consensus::encode::{deserialize, serialize_hex};
 use bitcoin::hex::FromHex;
@@ -11,7 +12,7 @@ use bitcoin::psbt::{Psbt, PsbtSighashType};
 use bitcoin::script::{PushBytes, ScriptBufExt as _};
 use bitcoin::secp256k1::Secp256k1;
 use bitcoin::{
-    absolute, script, transaction, Amount, Denomination, NetworkKind, OutPoint, PrivateKey,
+    absolute, script, transaction, NetworkKind, OutPoint, PrivateKey,
     PublicKey, ScriptBuf, Sequence, Transaction, TxIn, TxOut, Witness,
 };