Merge rust-bitcoin#4972: Backport rust-bitcoin#4964

apoelstra · apoelstra · commit ecffa6bd7df2 · 2025-09-13T21:27:02.000Z
6054d8e bip158: Return no match for empty query (rustaceanrob) Pull request description: Would be nice to have this logic change in a patch release ACKs for top commit: tcharding: ACK 6054d8e apoelstra: ACK 6054d8e; successfully ran local tests; I think this is a bugfix, so good to go in Tree-SHA512: 26f810544ca32588c66b357bb977c2d03188ee9d34f920bbcf963db9d70f04a9709de866918da34248bb5cec3ec83c24681183d77bfd34041bfa835aeec03127
diff --git a/bitcoin/src/bip158.rs b/bitcoin/src/bip158.rs
@@ -290,7 +290,7 @@ impl GcsFilterReader {
         // sort
         mapped.sort_unstable();
         if mapped.is_empty() {
-            return Ok(true);
+            return Ok(false);
         }
         if n_elements.0 == 0 {
             return Ok(false);

Original file line number	Diff line number	Diff line change
`@@ -290,7 +290,7 @@ impl GcsFilterReader {`
`290`	`290`	`// sort`
`291`	`291`	`mapped.sort_unstable();`
`292`	`292`	`if mapped.is_empty() {`
`293`		`- return Ok(true);`
	`293`	`+ return Ok(false);`
`294`	`294`	`}`
`295`	`295`	`if n_elements.0 == 0 {`
`296`	`296`	`return Ok(false);`