Merge #50: Bump nightly and add silent payments to ci

37bad3e Add silent payments to CI (Nick Johnson)
87602c1 Upgrade nightly to 2025-09-26 for public-api compatibility (Nick Johnson)

Pull request description:

  Taking the easy path with some ignores for now. This version matches what is in rust-bitcoin atm, but does have me wondering why it is a bit old.

ACKs for top commit:
  tcharding:
    ACK 37bad3e

Tree-SHA512: 88a43e71a6dfa0dda90ebb16101b7117c8ff115da7c66fcb613cb3974df7f9f45942c57ccead291148f63100db4e1ed1ef64ea5fc2c73df6524f69cacbe90488

Author: tcharding

nightly-version

@@ -1 +1 @@
-nightly-2025-01-21
+nightly-2025-09-26

rbmt.toml

@@ -11,10 +11,10 @@ examples = [
 
 # Features to test with the conventional `std` feature enabled.
 # Tests each feature alone with std, all pairs, and all together.
-features_with_std = ["rand", "serde", "base64", "miniscript"]
+features_with_std = ["rand", "serde", "base64", "miniscript", "silent-payments"]
 
 # Features to test without the `std` feature.
 # Tests each feature alone, all pairs, and all together.
 # Note: rand is a little weird until we can upgrade secp256k1 to v0.30.0
 # Note: miniscript is not included here as it has its own no-std handling
-features_without_std = ["serde", "base64"]
+features_without_std = ["serde", "base64", "silent-payments"]

src/v0/bitcoin/mod.rs

@@ -134,6 +134,7 @@ impl Psbt {
     /// An alias for [`extract_tx_fee_rate_limit`].
     ///
     /// [`extract_tx_fee_rate_limit`]: Psbt::extract_tx_fee_rate_limit
+    #[allow(clippy::result_large_err)]
     pub fn extract_tx(self) -> Result<Transaction, ExtractTxError> {
         self.internal_extract_tx_with_fee_rate_limit(Self::DEFAULT_MAX_FEE_RATE)
     }
@@ -145,6 +146,7 @@ impl Psbt {
     /// [`ExtractTxError`] variants will contain either the [`Psbt`] itself or the [`Transaction`]
     /// that was extracted. These can be extracted from the Errors in order to recover.
     /// See the error documentation for info on the variants. In general, it covers large fees.
+    #[allow(clippy::result_large_err)]
     pub fn extract_tx_fee_rate_limit(self) -> Result<Transaction, ExtractTxError> {
         self.internal_extract_tx_with_fee_rate_limit(Self::DEFAULT_MAX_FEE_RATE)
     }
@@ -156,6 +158,7 @@ impl Psbt {
     /// See [`extract_tx`].
     ///
     /// [`extract_tx`]: Psbt::extract_tx
+    #[allow(clippy::result_large_err)]
     pub fn extract_tx_with_fee_rate_limit(
         self,
         max_fee_rate: FeeRate,
@@ -183,6 +186,7 @@ impl Psbt {
     }
 
     #[inline]
+    #[allow(clippy::result_large_err)]
     fn internal_extract_tx_with_fee_rate_limit(
         self,
         max_fee_rate: FeeRate,
@@ -1038,6 +1042,7 @@ impl From<sighash::TaprootError> for SignError {
 /// This error is returned when extracting a [`Transaction`] from a [`Psbt`].
 #[derive(Debug, Clone, PartialEq, Eq)]
 #[non_exhaustive]
+#[allow(clippy::result_large_err)]
 pub enum ExtractTxError {
     /// The [`FeeRate`] is too high
     AbsurdFeeRate {

src/v2/extract.rs

@@ -78,6 +78,7 @@ impl Extractor {
     /// Perform [`Self::extract_tx_fee_rate_limit`] without the fee rate check.
     ///
     /// This can result in a transaction with absurdly high fees. Use with caution.
+    #[allow(clippy::result_large_err)]
     pub fn extract_tx_unchecked_fee_rate(&self) -> Result<Transaction, ExtractTxError> {
         self.internal_extract_tx()
     }
@@ -105,6 +106,7 @@ impl Extractor {
     ///
     /// Uses `miniscript` to do interpreter checks.
     #[inline]
+    #[allow(clippy::result_large_err)]
     fn internal_extract_tx(&self) -> Result<Transaction, ExtractTxError> {
         if !self.0.is_finalized() {
             return Err(ExtractTxError::Unfinalized);