Skip to content

Commit d443ea0

Browse files
committed
ci(appstore-release): update Mac App Store cert secret names
- Rename secrets to APPLE_MAS_CERTIFICATE_P12 and APPLE_MAS_CERTIFICATE_PASSWORD - Update references and documentation for certificate handling
1 parent d545c00 commit d443ea0

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

.github/workflows/appstore-release.yml

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,11 @@ name: App Store Release
77
# `asc profiles list` — no need to store it as a secret.
88
#
99
# Required GitHub Secrets:
10-
# MAS_CERTIFICATE_P12 — Base64-encoded P12 containing both:
11-
# • "3rd Party Mac Developer Application: ..." (signs the app)
12-
# • "3rd Party Mac Developer Installer: ..." (signs the PKG)
13-
# MAS_CERTIFICATE_PASSWORD — Password for MAS_CERTIFICATE_P12
10+
# APPLE_APPLE_MAS_CERTIFICATE_P12 — Base64-encoded P12 containing both:
11+
# • "3rd Party Mac Developer Application: ..." (signs the app)
12+
# • "3rd Party Mac Developer Installer: ..." (signs the PKG)
13+
# Different cert type from APPLE_CERTIFICATE_P12 (Developer ID).
14+
# APPLE_APPLE_MAS_CERTIFICATE_PASSWORD — Password for APPLE_APPLE_MAS_CERTIFICATE_P12
1415
# ASC_KEY_ID — App Store Connect API Key ID (same key as APP_STORE_CONNECT_KEY_ID)
1516
# ASC_ISSUER_ID — Issuer ID UUID (same as APP_STORE_CONNECT_ISSUER_ID)
1617
# ASC_PRIVATE_KEY — PEM content of .p8 file (cat AuthKey_XXXX.p8 — NOT base64)
@@ -102,8 +103,8 @@ jobs:
102103
103104
- name: Import Mac App Store Certificates
104105
env:
105-
MAS_CERTIFICATE_P12: ${{ secrets.MAS_CERTIFICATE_P12 }}
106-
MAS_CERTIFICATE_PASSWORD: ${{ secrets.MAS_CERTIFICATE_PASSWORD }}
106+
APPLE_MAS_CERTIFICATE_P12: ${{ secrets.APPLE_MAS_CERTIFICATE_P12 }}
107+
APPLE_MAS_CERTIFICATE_PASSWORD: ${{ secrets.APPLE_MAS_CERTIFICATE_PASSWORD }}
107108
run: |
108109
KEYCHAIN_PATH="$RUNNER_TEMP/mas-signing.keychain-db"
109110
KEYCHAIN_PASSWORD="$(openssl rand -hex 16)"
@@ -121,10 +122,10 @@ jobs:
121122
security import "$RUNNER_TEMP/AppleWWDRCAG3.cer" -k "$KEYCHAIN_PATH" -T /usr/bin/codesign 2>&1 || true
122123
123124
# Import Mac App Store certificates (Application + Installer, both in the P12)
124-
echo "$MAS_CERTIFICATE_P12" | base64 --decode > "$RUNNER_TEMP/mas-cert.p12"
125+
echo "$APPLE_MAS_CERTIFICATE_P12" | base64 --decode > "$RUNNER_TEMP/mas-cert.p12"
125126
security import "$RUNNER_TEMP/mas-cert.p12" \
126127
-k "$KEYCHAIN_PATH" \
127-
-P "$MAS_CERTIFICATE_PASSWORD" \
128+
-P "$APPLE_MAS_CERTIFICATE_PASSWORD" \
128129
-T /usr/bin/codesign \
129130
-T /usr/bin/productbuild \
130131
-T /usr/bin/security \

0 commit comments

Comments
 (0)