Clippy (#211)

Author: tdelmas

typed_floats/Cargo.toml

@@ -5,12 +5,7 @@ version.workspace = true
 edition.workspace = true
 license.workspace = true
 repository.workspace = true
-include = [
-  "Cargo.toml",
-  "src/*.rs",
-  "src/**/*.rs",
-  "*.md",
-]
+include = ["Cargo.toml", "src/*.rs", "src/**/*.rs", "*.md"]
 keywords.workspace = true
 categories.workspace = true
 readme = "./README.md"
@@ -64,13 +59,28 @@ num-traits = "0.2"
 [package.metadata.docs.rs]
 features = ["serde"]
 
+[lints.rust]
+dead-code = { level = "deny", priority = 1 }
+# missing_docs = { level = "deny", priority = 1 }
+unsafe_op_in_unsafe_fn = { level = "deny", priority = 1 }
+# unused_crate_dependencies = { level = "warn", priority = 1 }
+warnings = { level = "deny", priority = 0 }
+
 [lints.clippy]
-cargo        = { priority = -1, level = "deny" }
-complexity   = { priority = -1, level = "deny" }
-correctness  = { priority = -1, level = "deny" }
-suspicious   = { priority = -1, level = "deny" }
-style        = { priority = -1, level = "deny" }
-perf         = { priority = -1, level = "deny" }
-pedantic     = { priority = -1, level = "deny" }
-nursery      = { priority = -1, level = "deny" }
-# restriction  = { priority = -1, level = "deny" }
+indexing_slicing = { priority = -1, level = "deny" }
+panic_in_result_fn = { priority = -1, level = "deny" }
+panic = { priority = -1, level = "deny" }
+unwrap_in_result = { priority = -1, level = "deny" }
+unwrap_used = { priority = -1, level = "deny" }
+cargo = { priority = -1, level = "deny" }
+complexity = { priority = -1, level = "deny" }
+correctness = { priority = -1, level = "deny" }
+suspicious = { priority = -1, level = "deny" }
+style = { priority = -1, level = "deny" }
+perf = { priority = -1, level = "deny" }
+pedantic = { priority = -1, level = "deny" }
+nursery = { priority = -1, level = "deny" }
+# restriction  = { priority = -1, level = "deny" }
+unusual_byte_groupings = { priority = 1, level = "allow" }
+# msrv is tested in CI and this lint doesn't detects the `rustversion` guard
+incompatible_msrv = { priority = 1, level = "allow" }

typed_floats/build.rs

@@ -15,20 +15,24 @@ pub fn create_creadmes() {
 
     // Copy the README.md from the root (used by GitHub)
     // to the crate root (used by crates.io)
-    fs::copy(orig_readme, crate_readme).unwrap();
+    fs::copy(orig_readme, crate_readme)
+        .expect("Failed to copy README.md from project root to crate root");
 
     // Truncate the README to include it in the documentation of the crate
     let trucated_readme = Path::new("../typed_floats/README.truncated.md");
 
     // remove the parts that are not used by docs.io
     // That truncated version is the introduction of the documentation
-    let text_readme = fs::read_to_string(crate_readme).unwrap();
+    let text_readme = fs::read_to_string(crate_readme).expect("Failed to read crate README.md");
 
-    let text = text_readme.split("# Full documentation").next().unwrap();
+    let text = text_readme
+        .split("# Full documentation")
+        .next()
+        .expect("Failed to find '# Full documentation' section in README.md");
 
     let text = text.replace("```rust", "```ignore");
 
-    fs::write(trucated_readme, text).unwrap();
+    fs::write(trucated_readme, text).expect("Failed to write truncated README.md");
 }
 
 fn main() {

typed_floats/src/lib.rs

@@ -99,20 +99,8 @@
 //!
 //!
 //!
-#![warn(clippy::indexing_slicing)]
-#![warn(clippy::nursery)]
-#![warn(clippy::panic_in_result_fn)]
-#![warn(clippy::panic)]
-#![warn(clippy::pedantic)]
-#![warn(clippy::unwrap_in_result)]
-#![warn(clippy::unwrap_used)]
 #![warn(missing_docs)]
-#![warn(unsafe_op_in_unsafe_fn)]
-#![warn(unused_crate_dependencies)]
 #![cfg_attr(not(feature = "std"), no_std)]
-#![allow(clippy::unusual_byte_groupings)]
-// msrv is tested in CI and this lint doesn't detects the `rustversion` guard
-#![allow(clippy::incompatible_msrv)]
 
 // `format!` is used during the tests even in `no_std` environments
 #[cfg(all(test, not(feature = "std")))]

typed_floats/src/types/mod.rs

@@ -187,6 +187,7 @@ use crate::traits::{Atan2, Copysign, DivEuclid, Hypot, Powf};
 use crate::traits::Midpoint;
 
 #[cfg(all(feature = "libm", not(feature = "std")))]
+#[allow(unused_imports)]
 use num_traits::Float;
 
 mod accept;

typed_floats_macros/Cargo.toml

@@ -24,3 +24,21 @@ quote = "1.0"
 syn = { version = "2.0" }
 proc-macro2 = "1.0"
 rustversion.workspace = true
+
+[lints.rust]
+dead-code = { level = "deny", priority = 1 }
+missing_docs = { level = "deny", priority = 1 }
+unsafe_op_in_unsafe_fn = { level = "deny", priority = 1 }
+unused_crate_dependencies = { level = "deny", priority = 1 }
+warnings = { level = "deny", priority = 0 }
+
+[lints.clippy]
+cargo        = { priority = -1, level = "deny" }
+complexity   = { priority = -1, level = "deny" }
+correctness  = { priority = -1, level = "deny" }
+suspicious   = { priority = -1, level = "deny" }
+style        = { priority = -1, level = "deny" }
+perf         = { priority = -1, level = "deny" }
+# pedantic     = { priority = -1, level = "deny" }
+# nursery      = { priority = -1, level = "deny" }
+# restriction  = { priority = -1, level = "deny" }

typed_floats_macros/src/gen_tests.rs

@@ -19,28 +19,28 @@ fn test_op_checks(
                 let has_inf = #var.iter().any(|x| x.is_infinite());
                 assert!(has_inf, "No inf generated with {} but the output type {} accept it. Generated: {:?}", #op_name, stringify!(#full_type), #var);
             });
-        };
+        }
 
         if def.s.accept_zero {
             res.extend(quote! {
                 let has_zero = #var.iter().any(|x| x == &0.0);
                 assert!(has_zero, "No zero generated with {} but the output type {} accept it. Generated: {:?}", #op_name, stringify!(#full_type), #var);
             });
-        };
+        }
 
         if def.s.accept_positive {
             res.extend(quote! {
                 let has_positive = #var.iter().any(|x| x.is_sign_positive());
                 assert!(has_positive, "No positive generated with {} but the output type {} accept it. Generated: {:?}", #op_name, stringify!(#full_type), #var);
             });
-        };
+        }
 
         if def.s.accept_negative {
             res.extend(quote! {
                 let has_negative = #var.iter().any(|x| x.is_sign_negative());
                 assert!(has_negative, "No negative generated with {} but the output type {} accept it. Generated: {:?}", #op_name, stringify!(#full_type), #var);
             });
-        };
+        }
     } else {
         let full_type = float.float_type;
 

typed_floats_macros/src/impl_self_rhs.rs

@@ -4,7 +4,7 @@ use crate::types::{
     FloatDefinition, FloatSpecifications, OpRhs, OpRhsBuilder, ReturnTypeSpecification,
 };
 
-fn add_result(float: &FloatDefinition, rhs: &FloatDefinition) -> ReturnTypeSpecification {
+const fn add_result(float: &FloatDefinition, rhs: &FloatDefinition) -> ReturnTypeSpecification {
     let spec_a = &float.s;
     let spec_b = &rhs.s;
 
@@ -36,7 +36,7 @@ fn add_result(float: &FloatDefinition, rhs: &FloatDefinition) -> ReturnTypeSpeci
     }
 }
 
-fn can_one_be_zero_neg_and_the_other_zero_pos(
+const fn can_one_be_zero_neg_and_the_other_zero_pos(
     spec_a: &FloatSpecifications,
     spec_b: &FloatSpecifications,
 ) -> bool {

typed_floats_macros/src/lib.rs

@@ -185,7 +185,7 @@ pub fn generate_tests_self_rhs(input: proc_macro::TokenStream) -> proc_macro::To
     output.into()
 }
 
-/// Return the FloatDefinition for the given type
+/// Return the `FloatDefinition` for the given type
 fn get_definitions(float_type: &'static str) -> [FloatDefinition; 12] {
     TYPES
         .iter()

typed_floats_macros/src/types.rs

@@ -227,7 +227,7 @@ impl OpBuilder {
     }
 
     #[allow(dead_code)] // depending on the enabled features, this function might not be used
-    pub fn comment(mut self, comment: &'static str) -> Self {
+    pub const fn comment(mut self, comment: &'static str) -> Self {
         self.op.comment = Some(comment);
         self
     }
@@ -242,7 +242,7 @@ impl OpBuilder {
         self
     }
 
-    pub fn const_since(mut self, version: &'static str) -> Self {
+    pub const fn const_since(mut self, version: &'static str) -> Self {
         self.op.const_since = Some(version);
         self
     }