Merge pull request #53 from tylerdak/fix/global-repo-find-return-null

Fix: Global Repository Can't Return Null

Author: tdwesten

src/Repositories/GlobalRepository.php

@@ -39,11 +39,7 @@ public function find($id): ?GlobalSet
             return (new $global)->register();
         }
 
-        $r = parent::find($id);
-
-        if ($r) {
-            return $r;
-        }
+        return parent::find($id);
     }
 
     private function initializeGlobals()

tests/Unit/GlobalRepositoryTest.php

@@ -0,0 +1,15 @@
+<?php
+
+use Statamic\Facades\GlobalSet;
+use Tests\TestCase;
+
+pest()->extend(TestCase::class);
+test('::find does not throw when no result is found', function (): void {
+    GlobalSet::find('id-that-does-not-exist');
+})->throwsNoExceptions();
+
+test('::find returns null for nonexistent handles', function (): void {
+    $nullset = GlobalSet::find('id-that-does-not-exist');
+
+    expect($nullset)->toBeNull();
+});