Merge pull request #2350 from teableio/fix/autonumber-meta-fallback

fix: handle autonumber fallback for non-generated columns T1474

Author: nichenqin

apps/nestjs-backend/src/features/record/computed/services/computed-dependency-collector.service.ts

@@ -10,6 +10,7 @@ import type {
   IConditionalRollupFieldOptions,
   IConditionalLookupOptions,
   ILookupLinkOptionsVo,
+  AutoNumberFieldCore,
   FieldCore,
   TableDomain,
 } from '@teable/core';
@@ -1436,6 +1437,17 @@ export class ComputedDependencyCollectorService {
     return rows.map((row) => row.id).filter(Boolean);
   }
 
+  private getAutoNumberFieldIds(table: TableDomain, excludeFieldIds?: string[]): string[] {
+    const excluded = new Set(excludeFieldIds ?? []);
+    return table.fieldList
+      .filter(
+        (field): field is AutoNumberFieldCore =>
+          field.type === FieldType.AutoNumber && !excluded.has(field.id)
+      )
+      .filter((field) => !field.getIsPersistedAsGeneratedColumn?.())
+      .map((field) => field.id);
+  }
+
   private addContextFreeFormulasToImpact(
     impact: IComputedImpactByTable,
     tableId: string,
@@ -1587,6 +1599,8 @@ export class ComputedDependencyCollectorService {
       excludeFieldIds
     );
     this.addContextFreeFormulasToImpact(impact, tableId, contextFreeFormulaIds);
+    const autoNumberFieldIds = this.getAutoNumberFieldIds(entryDomain, excludeFieldIds);
+    this.addContextFreeFormulasToImpact(impact, tableId, autoNumberFieldIds);
 
     if (!Object.keys(impact).length) {
       return { impact: {}, tableDomains: new Map(seedTableDomains) };

apps/nestjs-backend/src/features/record/computed/services/record-computed-update.service.ts

@@ -57,7 +57,7 @@ export class RecordComputedUpdateService {
         // Skip formula persisted as generated columns
         return match(f)
           .when(isFormulaField, (f) => !f.getIsPersistedAsGeneratedColumn())
-          .with({ type: FieldType.AutoNumber }, () => false)
+          .with({ type: FieldType.AutoNumber }, (f) => !f.getIsPersistedAsGeneratedColumn())
           .with({ type: FieldType.CreatedTime }, () => isLookupStyle)
           .with({ type: FieldType.LastModifiedTime }, () => isLookupStyle)
           .with({ type: FieldType.CreatedBy }, (f) => isLookupStyle || !isPersistedGenerated(f))

apps/nestjs-backend/src/features/record/query-builder/field-select-visitor.ts

@@ -28,6 +28,7 @@ import { DbFieldType, FieldType, isLinkLookupOptions, DriverClient } from '@teab
 // no driver-specific logic here; use dialect for differences
 import type { Knex } from 'knex';
 import type { IDbProvider } from '../../../db-provider/db.provider.interface';
+import { AUTO_NUMBER_FIELD_NAME } from '../../field/constant';
 import { isSystemUserField } from '../../field/fields-utils';
 import type { IFieldSelectName } from './field-select.type';
 import type {
@@ -390,6 +391,14 @@ export class FieldSelectVisitor implements IFieldVisitor<IFieldSelectName> {
   }
 
   visitAutoNumberField(field: AutoNumberFieldCore): IFieldSelectName {
+    if (field.isLookup) {
+      return this.checkAndSelectLookupField(field);
+    }
+    if (this.rawProjection) {
+      const selector = this.generateColumnSelect(AUTO_NUMBER_FIELD_NAME);
+      this.state.setSelection(field.id, selector);
+      return selector;
+    }
     return this.checkAndSelectLookupField(field);
   }
 

packages/core/src/models/field/derivate/auto-number.field.ts

@@ -55,6 +55,9 @@ export class AutoNumberFieldCore extends FormulaAbstractCore {
     return autoNumberCellValueSchema.nullable().safeParse(value);
   }
 
+  getIsPersistedAsGeneratedColumn() {
+    return this.meta?.persistedAsGeneratedColumn || false;
+  }
   getExpression() {
     return this.options.expression;
   }