fix: network issues get too much attention T1479 (#2351)

tea-artist · web-flow · commit cabd5718e301 · 2025-12-30T15:06:47.000+08:00
diff --git a/packages/common-i18n/src/locales/de/sdk.json b/packages/common-i18n/src/locales/de/sdk.json
@@ -885,6 +885,7 @@
     "databaseConnectionUnavailable": "Datenbankverbindung nicht verfügbar",
     "gatewayTimeout": "Gateway Timeout",
     "unknownErrorCode": "Unbekannter Fehlercode",
+    "networkError": "Netzwerkverbindungsproblem",
     "requestTimeout": "Operationen außerhalb des Bereichs",
     "failedDependency": "Abhängigkeitsfehler",
     "automationNodeParseError": "Automatisierungsknoten-Analysefehler",
diff --git a/packages/common-i18n/src/locales/en/sdk.json b/packages/common-i18n/src/locales/en/sdk.json
@@ -885,6 +885,7 @@
     "databaseConnectionUnavailable": "Database connection unavailable",
     "gatewayTimeout": "Gateway timeout",
     "unknownErrorCode": "Unknown error code",
+    "networkError": "Network connection issue",
     "requestTimeout": "Request timeout",
     "failedDependency": "Failed dependency",
     "automationNodeParseError": "Automation node parse error",
diff --git a/packages/common-i18n/src/locales/es/sdk.json b/packages/common-i18n/src/locales/es/sdk.json
@@ -897,6 +897,7 @@
     "databaseConnectionUnavailable": "Conexión de base de datos no disponible",
     "gatewayTimeout": "Tiempo de espera de puerta de enlace",
     "unknownErrorCode": "Código de error desconocido",
+    "networkError": "Problema de conexión de red",
     "requestTimeout": "El tiempo de espera de la solicitud ha excedido",
     "failedDependency": "Dependencia fallida",
     "automationNodeParseError": "Error de análisis del nodo de automatización",
diff --git a/packages/common-i18n/src/locales/fr/sdk.json b/packages/common-i18n/src/locales/fr/sdk.json
@@ -885,6 +885,7 @@
     "databaseConnectionUnavailable": "Connexion à la base de données non disponible",
     "gatewayTimeout": "Temps d'attente de la passerelle",
     "unknownErrorCode": "Code d'erreur inconnu",
+    "networkError": "Problème de connexion réseau",
     "requestTimeout": "Temps d'attente de la requête dépassé",
     "failedDependency": "Échec de dépendance",
     "automationNodeParseError": "Erreur d'analyse du nœud d'automatisation",
diff --git a/packages/common-i18n/src/locales/it/sdk.json b/packages/common-i18n/src/locales/it/sdk.json
@@ -885,6 +885,7 @@
     "databaseConnectionUnavailable": "Connessione al database non disponibile",
     "gatewayTimeout": "Timeout del gateway",
     "unknownErrorCode": "Codice errore sconosciuto",
+    "networkError": "Problema di connessione di rete",
     "requestTimeout": "Timeout della richiesta",
     "failedDependency": "Errore di dipendenza",
     "automationNodeParseError": "Errore di analisi del nodo di automazione",
diff --git a/packages/common-i18n/src/locales/ja/sdk.json b/packages/common-i18n/src/locales/ja/sdk.json
@@ -885,6 +885,7 @@
     "databaseConnectionUnavailable": "データベース接続不可",
     "gatewayTimeout": "ゲートウェイタイムアウト",
     "unknownErrorCode": "不明なエラーコード",
+    "networkError": "ネットワーク接続の問題",
     "requestTimeout": "要求タイムアウト",
     "failedDependency": "依存操作失敗",
     "automationNodeParseError": "自動化ノード解析エラー",
diff --git a/packages/common-i18n/src/locales/ru/sdk.json b/packages/common-i18n/src/locales/ru/sdk.json
@@ -885,6 +885,7 @@
     "databaseConnectionUnavailable": "Недоступная база данных",
     "gatewayTimeout": "Таймаут шлюза",
     "unknownErrorCode": "Неизвестный код ошибки",
+    "networkError": "Проблема сетевого подключения",
     "requestTimeout": "Таймаут запроса",
     "failedDependency": "Ошибка зависимости",
     "automationNodeParseError": "Ошибка разбора узла автоматизации",
diff --git a/packages/common-i18n/src/locales/tr/sdk.json b/packages/common-i18n/src/locales/tr/sdk.json
@@ -885,6 +885,7 @@
     "databaseConnectionUnavailable": "Veritabanı Bağlantısı Mevcut Değil",
     "gatewayTimeout": "Ağ Geçidi Zaman Aşımı",
     "unknownErrorCode": "Bilinmeyen Hata Kodu",
+    "networkError": "Ağ bağlantı sorunu",
     "requestTimeout": "İstek Zaman Aşımı",
     "failedDependency": "Bağımlılık Hatası",
     "automationNodeParseError": "Otomasyon Düğümü Ayrıştırma Hatası",
diff --git a/packages/common-i18n/src/locales/uk/sdk.json b/packages/common-i18n/src/locales/uk/sdk.json
@@ -885,6 +885,7 @@
     "databaseConnectionUnavailable": "Недоступна база даних",
     "gatewayTimeout": "Таймаут шлюза",
     "unknownErrorCode": "Невідомий код помилки",
+    "networkError": "Проблема з підключенням до мережі",
     "requestTimeout": "Таймаут запиту",
     "failedDependency": "Залежність не виконана",
     "automationNodeParseError": "Помилка аналізу вузла автоматизації",
diff --git a/packages/common-i18n/src/locales/zh/sdk.json b/packages/common-i18n/src/locales/zh/sdk.json
@@ -885,6 +885,7 @@
     "databaseConnectionUnavailable": "数据库当前不可用",
     "gatewayTimeout": "服务器未及时收到上游服务器的响应",
     "unknownErrorCode": "发生未知错误",
+    "networkError": "网络连接问题",
     "requestTimeout": "请求超时",
     "failedDependency": "依赖操作失败",
     "automationNodeParseError": "自动化节点解析错误",
diff --git a/packages/core/src/errors/http/constant.ts b/packages/core/src/errors/http/constant.ts
@@ -25,4 +25,5 @@ export const ErrorCodeToStatusMap: Record<HttpErrorCode, number> = {
   [HttpErrorCode.AUTOMATION_NODE_PARSE_ERROR]: 400,
   [HttpErrorCode.AUTOMATION_NODE_NEED_TEST]: 400,
   [HttpErrorCode.AUTOMATION_NODE_TEST_OUTDATED]: 400,
+  [HttpErrorCode.NETWORK_ERROR]: 0,
 };
diff --git a/packages/core/src/errors/http/http-response.types.ts b/packages/core/src/errors/http/http-response.types.ts
@@ -51,6 +51,8 @@ export enum HttpErrorCode {
   GATEWAY_TIMEOUT = 'gateway_timeout',
   // Unknown error code
   UNKNOWN_ERROR_CODE = 'unknown_error_code',
+  // Network error - client-side network issue, not server error
+  NETWORK_ERROR = 'network_error',
   /** view */
   VIEW_NOT_FOUND = 'view_not_found',
   /** automation */
diff --git a/packages/openapi/src/axios.ts b/packages/openapi/src/axios.ts
@@ -1,6 +1,39 @@
-import { generateWindowId, HttpError } from '@teable/core';
+import { generateWindowId, HttpError, HttpErrorCode } from '@teable/core';
 import axiosInstance from 'axios';
 
+// Check if error is network-related (client-side issue, not server error)
+const isNetworkError = (error: unknown): boolean => {
+  if (!error || typeof error !== 'object') return false;
+  const err = error as { response?: unknown; message?: string; code?: string; name?: string };
+
+  // No response from server - this is typically a network error
+  if (!err.response) {
+    const message = err.message?.toLowerCase() || '';
+    const code = err.code?.toLowerCase() || '';
+    const name = err.name?.toLowerCase() || '';
+
+    return (
+      name === 'typeerror' || // fetch failures
+      code === 'err_network' ||
+      code === 'econnaborted' ||
+      message.includes('network') ||
+      message.includes('fetch') ||
+      message.includes('failed to fetch') ||
+      message.includes('load failed') ||
+      message.includes('networkerror') ||
+      message.includes('connection') ||
+      message.includes('timeout') ||
+      message.includes('abort') ||
+      message.includes('econnreset') ||
+      message.includes('enotfound') ||
+      message.includes('socket') ||
+      message.includes('disconnected') ||
+      message === 'no response from server'
+    );
+  }
+  return false;
+};
+
 export const createAxios = () => {
   const axios = axiosInstance.create({
     baseURL: '/api',
@@ -14,6 +47,18 @@ export const createAxios = () => {
     (error) => {
       // Any status codes that falls outside the range of 2xx cause this function to trigger
       const { data, status } = error?.response || {};
+
+      // Detect network errors and use NETWORK_ERROR code instead of INTERNAL_SERVER_ERROR
+      if (isNetworkError(error)) {
+        throw new HttpError(
+          {
+            message: error?.message || 'Network connection issue',
+            code: HttpErrorCode.NETWORK_ERROR,
+          },
+          0
+        );
+      }
+
       throw new HttpError(data || error?.message || 'no response from server', status || 500);
     }
   );
diff --git a/packages/sdk/src/context/app/queryClient.tsx b/packages/sdk/src/context/app/queryClient.tsx
@@ -1,5 +1,6 @@
 import { MutationCache, QueryCache, QueryClient } from '@tanstack/react-query';
 import type { ICustomHttpExceptionData, IHttpError, ILocalization } from '@teable/core';
+import { HttpErrorCode } from '@teable/core';
 import { sonner } from '@teable/ui-lib';
 import {
   UsageLimitModalType,
@@ -9,6 +10,11 @@ import type { ILocaleFunction, TKey } from './i18n';
 
 const { toast } = sonner;
 
+// Network error toast deduplication - only show once per cooldown period
+const NETWORK_ERROR_TOAST_ID = 'network-error-toast';
+const NETWORK_ERROR_COOLDOWN_MS = 10 * 1000; // 10 seconds cooldown
+let lastNetworkErrorTime = 0;
+
 export function toCamelCaseErrorCode(errorCode: string): string {
   return errorCode
     .split('_')
@@ -34,6 +40,25 @@ export const getHttpErrorMessage = (error: unknown, t: ILocaleFunction, prefix?:
 
 export const errorRequestHandler = (error: unknown, t?: ILocaleFunction) => {
   const { code, message, status } = error as IHttpError;
+
+  // Network errors - show a gentler warning, deduplicated with cooldown
+  // These are typically transient client-side issues, not server errors
+  if (code === HttpErrorCode.NETWORK_ERROR) {
+    const now = Date.now();
+    // Skip if within cooldown period (prevents toast spam when multiple APIs fail)
+    if (now - lastNetworkErrorTime < NETWORK_ERROR_COOLDOWN_MS) {
+      return;
+    }
+    lastNetworkErrorTime = now;
+
+    // Show a gentle warning with fixed id to prevent duplicates
+    toast.warning(t ? t('httpErrors.networkError') : 'Network connection issue', {
+      id: NETWORK_ERROR_TOAST_ID,
+      duration: 3000,
+    });
+    return;
+  }
+
   // no authentication
   if (status === 401) {
     window.location.href = `/auth/login?redirect=${encodeURIComponent(window.location.href)}`;
