Skip to content

Commit 32b1931

Browse files
committed
fix(ci): add security type and explicit release rules for all commit types
The previous configuration was missing: 1. Security commit type (used in security-patches PR #13) 2. Explicit release: false rules for non-releasing types 3. Complete releaseRules defining what triggers releases Changes: - Add 'security' type triggering patch releases - Add explicit release: false for chore, test, build, ci, style - Update PR template to include security type option - Update CONTRIBUTING.md with security type documentation - Add security section to changelog types This ensures semantic-release properly handles ALL conventional commit types and makes release behavior explicit and predictable. The security-patches PR (#13) contained security, perf, and docs commits that should have triggered a release but didn't because: 1. Merge commit format was wrong (Fix/security patches) 2. No explicit releaseRules defined what triggers releases Refs: #13, #14
1 parent b57ac9a commit 32b1931

File tree

3 files changed

+22
-5
lines changed

3 files changed

+22
-5
lines changed

.github/CONTRIBUTING.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,7 @@ We follow [Conventional Commits](https://www.conventionalcommits.org/) specifica
114114
|------|-------------|----------------|--------------|
115115
| `feat` | New feature | Minor (0.X.0) | ✅ Features |
116116
| `fix` | Bug fix | Patch (0.0.X) | ✅ Bug Fixes |
117+
| `security` | Security improvements | Patch (0.0.X) | ✅ Security |
117118
| `perf` | Performance improvement | Patch (0.0.X) | ✅ Performance |
118119
| `refactor` | Code refactoring | Patch (0.0.X) | ✅ Refactoring |
119120
| `docs` | Documentation only | Patch (0.0.X) | ✅ Documentation |

.github/pull_request_template.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88

99
- [ ] `feat`: New feature or enhancement
1010
- [ ] `fix`: Bug fix
11+
- [ ] `security`: Security improvements or fixes
1112
- [ ] `perf`: Performance improvement
1213
- [ ] `refactor`: Code refactoring
1314
- [ ] `docs`: Documentation updates

.releaserc.json

Lines changed: 20 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,13 @@
1111
{ "type": "perf", "release": "patch" },
1212
{ "type": "revert", "release": "patch" },
1313
{ "type": "docs", "release": "patch" },
14-
{ "type": "refactor", "release": "patch" }
14+
{ "type": "refactor", "release": "patch" },
15+
{ "type": "security", "release": "patch" },
16+
{ "type": "style", "release": false },
17+
{ "type": "chore", "release": false },
18+
{ "type": "test", "release": false },
19+
{ "type": "build", "release": false },
20+
{ "type": "ci", "release": false }
1521
]
1622
}
1723
],
@@ -40,19 +46,28 @@
4046
"types": [
4147
{
4248
"type": "feat",
43-
"section": "Features"
49+
"section": "Features",
50+
"hidden": false
4451
},
4552
{
4653
"type": "fix",
47-
"section": "Bug Fixes"
54+
"section": "Bug Fixes",
55+
"hidden": false
4856
},
4957
{
5058
"type": "perf",
51-
"section": "Performance Improvements"
59+
"section": "Performance Improvements",
60+
"hidden": false
61+
},
62+
{
63+
"type": "security",
64+
"section": "Security",
65+
"hidden": false
5266
},
5367
{
5468
"type": "revert",
55-
"section": "Reverts"
69+
"section": "Reverts",
70+
"hidden": false
5671
},
5772
{
5873
"type": "docs",

0 commit comments

Comments
 (0)