Merge pull request #70 from teads/develop

Release v2.7.0

Author: Niko-r

CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+v2.7.0
+ - Added new ad format support
+ - Internal improvements
+ - Minor internal fixes
+
 v2.6.0
  - Drop iOS 7
  - Minor improvements on the player

TeadsSDK.podspec

@@ -1,7 +1,7 @@
 Pod::Spec.new do |s|
 
 s.name         = "TeadsSDK"
-s.version      = "2.6.0"
+s.version      = "2.7.0"
 s.summary      = "Teads' iOS SDK"
 
 s.description  = <<-DESC

TeadsSDKDemo/AppDelegate.m

@@ -21,7 +21,11 @@ - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(
     [TeadsSDK setLogLevel:TeadslogLevelVerbose];
 
     if (![[NSUserDefaults standardUserDefaults] stringForKey:@"pid"]) {
-        [[NSUserDefaults standardUserDefaults] setObject:@"27695" forKey:@"pid"];
+        /** /!\ /!\ /!\
+         *  WARNING: Don't use this PID (54934) in production. Contact your Publisher Manager to obtain your own dedicated PID
+         *  /!\ /!\ /!\
+         */
+        [[NSUserDefaults standardUserDefaults] setObject:@"54934" forKey:@"pid"];
     }
     if (![[NSUserDefaults standardUserDefaults] stringForKey:@"website"]) {
         [[NSUserDefaults standardUserDefaults] setObject:@"Default demo website" forKey:@"website"];

TeadsSDKDemo/Demo Pages/inRead/CustomAdCollectionViewController.m

@@ -114,12 +114,6 @@ - (UICollectionViewCell *)collectionView:(UICollectionView *)collectionView cell
     if ([indexPath isEqual:self.insertionPath]) {
         self.adCell = [collectionView dequeueReusableCellWithReuseIdentifier:@"teadsAdCell" forIndexPath:indexPath];
 
-        [self.adCell.contentView addSubview:self.teadsAd.videoView];
-        if (!self.videoViewAdded) {
-            [self.teadsAd videoViewWasAdded]; //Inform that Teads Ad was added
-            self.videoViewAdded = YES;
-        }
-        
         return self.adCell;
     } else {
         CustomCollectionViewCell *cell = [collectionView dequeueReusableCellWithReuseIdentifier:collectionViewCellID forIndexPath:indexPath];
@@ -140,7 +134,9 @@ - (UICollectionViewCell *)collectionView:(UICollectionView *)collectionView cell
 #pragma mark - UIScrollView
 
 - (void)scrollViewDidScroll:(UIScrollView *)scrollView {
-    [self.teadsAd videoViewDidMove:scrollView]; //Inform TeadsAd that the view did move in its scrollView container
+    if (self.videoViewAdded) {
+        [self.teadsAd videoViewDidMove:scrollView]; //Inform TeadsAd that the view did move in its scrollView container
+    }
 }
 
 #pragma mark - UICollectionView delegate
@@ -153,6 +149,18 @@ - (CGSize)collectionView:(UICollectionView *)collectionView layout:(UICollection
     }
 }
 
+
+-(void)collectionView:(UICollectionView *)collectionView willDisplayCell:(UICollectionViewCell *)cell forItemAtIndexPath :(NSIndexPath *)indexPath {
+    if ([indexPath isEqual:self.insertionPath]) { //self.insertionPath is the indexPath where TeadsAd was added
+        if (!self.videoViewAdded) {
+            [self.adCell.contentView addSubview:self.teadsAd.videoView];
+            [self.teadsAd videoViewWasAdded]; //Inform that Teads Ad was added and cell will be displayed
+            self.videoViewAdded = YES;
+        }
+    }
+}
+
+
 #pragma mark - 
 #pragma mark - Your methods to calculate Custom Ad size
 

TeadsSDKDemo/Intern/DemoUtils.m

@@ -19,8 +19,13 @@ +(void)presentControllerToChangePid:(id)controller {
 
     [alert addTextFieldWithConfigurationHandler:^(UITextField *textField) {
         textField.clearButtonMode = UITextFieldViewModeWhileEditing;
-        textField.placeholder = @"27695";
-        if (![[[NSUserDefaults standardUserDefaults] stringForKey:@"pid"] isEqual:@"27695"]) {
+        
+        /** /!\ /!\ /!\
+         *  WARNING: Don't use this PID (54934) in production. Contact your Publisher Manager to obtain your own dedicated PID
+         *  /!\ /!\ /!\
+         */
+        textField.placeholder = @"54934";
+        if (![[[NSUserDefaults standardUserDefaults] stringForKey:@"pid"] isEqual:@"54934"]) {
             textField.text = [[NSUserDefaults standardUserDefaults] stringForKey:@"pid"];
         }
     }];
@@ -33,7 +38,11 @@ +(void)presentControllerToChangePid:(id)controller {
                              if (![alert.textFields.firstObject.text isEqual:@""]) {
                                  [[NSUserDefaults standardUserDefaults] setObject:alert.textFields.firstObject.text forKey:@"pid"];;
                              } else {
-                                 [[NSUserDefaults standardUserDefaults] setObject:@"27695" forKey:@"pid"];;
+                                 /** /!\ /!\ /!\
+                                  *  WARNING: Don't use this PID (54934) in production. Contact your Publisher Manager to obtain your own dedicated PID
+                                  *  /!\ /!\ /!\
+                                  */
+                                 [[NSUserDefaults standardUserDefaults] setObject:@"54934" forKey:@"pid"];;
                              }
                              [alert dismissViewControllerAnimated:YES completion:nil];
                          }];