Skip to content

Commit 8354318

Browse files
Merge pull request #188 from teads/specify-placement-strong-reference
Specify Teads' placement must be kept as strong reference
2 parents 06fc790 + 9c2ce30 commit 8354318

File tree

6 files changed

+12
-2
lines changed

6 files changed

+12
-2
lines changed

TeadsSampleApp/Controllers/InRead/Direct/CollectionView/InReadDirectCollectionViewController.swift

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,9 @@ class InReadDirectCollectionViewController: TeadsViewController {
4040
let placementSettings = TeadsAdPlacementSettings { settings in
4141
settings.enableDebug()
4242
}
43+
44+
//keep a strong reference to placement instance
4345
placement = Teads.createInReadPlacement(pid: Int(pid) ?? 0, settings: placementSettings, delegate: self)
44-
4546
placement?.requestAd(requestSettings: TeadsAdRequestSettings { settings in
4647
settings.pageUrl("https://www.teads.tv")
4748
})

TeadsSampleApp/Controllers/InRead/Direct/ScrollView/InReadDirectScrollViewController.swift

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@ class InReadDirectScrollViewController: TeadsViewController {
2121
let pSettings = TeadsAdPlacementSettings { settings in
2222
settings.enableDebug()
2323
}
24+
25+
//keep a strong reference to placement instance
2426
placement = Teads.createInReadPlacement(pid: Int(pid) ?? 0, settings: pSettings, delegate: self)
2527
placement?.requestAd(requestSettings: TeadsAdRequestSettings { settings in
2628
settings.pageUrl("https://www.teads.tv")

TeadsSampleApp/Controllers/InRead/Direct/TableView/InReadDirectTableViewController.swift

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,9 @@ class InReadDirectTableViewController: TeadsViewController {
4040
let placementSettings = TeadsAdPlacementSettings { settings in
4141
settings.enableDebug()
4242
}
43+
44+
//keep a strong reference to placement instance
4345
placement = Teads.createInReadPlacement(pid: Int(pid) ?? 0, settings: placementSettings, delegate: self)
44-
4546
placement?.requestAd(requestSettings: TeadsAdRequestSettings { settings in
4647
settings.pageUrl("https://www.teads.tv")
4748
})

TeadsSampleApp/Controllers/InRead/Direct/WebView/InReadDirectWebViewController.swift

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,8 @@ class InReadDirectWebViewController: TeadsViewController, WKNavigationDelegate {
3636
let pSettings = TeadsAdPlacementSettings { _ in
3737
// settings.enableDebug()
3838
}
39+
40+
//keep a strong reference to placement instance
3941
placement = Teads.createInReadPlacement(pid: Int(pid) ?? 0, settings: pSettings, delegate: self)
4042
}
4143

TeadsSampleApp/Controllers/Native/Direct/CollectionView/NativeDirectCollectionViewController.swift

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,8 @@ class NativeDirectCollectionViewController: TeadsViewController {
3030
let placementSettings = TeadsAdPlacementSettings { settings in
3131
settings.enableDebug()
3232
}
33+
34+
//keep a strong reference to placement instance
3335
placement = Teads.createNativePlacement(pid: Int(pid) ?? 0, settings: placementSettings, delegate: self)
3436

3537
placement?.requestAd(requestSettings: TeadsAdRequestSettings { settings in

TeadsSampleApp/Controllers/Native/Direct/TableView/NativeDirectTableViewController.swift

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,8 @@ class NativeDirectTableViewController: TeadsViewController {
3333
let placementSettings = TeadsAdPlacementSettings { settings in
3434
settings.enableDebug()
3535
}
36+
37+
//keep a strong reference to placement instance
3638
placement = Teads.createNativePlacement(pid: Int(pid) ?? 0, settings: placementSettings, delegate: self)
3739

3840
placement?.requestAd(requestSettings: TeadsAdRequestSettings { settings in

0 commit comments

Comments
 (0)