Skip to content

Commit a2d0dee

Browse files
TeadsWebviewHelper now loads ads even if the view is not scrolled
2 parents 4d41c82 + 0a75d26 commit a2d0dee

File tree

2 files changed

+5
-8
lines changed

2 files changed

+5
-8
lines changed

TeadsSampleApp/Controllers/InRead/Direct/WebView/InReadDirectWebViewController.swift

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,14 @@ class InReadDirectWebViewController: TeadsViewController, WKNavigationDelegate {
2424
return
2525
}
2626
let contentStringWithIntegrationType = contentString.replacingOccurrences(of: "{INTEGRATION_TYPE}", with: "InRead Direct WebView Integration")
27+
28+
// The html identifier where you want your slot to open`
29+
let domCSSSlotSelector = "#teads-placement-slot"
2730
webView.navigationDelegate = self
2831
webView.loadHTMLString(contentStringWithIntegrationType, baseURL: Bundle.main.bundleURL)
2932

3033
/// init helper
31-
webViewHelper = TeadsWebViewHelper(webView: webView, selector: "#teads-placement-slot", delegate: self)
34+
webViewHelper = TeadsWebViewHelper(webView: webView, selector: domCSSSlotSelector, delegate: self)
3235

3336
let pSettings = TeadsAdPlacementSettings { _ in
3437
// settings.enableDebug()

TeadsSampleApp/WebViewHelper/TeadsWebViewHelper.swift

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -163,8 +163,6 @@ import WebKit
163163
self?.delegate?.webViewHelperOnError?(error: "insertSlot failed")
164164
self?.delegate?.webViewHelperSlotNotFound?()
165165
self?.noSlotTimer?.invalidate()
166-
} else {
167-
self?.slotOpener?()
168166
}
169167
}
170168
}
@@ -331,7 +329,7 @@ import WebKit
331329

332330
adViewHTMLElementWidth = position.right - position.left
333331
slotPosition = position
334-
332+
slotOpener?()
335333
guard let webView = webView else {
336334
return
337335
}
@@ -349,10 +347,6 @@ import WebKit
349347
}
350348
return true
351349
}
352-
if shouldUpdateAdViewFrame {
353-
// prevent an UI glitch when autolayout constraint is activated, prevent adReached sent too early also
354-
adView.frame = CGRect(x: position.left, y: position.top, width: adViewHTMLElementWidth, height: adViewHTMLElementHeight)
355-
}
356350

357351
NSLayoutConstraint.deactivate(adViewConstraints)
358352
adViewConstraints.removeAll()

0 commit comments

Comments
 (0)