Skip to content

Commit eb49852

Browse files
teaguesterlingteaguesterling
committed
Update API for v1.5-variegata
Signed-off-by: Teague Sterling <teaguesterling@gmail.com>
1 parent 007c0da commit eb49852

File tree

7 files changed

+0
-16
lines changed

7 files changed

+0
-16
lines changed

‎src/git_branches.cpp‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ unique_ptr<LocalTableFunctionState> GitBranchesLocalInit(ExecutionContext &conte
3636

3737
unique_ptr<FunctionData> GitBranchesBind(ClientContext &context, TableFunctionBindInput &input,
3838
vector<LogicalType> &return_types, vector<string> &names) {
39-
4039
// Use unified parameter parsing to support both git:// URIs and filesystem paths
4140
auto params = ParseUnifiedGitParams(input, 1); // ref parameter at index 1 (optional)
4241

@@ -71,7 +70,6 @@ unique_ptr<FunctionData> GitBranchesBind(ClientContext &context, TableFunctionBi
7170

7271
unique_ptr<FunctionData> GitBranchesEachBind(ClientContext &context, TableFunctionBindInput &input,
7372
vector<LogicalType> &return_types, vector<string> &names) {
74-
7573
// For LATERAL functions, use ParseLateralGitParams to get optional ref parameter
7674
// The repo_path will come from runtime DataChunk, not bind time
7775
auto params = ParseLateralGitParams(input, 1); // ref parameter at index 1 (optional)
@@ -328,7 +326,6 @@ static OperatorResultType GitBranchesEachFunction(ExecutionContext &context, Tab
328326

329327
idx_t output_count = 0;
330328
while (output_count < STANDARD_VECTOR_SIZE && state.current_output_row < state.current_rows.size()) {
331-
332329
auto &row = state.current_rows[state.current_output_row];
333330

334331
output.SetValue(0, output_count, Value(resolved_repo_path));

‎src/git_log.cpp‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ GitLogFunctionData::GitLogFunctionData(const string &ref) : repo_path(""), resol
2424

2525
unique_ptr<FunctionData> GitLogBind(ClientContext &context, TableFunctionBindInput &input,
2626
vector<LogicalType> &return_types, vector<string> &names) {
27-
2827
// Use unified parameter parsing to support both git:// URIs and filesystem paths
2928
auto params = ParseUnifiedGitParams(input, 1); // ref parameter at index 1 (optional)
3029

@@ -351,7 +350,6 @@ static OperatorResultType GitLogEachFunction(ExecutionContext &context, TableFun
351350
// Output rows for current input
352351
idx_t output_count = 0;
353352
while (output_count < STANDARD_VECTOR_SIZE && state.current_output_row < state.current_rows.size()) {
354-
355353
auto &row = state.current_rows[state.current_output_row];
356354

357355
// Fill output row with git log data
@@ -386,7 +384,6 @@ static OperatorResultType GitLogEachFunction(ExecutionContext &context, TableFun
386384
// GitLogEachBind function - LATERAL function bind for dynamic repo_path processing
387385
unique_ptr<FunctionData> GitLogEachBind(ClientContext &context, TableFunctionBindInput &input,
388386
vector<LogicalType> &return_types, vector<string> &names) {
389-
390387
// For LATERAL functions, use ParseLateralGitParams to get optional ref parameter
391388
// The repo_path will come from runtime DataChunk, not bind time
392389
auto params = ParseLateralGitParams(input, 1); // ref parameter at index 1 (optional)

‎src/git_parents.cpp‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -290,7 +290,6 @@ OperatorResultType GitParentsEachFunction(ExecutionContext &context, TableFuncti
290290

291291
idx_t output_count = 0;
292292
while (output_count < STANDARD_VECTOR_SIZE && state.current_output_row < state.current_rows.size()) {
293-
294293
auto &row = state.current_rows[state.current_output_row];
295294
OutputGitParentsRow(output, output_count, row, state.current_repo_path);
296295

‎src/git_read.cpp‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -346,7 +346,6 @@ static void ProcessGitURI(const string &uri, const GitReadBindData &bind_data, G
346346
// Bind function for static git_read (single URI parameter)
347347
static unique_ptr<FunctionData> GitReadBind(ClientContext &context, TableFunctionBindInput &input,
348348
vector<LogicalType> &return_types, vector<string> &names) {
349-
350349
// Extract first parameter (repo_path_or_uri_with_file)
351350
if (input.inputs.empty()) {
352351
throw BinderException("git_read requires at least one parameter: the file path or git:// URI");
@@ -495,7 +494,6 @@ static void GitReadFunction(ClientContext &context, TableFunctionInput &input, D
495494
// Bind function for git_read_each (Pure LATERAL function)
496495
static unique_ptr<FunctionData> GitReadEachBind(ClientContext &context, TableFunctionBindInput &input,
497496
vector<LogicalType> &return_types, vector<string> &names) {
498-
499497
// LATERAL-only: reject direct calls, arguments arrive at runtime via input DataChunk
500498
if (!input.inputs.empty()) {
501499
throw BinderException("git_read_each is LATERAL-only. For direct calls, use git_read(...) instead");

‎src/git_tags.cpp‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ unique_ptr<LocalTableFunctionState> GitTagsLocalInit(ExecutionContext &context,
5555

5656
unique_ptr<FunctionData> GitTagsBind(ClientContext &context, TableFunctionBindInput &input,
5757
vector<LogicalType> &return_types, vector<string> &names) {
58-
5958
// Use unified parameter parsing to support both git:// URIs and filesystem paths
6059
auto params = ParseUnifiedGitParams(input, 1); // ref parameter at index 1 (optional)
6160

@@ -87,7 +86,6 @@ unique_ptr<FunctionData> GitTagsBind(ClientContext &context, TableFunctionBindIn
8786

8887
unique_ptr<FunctionData> GitTagsEachBind(ClientContext &context, TableFunctionBindInput &input,
8988
vector<LogicalType> &return_types, vector<string> &names) {
90-
9189
// For LATERAL functions, use ParseLateralGitParams to get optional ref parameter
9290
// The repo_path will come from runtime DataChunk, not bind time
9391
auto params = ParseLateralGitParams(input, 1); // ref parameter at index 1 (optional)
@@ -410,7 +408,6 @@ static OperatorResultType GitTagsEachFunction(ExecutionContext &context, TableFu
410408

411409
idx_t output_count = 0;
412410
while (output_count < STANDARD_VECTOR_SIZE && state.current_output_row < state.current_rows.size()) {
413-
414411
auto &row = state.current_rows[state.current_output_row];
415412

416413
output.SetValue(0, output_count, Value(resolved_repo_path));

‎src/git_tree.cpp‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -326,7 +326,6 @@ static void ProcessSingleCommit(git_repository *repo, const string &ref, const s
326326

327327
unique_ptr<FunctionData> GitTreeBind(ClientContext &context, TableFunctionBindInput &input,
328328
vector<LogicalType> &return_types, vector<string> &names) {
329-
330329
// Set return schema first
331330
return_types = GetGitTreeSchema();
332331
names = GetGitTreeColumnNames();
@@ -354,7 +353,6 @@ unique_ptr<FunctionData> GitTreeBind(ClientContext &context, TableFunctionBindIn
354353

355354
unique_ptr<FunctionData> GitTreeEachBind(ClientContext &context, TableFunctionBindInput &input,
356355
vector<LogicalType> &return_types, vector<string> &names) {
357-
358356
// Set return schema
359357
return_types = GetGitTreeSchema();
360358
names = GetGitTreeColumnNames();
@@ -541,7 +539,6 @@ static OperatorResultType GitTreeEachFunction(ExecutionContext &context, TableFu
541539
// Output rows for current input
542540
idx_t output_count = 0;
543541
while (output_count < STANDARD_VECTOR_SIZE && state.current_output_row < state.current_rows.size()) {
544-
545542
auto &row = state.current_rows[state.current_output_row];
546543
OutputGitTreeRow(output, row, output_count);
547544

‎src/git_uri.cpp‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ static void GitUriFunction(DataChunk &args, ExpressionState &state, Vector &resu
4444
if (args.data[0].GetVectorType() == VectorType::CONSTANT_VECTOR &&
4545
args.data[1].GetVectorType() == VectorType::CONSTANT_VECTOR &&
4646
args.data[2].GetVectorType() == VectorType::CONSTANT_VECTOR) {
47-
4847
auto repo_path_value = ConstantVector::GetData<string_t>(args.data[0]);
4948
auto file_path_value = ConstantVector::GetData<string_t>(args.data[1]);
5049
auto commit_ref_value = ConstantVector::GetData<string_t>(args.data[2]);

0 commit comments

Comments
 (0)