Skip to content

Commit 03c914c

Browse files
author
Arnav Gupta
committed
Fix some ForceCloses (real bad code, fixed with even worse code)
this is a bad bad bad approach. i have taken a sledgehammer to the exceptions and made them shut up. if i have some time to retrospect back on this, i'd like to properly fix these errors.
1 parent c2bd244 commit 03c914c

File tree

5 files changed

+26
-20
lines changed

5 files changed

+26
-20
lines changed

App/src/main/java/in/ac/dtu/subtlenews/MainActivity.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,10 @@
33
import android.content.Intent;
44
import android.content.SharedPreferences;
55
import android.os.Bundle;
6-
import android.support.v4.app.Fragment;
76
import android.support.v4.app.FragmentManager;
87
import android.support.v4.widget.DrawerLayout;
98
import android.support.v7.app.ActionBar;
109
import android.support.v7.app.ActionBarActivity;
11-
import android.util.Log;
1210
import android.view.Menu;
1311
import android.view.MenuItem;
1412
import android.view.Window;
@@ -129,7 +127,7 @@ public boolean onOptionsItemSelected(MenuItem item) {
129127
switch (id){
130128
case R.id.action_refresh:
131129
if(Utils.isNetworkConnected(MainActivity.this)){
132-
new UpdateNews(MainActivity.this).execute();
130+
new UpdateNews(MainActivity.this, false).execute();
133131
MainFragment mainFragment = (MainFragment) getSupportFragmentManager().findFragmentById(R.id.container);
134132
mainFragment.updateView();
135133
} else {

App/src/main/java/in/ac/dtu/subtlenews/MainFragment.java

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package in.ac.dtu.subtlenews;
22

33
import android.annotation.SuppressLint;
4-
import android.annotation.TargetApi;
54
import android.app.Activity;
65
import android.app.AlertDialog;
76
import android.content.Context;
@@ -17,10 +16,8 @@
1716
import android.view.LayoutInflater;
1817
import android.view.View;
1918
import android.view.ViewGroup;
20-
import android.webkit.WebView;
2119
import android.widget.AdapterView;
2220
import android.widget.BaseAdapter;
23-
import android.widget.ImageView;
2421
import android.widget.ListView;
2522
import android.widget.TextView;
2623
import android.widget.Toast;
@@ -32,9 +29,7 @@
3229
import java.io.BufferedReader;
3330
import java.io.File;
3431
import java.io.FileReader;
35-
import java.lang.annotation.Target;
3632
import java.util.ArrayList;
37-
import java.util.List;
3833

3934
/**
4035
* Created by omerjerk on 2/12/13.
@@ -119,7 +114,7 @@ protected ArrayList<JSONObject> doInBackground(Void... v) {
119114
} catch (Exception e){
120115
e.printStackTrace();
121116
if (Utils.isNetworkConnected(getActivity())) {
122-
new UpdateNews(getActivity()).execute();
117+
new UpdateNews(getActivity(), true).execute();
123118
} else {
124119
Toast.makeText(getActivity(), "Please turn on your internet connection!", Toast.LENGTH_SHORT).show();
125120
}

App/src/main/java/in/ac/dtu/subtlenews/NewsAutoRefresh.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
import android.content.Context;
77
import android.content.Intent;
88
import android.os.Bundle;
9-
import android.util.Log;
109

1110
import java.util.Calendar;
1211

@@ -39,7 +38,7 @@ public NewsAutoRefresh(Context context, Bundle extras, int timeoutInSeconds){
3938
public void onReceive(Context context, Intent intent) {
4039

4140
if(Utils.isNetworkConnected(context)){
42-
new UpdateNews(context).execute();
41+
new UpdateNews(context, true).execute();
4342
}
4443
}
4544
}

App/src/main/java/in/ac/dtu/subtlenews/UpdateNews.java

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,16 @@
2323
public class UpdateNews extends AsyncTask <Void, Void, String> {
2424

2525
private Context context;
26+
private Boolean ranAutomatically;
2627

27-
public UpdateNews(Context context){
28+
public UpdateNews(Context context, Boolean autorun){
2829
this.context = context;
30+
ranAutomatically = autorun;
2931

3032
Log.d("Update News", "Inside the constructor of UpdateNews class");
31-
((Activity)context).setProgressBarIndeterminateVisibility(true);
33+
if (!autorun) {
34+
((Activity)context).setProgressBarIndeterminateVisibility(true);
35+
}
3236
}
3337

3438
@Override
@@ -49,7 +53,9 @@ protected String doInBackground(Void... v){
4953

5054
protected void onPostExecute(String r) {
5155

52-
((Activity)context).setProgressBarIndeterminateVisibility(false);
56+
if (!ranAutomatically) {
57+
((Activity)context).setProgressBarIndeterminateVisibility(false);
58+
}
5359

5460
Log.d("[GET RESPONSE]", r);
5561
File cacheFile = new File(context.getFilesDir(), "data.json");

App/src/main/java/in/ac/dtu/subtlenews/Utils.java

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,20 @@ public class Utils {
1313
public static String[] categoryMap = {"India", "World", "Entertainment" , "Technology", "Business","Science" , "Sports", "Health"};
1414

1515
public static boolean isNetworkConnected(Context context) {
16-
ConnectivityManager cm = (ConnectivityManager) context.getSystemService(Context.CONNECTIVITY_SERVICE);
17-
NetworkInfo ni = cm.getActiveNetworkInfo();
18-
if (ni == null) {
19-
// There are no active networks.
16+
17+
try {
18+
ConnectivityManager cm = (ConnectivityManager) context.getSystemService(Context.CONNECTIVITY_SERVICE);
19+
NetworkInfo ni = cm.getActiveNetworkInfo();
20+
if (ni == null) {
21+
// There are no active networks.
22+
return false;
23+
} else {
24+
return true;
25+
}
26+
} catch (Exception e) {
27+
e.printStackTrace();
2028
return false;
21-
} else
22-
return true;
29+
}
30+
2331
}
2432
}

0 commit comments

Comments
 (0)