fix es6 with dynamic import to not show as missing dependencies (#96)

Author: davidfirst

CHANGELOG.md

@@ -7,7 +7,11 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ## [unreleased]
 
-## [2.0.5-dev.1] - 2019-03-10
+## [2.0.5-dev.2] - 2019-04-17
+
+- fix es6 with dynamic import to not show as missing dependencies
+
+## [2.0.5-dev.1] - 2019-04-16
 
 - improve performance by lazy load all external packages and internal files
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "bit-javascript",
-  "version": "2.0.5-dev.1",
+  "version": "2.0.5-dev.2",
   "scripts": {
     "flow": "flow; test $? -eq 0 -o $? -eq 2",
     "lint": "eslint src && flow check || true",

src/dependency-builder/dependency-tree/index.spec.js

@@ -865,4 +865,23 @@ describe('dependencyTree', function () {
       expect(dependencies).to.be.ok;
     });
   });
+  describe('files with dynamic import', () => {
+    it('should not', () => {
+      mockfs({
+        [`${__dirname}/dynamic`]: {
+          'foo.js': 'const a = "./b"; import(a); require(a);'
+        }
+      });
+      const directory = path.normalize(`${__dirname}/dynamic`);
+      const filename = path.normalize(`${directory}/foo.js`);
+      const visited = {};
+
+      dependencyTree({
+        filename,
+        directory,
+        visited
+      });
+      expect(visited[filename].missing).to.be.undefined;
+    });
+  });
 });

src/dependency-builder/detectives/detective-es6/index.js

@@ -68,12 +68,13 @@ module.exports = function (src) {
         }
         break;
       case 'CallExpression':
-        if (node.callee.type === 'Import' && node.arguments.length) {
+        if (node.callee.type === 'Import' && node.arguments.length && node.arguments[0].value) {
           addDependency(node.arguments[0].value);
         }
         if (
           node.callee.type === 'Identifier' && // taken from detective-cjs
           node.callee.name === 'require' &&
+          node.arguments[0].value &&
           node.arguments &&
           node.arguments.length &&
           (node.arguments[0].type === 'Literal' || node.arguments[0].type === 'StringLiteral')
@@ -88,6 +89,7 @@ module.exports = function (src) {
           node.object.callee.name === 'require' &&
           node.object.arguments &&
           node.object.arguments.length &&
+          node.object.arguments[0].value &&
           (node.object.arguments[0].type === 'Literal' || node.object.arguments[0].type === 'StringLiteral')
         ) {
           const depValue = node.object.arguments[0].value;