resolve teambit/bit#1925, fix Angular non-relative paths from decorators

Author: David First

CHANGELOG.md

@@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ## [unreleased]
 
+- [#1925](https://github.com/teambit/bit/issues/1925) fix Angular non-relative paths from decorators
+
 ## [2.1.1-dev.1] - 2019-08-12
 
 - remove angular dependencies. use typescript compiler to parse Angular Decorators

package-lock.json

@@ -2,6 +2,7 @@
  * this file had been forked from https://github.com/pahen/detective-typescript
  */
 import { getDependenciesFromMemberExpression, getDependenciesFromCallExpression } from '../parser-helper';
+import { isRelativeImport } from '../../../utils';
 
 const Parser = require('@typescript-eslint/typescript-estree');
 const Walker = require('node-source-walk');
@@ -24,6 +25,10 @@ module.exports = function (src, options = {}) {
       dependencies[dependency] = {};
     }
   };
+  const addAngularLocalDependency = (dependency) => {
+    const angularDep = isRelativeImport(dependency) ? dependency : `./${dependency}`;
+    addDependency(angularDep);
+  };
   const addImportSpecifier = (dependency, importSpecifier) => {
     if (dependencies[dependency].importSpecifiers) {
       dependencies[dependency].importSpecifiers.push(importSpecifier);
@@ -106,14 +111,14 @@ module.exports = function (src, options = {}) {
           angularComponent.forEach((prop) => {
             if (!prop.key || !prop.value) return;
             if (prop.key.name === 'templateUrl' && prop.value.type === 'Literal') {
-              addDependency(prop.value.value);
+              addAngularLocalDependency(prop.value.value);
             }
             if (prop.key.name === 'styleUrl' && prop.value.type === 'Literal') {
-              addDependency(prop.value.value);
+              addAngularLocalDependency(prop.value.value);
             }
             if (prop.key.name === 'styleUrls' && prop.value.type === 'ArrayExpression') {
               const literalsElements = prop.value.elements.filter(e => e.type === 'Literal');
-              literalsElements.forEach(element => addDependency(element.value));
+              literalsElements.forEach(element => addAngularLocalDependency(element.value));
             }
           });
         }

src/dependency-builder/detectives/detective-typescript/index.js

@@ -136,7 +136,7 @@ describe('detective-typescript', () => {
       @Component({
         selector: 'main-component',
         templateUrl: './my-template.html',
-        styleUrls: ['./my-style1.css', styleUrl, './my-style3.css']
+        styleUrls: ['./my-style1.css', styleUrl, './my-style3.css', 'my-style4.css']
       })
       export class MainComponent {}`;
       const results = detective(componentDecorator); // eslint-disable-line
@@ -152,5 +152,8 @@ describe('detective-typescript', () => {
     it('should not recognize dynamic style (style path entered as a variable)', () => {
       expect(deps).to.not.include('./my-style2.css');
     });
+    it('should change non-relative paths to be relative', () => {
+      expect(deps).to.include('./my-style4.css');
+    });
   });
 });