fix UIGestureRecognizerDelegate conflict bug

Author: hongxinhope

.swiftlint.yml

@@ -3,6 +3,7 @@ disabled_rules: # rule identifiers to exclude from running
   - nesting
   - variable_name_min_length
   - cyclomatic_complexity
+  - class_delegate_protocol
 included: # paths to include during linting. `--path` is ignored if present. takes precendence over `excluded`.
 excluded: # paths to ignore during linting. overridden by `included`.
   - Carthage

Example/EmptyDataDemoCollectionViewController.swift

@@ -73,7 +73,7 @@ class EmptyDataDemoCollectionViewController: UICollectionViewController {
         self.dataCount -= 1
         collectionView.performBatchUpdates({
             self.collectionView?.deleteItems(at: [indexPath])
-            }) { (completed) in
+            }) { (_) in
 
         }
     }

Example/Info.plist

@@ -15,11 +15,11 @@
 	<key>CFBundlePackageType</key>
 	<string>APPL</string>
 	<key>CFBundleShortVersionString</key>
-	<string>2.4</string>
+	<string>2.5</string>
 	<key>CFBundleSignature</key>
 	<string>????</string>
 	<key>CFBundleVersion</key>
-	<string>15</string>
+	<string>16</string>
 	<key>LSRequiresIPhoneOS</key>
 	<true/>
 	<key>UILaunchStoryboardName</key>

TBEmptyDataSet.podspec

@@ -1,7 +1,7 @@
 Pod::Spec.new do |s|
 
   s.name         = "TBEmptyDataSet"
-  s.version      = "2.4"
+  s.version      = "2.5"
   s.summary      = "An extension of UITableView/UICollectionView's super class, it will display a placeholder when the data is empty."
 
   s.homepage     = "https://github.com/teambition/TBEmptyDataSet"

TBEmptyDataSet/EmptyDataView.swift

@@ -125,7 +125,7 @@ internal class EmptyDataView: UIView {
         let centerY = NSLayoutConstraint(item: contentView, attribute: .centerY, relatedBy: .equal, toItem: self, attribute: .centerY, multiplier: 1, constant: verticalOffset)
         addConstraint(centerX)
         addConstraint(centerY)
-        addConstraints(NSLayoutConstraint.constraints(withVisualFormat: "H:|[\(ViewStrings.contentView)]|", options: [], metrics: nil, views: [ViewStrings.contentView : contentView]))
+        addConstraints(NSLayoutConstraint.constraints(withVisualFormat: "H:|[\(ViewStrings.contentView)]|", options: [], metrics: nil, views: [ViewStrings.contentView: contentView]))
 
         if let customView = customView {
             let translatesFrameIntoConstraints = customView.translatesAutoresizingMaskIntoConstraints
@@ -168,7 +168,7 @@ internal class EmptyDataView: UIView {
                 let viewString = ViewStrings.titleLabel
                 viewStrings.append(viewString)
                 views[viewString] = titleLabel
-                contentView.addConstraints(NSLayoutConstraint.constraints(withVisualFormat: "H:|-[\(ViewStrings.titleLabel)(>=0)]-|", options: [], metrics: nil, views: [ViewStrings.titleLabel : titleLabel]))
+                contentView.addConstraints(NSLayoutConstraint.constraints(withVisualFormat: "H:|-[\(ViewStrings.titleLabel)(>=0)]-|", options: [], metrics: nil, views: [ViewStrings.titleLabel: titleLabel]))
             } else {
                 titleLabel.removeFromSuperview()
             }
@@ -180,7 +180,7 @@ internal class EmptyDataView: UIView {
                 let viewString = ViewStrings.descriptionLabel
                 viewStrings.append(viewString)
                 views[viewString] = descriptionLabel
-                contentView.addConstraints(NSLayoutConstraint.constraints(withVisualFormat: "H:|-[\(ViewStrings.descriptionLabel)(>=0)]-|", options: [], metrics: nil, views: [ViewStrings.descriptionLabel : descriptionLabel]))
+                contentView.addConstraints(NSLayoutConstraint.constraints(withVisualFormat: "H:|-[\(ViewStrings.descriptionLabel)(>=0)]-|", options: [], metrics: nil, views: [ViewStrings.descriptionLabel: descriptionLabel]))
             } else {
                 descriptionLabel.removeFromSuperview()
             }

TBEmptyDataSet/Supporting Files/Info.plist

@@ -15,7 +15,7 @@
 	<key>CFBundlePackageType</key>
 	<string>FMWK</string>
 	<key>CFBundleShortVersionString</key>
-	<string>2.4</string>
+	<string>2.5</string>
 	<key>CFBundleSignature</key>
 	<string>????</string>
 	<key>CFBundleVersion</key>

TBEmptyDataSet/TBEmptyDataSet.swift

@@ -8,7 +8,7 @@
 
 import UIKit
 
-extension UIScrollView: UIGestureRecognizerDelegate {
+extension UIScrollView {
     // MARK: - Properties
     public var emptyDataSetDataSource: TBEmptyDataSetDataSource? {
         get {
@@ -125,7 +125,6 @@ extension UIScrollView: UIGestureRecognizerDelegate {
         emptyDataView.autoresizingMask = [.flexibleHeight, .flexibleWidth]
         emptyDataView.isHidden = true
         let tapGesture = UITapGestureRecognizer(target: self, action: #selector(didTapEmptyDataView(_:)))
-        tapGesture.delegate = self
         emptyDataView.addGestureRecognizer(tapGesture)
         emptyDataView.tapGesture = tapGesture
         return emptyDataView
@@ -174,21 +173,6 @@ extension UIScrollView: UIGestureRecognizerDelegate {
         emptyDataSetDelegate?.emptyDataSetDidDisappear(in: self)
     }
 
-    // MARK: - UIGestureRecognizer delegate
-    override open func gestureRecognizerShouldBegin(_ gestureRecognizer: UIGestureRecognizer) -> Bool {
-        if gestureRecognizer.view is EmptyDataView {
-            return emptyDataSetTapEnabled()
-        }
-        return super.gestureRecognizerShouldBegin(gestureRecognizer)
-    }
-
-    open func gestureRecognizer(_ gestureRecognizer: UIGestureRecognizer, shouldRecognizeSimultaneouslyWith otherGestureRecognizer: UIGestureRecognizer) -> Bool {
-        if let emptyDataView = emptyDataView, gestureRecognizer == emptyDataView.tapGesture || otherGestureRecognizer == emptyDataView.tapGesture {
-            return true
-        }
-        return false
-    }
-
     // MARK: - Display
     // swiftlint:disable function_body_length
     fileprivate func reloadEmptyDataSet() {
@@ -273,7 +257,6 @@ extension UIScrollView: UIGestureRecognizerDelegate {
         let swizzledSelector = Selectors.tableViewSwizzledReloadData
 
         tb_swizzleMethod(for: UITableView.self, originalSelector: originalSelector, swizzledSelector: swizzledSelector)
-        print("tb_swizzleTableViewReloadData")
     }()
 
     // swiftlint:disable variable_name
@@ -282,7 +265,6 @@ extension UIScrollView: UIGestureRecognizerDelegate {
         let swizzledSelector = Selectors.tableViewSwizzledEndUpdates
 
         tb_swizzleMethod(for: UITableView.self, originalSelector: originalSelector, swizzledSelector: swizzledSelector)
-        print("tb_swizzleTableViewEndUpdates")
     }()
 
     // swiftlint:disable variable_name
@@ -291,7 +273,6 @@ extension UIScrollView: UIGestureRecognizerDelegate {
         let swizzledSelector = Selectors.collectionViewSwizzledReloadData
 
         tb_swizzleMethod(for: UICollectionView.self, originalSelector: originalSelector, swizzledSelector: swizzledSelector)
-        print("tb_swizzleCollectionViewReloadData")
     }()
 
     // swiftlint:disable variable_name
@@ -300,7 +281,6 @@ extension UIScrollView: UIGestureRecognizerDelegate {
         let swizzledSelector = Selectors.collectionViewSwizzledPerformBatchUpdates
 
         tb_swizzleMethod(for: UICollectionView.self, originalSelector: originalSelector, swizzledSelector: swizzledSelector)
-        print("tb_swizzleCollectionViewPerformBatchUpdates")
     }()
 
     func tb_tableViewSwizzledReloadData() {