diff --git a/config/services.php b/config/services.php index ac6f240..e9b96ac 100644 --- a/config/services.php +++ b/config/services.php @@ -3,19 +3,18 @@ use FOS\HttpCacheBundle\CacheManager; use Neusta\Pimcore\HttpCacheBundle\Adapter\FOSHttpCache\CacheInvalidatorAdapter; use Neusta\Pimcore\HttpCacheBundle\Adapter\FOSHttpCache\ResponseTaggerAdapter; -use Neusta\Pimcore\HttpCacheBundle\Cache\CacheInvalidator; -use Neusta\Pimcore\HttpCacheBundle\Cache\CacheInvalidator\OnlyWhenActiveCacheInvalidator; -use Neusta\Pimcore\HttpCacheBundle\Cache\CacheInvalidator\RemoveDisabledTagsCacheInvalidator; -use Neusta\Pimcore\HttpCacheBundle\Cache\CacheTagChecker; -use Neusta\Pimcore\HttpCacheBundle\Cache\CacheTagChecker\ElementCacheTagChecker; -use Neusta\Pimcore\HttpCacheBundle\Cache\CacheTagChecker\StaticCacheTagChecker; -use Neusta\Pimcore\HttpCacheBundle\Cache\ResponseTagger; -use Neusta\Pimcore\HttpCacheBundle\Cache\ResponseTagger\OnlyWhenActiveResponseTagger; -use Neusta\Pimcore\HttpCacheBundle\Cache\ResponseTagger\RemoveDisabledTagsResponseTagger; use Neusta\Pimcore\HttpCacheBundle\CacheActivator; +use Neusta\Pimcore\HttpCacheBundle\CacheInvalidator; +use Neusta\Pimcore\HttpCacheBundle\CacheInvalidator\OnlyWhenActiveCacheInvalidator; +use Neusta\Pimcore\HttpCacheBundle\CacheInvalidator\RemoveDisabledTagsCacheInvalidator; +use Neusta\Pimcore\HttpCacheBundle\CacheTag\CacheTagChecker\ElementCacheTagChecker; +use Neusta\Pimcore\HttpCacheBundle\CacheTag\CacheTagChecker\StaticCacheTagChecker; use Neusta\Pimcore\HttpCacheBundle\Element\ElementRepository; -use Neusta\Pimcore\HttpCacheBundle\Element\InvalidateElementListener; -use Neusta\Pimcore\HttpCacheBundle\Element\TagElementListener; +use Neusta\Pimcore\HttpCacheBundle\Element\EventListener\InvalidateElementListener; +use Neusta\Pimcore\HttpCacheBundle\Element\EventListener\TagElementListener; +use Neusta\Pimcore\HttpCacheBundle\ResponseTagger; +use Neusta\Pimcore\HttpCacheBundle\ResponseTagger\OnlyWhenActiveResponseTagger; +use Neusta\Pimcore\HttpCacheBundle\ResponseTagger\RemoveDisabledTagsResponseTagger; use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator; use function Symfony\Component\DependencyInjection\Loader\Configurator\abstract_arg; use function Symfony\Component\DependencyInjection\Loader\Configurator\inline_service; @@ -24,48 +23,51 @@ return static function (ContainerConfigurator $configurator) { $services = $configurator->services(); - $services->set(CacheActivator::class); + $services->set('neusta_pimcore_http_cache.cache_activator', CacheActivator::class) + ->alias(CacheActivator::class, 'neusta_pimcore_http_cache.cache_activator'); - $services->set(CacheInvalidator::class, CacheInvalidatorAdapter::class) + $services->set('neusta_pimcore_http_cache.cache_invalidator', CacheInvalidatorAdapter::class) ->arg('$invalidator', service(CacheManager::class)); - $services->set(RemoveDisabledTagsCacheInvalidator::class) - ->decorate(CacheInvalidator::class, null, -99) - ->args([service('.inner'), service(CacheTagChecker::class)]); + $services->set(null, RemoveDisabledTagsCacheInvalidator::class) + ->decorate('neusta_pimcore_http_cache.cache_invalidator', null, -99) + ->args([service('.inner'), service('neusta_pimcore_http_cache.cache_tag_checker')]); - $services->set(OnlyWhenActiveCacheInvalidator::class) - ->decorate(CacheInvalidator::class, null, -100) - ->args([service('.inner'), service(CacheActivator::class)]); + $services->set(null, OnlyWhenActiveCacheInvalidator::class) + ->decorate('neusta_pimcore_http_cache.cache_invalidator', null, -100) + ->args([service('.inner'), service('neusta_pimcore_http_cache.cache_activator')]); - $services->set(ResponseTagger::class, ResponseTaggerAdapter::class) + $services->alias(CacheInvalidator::class, 'neusta_pimcore_http_cache.cache_invalidator'); + + $services->set('neusta_pimcore_http_cache.response_tagger', ResponseTaggerAdapter::class) ->arg('$responseTagger', service('fos_http_cache.http.symfony_response_tagger')); - $services->set(RemoveDisabledTagsResponseTagger::class) - ->decorate(ResponseTagger::class, null, -99) - ->args([service('.inner'), service(CacheTagChecker::class)]); + $services->set(null, RemoveDisabledTagsResponseTagger::class) + ->decorate('neusta_pimcore_http_cache.response_tagger', null, -99) + ->args([service('.inner'), service('neusta_pimcore_http_cache.cache_tag_checker')]); + + $services->set(null, OnlyWhenActiveResponseTagger::class) + ->decorate('neusta_pimcore_http_cache.response_tagger', null, -100) + ->args([service('.inner'), service('neusta_pimcore_http_cache.cache_activator')]); - $services->set(OnlyWhenActiveResponseTagger::class) - ->decorate(ResponseTagger::class, null, -100) - ->args([service('.inner'), service(CacheActivator::class)]); + $services->alias(ResponseTagger::class, 'neusta_pimcore_http_cache.response_tagger'); - $services->set(StaticCacheTagChecker::class) + $services->set('neusta_pimcore_http_cache.cache_tag_checker', StaticCacheTagChecker::class) ->arg('$types', abstract_arg('Set in the extension')); - $services->set(ElementCacheTagChecker::class) - ->decorate(StaticCacheTagChecker::class) + $services->set('neusta_pimcore_http_cache.cache_tag_checker.element', ElementCacheTagChecker::class) + ->decorate('neusta_pimcore_http_cache.cache_tag_checker') ->arg('$inner', service('.inner')) ->arg('$repository', inline_service(ElementRepository::class)) ->arg('$assets', ['enabled' => false, 'types' => []]) ->arg('$documents', ['enabled' => false, 'types' => []]) ->arg('$objects', ['enabled' => false, 'types' => [], 'classes' => []]); - $services->alias(CacheTagChecker::class, StaticCacheTagChecker::class); - - $services->set(TagElementListener::class) - ->arg('$responseTagger', service(ResponseTagger::class)) + $services->set('neusta_pimcore_http_cache.element.tag_listener', TagElementListener::class) + ->arg('$responseTagger', service('neusta_pimcore_http_cache.response_tagger')) ->arg('$dispatcher', service('event_dispatcher')); - $services->set(InvalidateElementListener::class) - ->arg('$cacheInvalidator', service(CacheInvalidator::class)) + $services->set('neusta_pimcore_http_cache.element.invalidate_listener', InvalidateElementListener::class) + ->arg('$cacheInvalidator', service('neusta_pimcore_http_cache.cache_invalidator')) ->arg('$dispatcher', service('event_dispatcher')); }; diff --git a/src/Adapter/FOSHttpCache/CacheInvalidatorAdapter.php b/src/Adapter/FOSHttpCache/CacheInvalidatorAdapter.php index afe08a0..89cce1c 100644 --- a/src/Adapter/FOSHttpCache/CacheInvalidatorAdapter.php +++ b/src/Adapter/FOSHttpCache/CacheInvalidatorAdapter.php @@ -3,8 +3,8 @@ namespace Neusta\Pimcore\HttpCacheBundle\Adapter\FOSHttpCache; use FOS\HttpCache\CacheInvalidator as FosCacheInvalidator; -use Neusta\Pimcore\HttpCacheBundle\Cache\CacheInvalidator; -use Neusta\Pimcore\HttpCacheBundle\Cache\CacheTags; +use Neusta\Pimcore\HttpCacheBundle\CacheInvalidator; +use Neusta\Pimcore\HttpCacheBundle\CacheTags; final class CacheInvalidatorAdapter implements CacheInvalidator { diff --git a/src/Adapter/FOSHttpCache/ResponseTaggerAdapter.php b/src/Adapter/FOSHttpCache/ResponseTaggerAdapter.php index 454b603..62348cf 100644 --- a/src/Adapter/FOSHttpCache/ResponseTaggerAdapter.php +++ b/src/Adapter/FOSHttpCache/ResponseTaggerAdapter.php @@ -4,8 +4,8 @@ namespace Neusta\Pimcore\HttpCacheBundle\Adapter\FOSHttpCache; use FOS\HttpCache\ResponseTagger as FosResponseTagger; -use Neusta\Pimcore\HttpCacheBundle\Cache\CacheTags; -use Neusta\Pimcore\HttpCacheBundle\Cache\ResponseTagger; +use Neusta\Pimcore\HttpCacheBundle\CacheTags; +use Neusta\Pimcore\HttpCacheBundle\ResponseTagger; final class ResponseTaggerAdapter implements ResponseTagger { diff --git a/src/Cache/CacheTypeFactory.php b/src/Cache/CacheTypeFactory.php deleted file mode 100644 index e32e486..0000000 --- a/src/Cache/CacheTypeFactory.php +++ /dev/null @@ -1,31 +0,0 @@ -toString())) { + if (!$type instanceof ElementCacheTagType && ElementCacheTagType::isReserved($type->toString())) { throw InvalidArgumentException::becauseCacheTypeIsReserved($type); } } - public static function fromString(string $tag, ?CacheType $type = null): self + public static function fromString(string $tag, ?CacheTagType $type = null): self { - return new self($tag, $type ?? CacheTypeFactory::createEmpty()); + return new self($tag, $type ?? CacheTagTypeFactory::createEmpty()); } public static function fromElement(ElementInterface $element): self @@ -32,7 +34,7 @@ public static function fromElement(ElementInterface $element): self throw InvalidArgumentException::becauseElementHasNoId(); } - return new self((string) $id, CacheTypeFactory::createFromElement($element)); + return new self((string) $id, CacheTagTypeFactory::createFromElement($element)); } public function toString(): string diff --git a/src/Cache/CacheTagChecker.php b/src/CacheTag/CacheTagChecker.php similarity index 54% rename from src/Cache/CacheTagChecker.php rename to src/CacheTag/CacheTagChecker.php index 549e43f..cddcbc7 100644 --- a/src/Cache/CacheTagChecker.php +++ b/src/CacheTag/CacheTagChecker.php @@ -1,6 +1,8 @@ type instanceof ElementCacheType) { + if (!$tag->type instanceof ElementCacheTagType) { return $this->inner->isEnabled($tag); } diff --git a/src/Cache/CacheTagChecker/StaticCacheTagChecker.php b/src/CacheTag/CacheTagChecker/StaticCacheTagChecker.php similarity index 71% rename from src/Cache/CacheTagChecker/StaticCacheTagChecker.php rename to src/CacheTag/CacheTagChecker/StaticCacheTagChecker.php index 4583dec..2baa968 100644 --- a/src/Cache/CacheTagChecker/StaticCacheTagChecker.php +++ b/src/CacheTag/CacheTagChecker/StaticCacheTagChecker.php @@ -1,9 +1,9 @@ tags = $tags; } - public static function fromString(string $tag, ?CacheType $type = null): self + public static function fromString(string $tag, ?CacheTagType $type = null): self { return new self(CacheTag::fromString($tag, $type)); } @@ -30,7 +32,7 @@ public static function fromString(string $tag, ?CacheType $type = null): self /** * @param list $tags */ - public static function fromStrings(array $tags, ?CacheType $type = null): self + public static function fromStrings(array $tags, ?CacheTagType $type = null): self { return new self(...array_map(fn ($tag) => CacheTag::fromString($tag, $type), $tags)); } diff --git a/src/DependencyInjection/NeustaPimcoreHttpCacheExtension.php b/src/DependencyInjection/NeustaPimcoreHttpCacheExtension.php index ac1d3ec..860edf0 100644 --- a/src/DependencyInjection/NeustaPimcoreHttpCacheExtension.php +++ b/src/DependencyInjection/NeustaPimcoreHttpCacheExtension.php @@ -2,10 +2,6 @@ namespace Neusta\Pimcore\HttpCacheBundle\DependencyInjection; -use Neusta\Pimcore\HttpCacheBundle\Cache\CacheTagChecker\ElementCacheTagChecker; -use Neusta\Pimcore\HttpCacheBundle\Cache\CacheTagChecker\StaticCacheTagChecker; -use Neusta\Pimcore\HttpCacheBundle\Element\InvalidateElementListener; -use Neusta\Pimcore\HttpCacheBundle\Element\TagElementListener; use Pimcore\Event\AssetEvents; use Pimcore\Event\DataObjectEvents; use Pimcore\Event\DocumentEvents; @@ -25,7 +21,7 @@ public function loadInternal(array $mergedConfig, ContainerBuilder $container): $loader->load('services.php'); - $container->getDefinition(StaticCacheTagChecker::class) + $container->getDefinition('neusta_pimcore_http_cache.cache_tag_checker') ->setArgument('$types', $mergedConfig['cache_types']); $this->registerElements($container, $mergedConfig['elements']); @@ -36,9 +32,9 @@ public function loadInternal(array $mergedConfig, ContainerBuilder $container): */ private function registerElements(ContainerBuilder $container, array $config): void { - $tagChecker = $container->getDefinition(ElementCacheTagChecker::class); - $tagListener = $container->getDefinition(TagElementListener::class); - $invalidateListener = $container->getDefinition(InvalidateElementListener::class); + $tagChecker = $container->getDefinition('neusta_pimcore_http_cache.cache_tag_checker.element'); + $tagListener = $container->getDefinition('neusta_pimcore_http_cache.element.tag_listener'); + $invalidateListener = $container->getDefinition('neusta_pimcore_http_cache.element.invalidate_listener'); if ($config['assets']['enabled']) { $tagChecker->setArgument('$assets', $config['assets']); diff --git a/src/Element/ElementInvalidationEvent.php b/src/Element/Event/ElementInvalidationEvent.php similarity index 82% rename from src/Element/ElementInvalidationEvent.php rename to src/Element/Event/ElementInvalidationEvent.php index 1e0fcaf..4f3c90b 100644 --- a/src/Element/ElementInvalidationEvent.php +++ b/src/Element/Event/ElementInvalidationEvent.php @@ -1,9 +1,10 @@ get(CacheActivator::class); + $cacheActivator = self::getContainer()->get('test.cache_activator'); \assert($cacheActivator instanceof CacheActivator); $wasActive = $cacheActivator->isCachingActive(); diff --git a/tests/Integration/Invalidation/CancelInvalidationTest.php b/tests/Integration/Invalidation/CancelInvalidationTest.php index ec9364c..91c4e9e 100644 --- a/tests/Integration/Invalidation/CancelInvalidationTest.php +++ b/tests/Integration/Invalidation/CancelInvalidationTest.php @@ -3,7 +3,7 @@ namespace Neusta\Pimcore\HttpCacheBundle\Tests\Integration\Invalidation; use FOS\HttpCacheBundle\CacheManager; -use Neusta\Pimcore\HttpCacheBundle\Element\ElementInvalidationEvent; +use Neusta\Pimcore\HttpCacheBundle\Element\Event\ElementInvalidationEvent; use Neusta\Pimcore\HttpCacheBundle\Tests\Integration\Helpers\ArrangeCacheTest; use Neusta\Pimcore\HttpCacheBundle\Tests\Integration\Helpers\TestAssetFactory; use Neusta\Pimcore\HttpCacheBundle\Tests\Integration\Helpers\TestDocumentFactory; diff --git a/tests/Integration/Invalidation/InvalidateAdditionalTagTest.php b/tests/Integration/Invalidation/InvalidateAdditionalTagTest.php index 55f8662..0c65396 100644 --- a/tests/Integration/Invalidation/InvalidateAdditionalTagTest.php +++ b/tests/Integration/Invalidation/InvalidateAdditionalTagTest.php @@ -3,9 +3,9 @@ namespace Neusta\Pimcore\HttpCacheBundle\Tests\Integration\Invalidation; use FOS\HttpCacheBundle\CacheManager; -use Neusta\Pimcore\HttpCacheBundle\Cache\CacheTag; -use Neusta\Pimcore\HttpCacheBundle\Cache\CacheType\CustomCacheType; -use Neusta\Pimcore\HttpCacheBundle\Element\ElementInvalidationEvent; +use Neusta\Pimcore\HttpCacheBundle\CacheTag; +use Neusta\Pimcore\HttpCacheBundle\CacheTag\CacheTagType\CustomCacheTagType; +use Neusta\Pimcore\HttpCacheBundle\Element\Event\ElementInvalidationEvent; use Neusta\Pimcore\HttpCacheBundle\Tests\Integration\Helpers\ArrangeCacheTest; use Neusta\Pimcore\HttpCacheBundle\Tests\Integration\Helpers\TestAssetFactory; use Neusta\Pimcore\HttpCacheBundle\Tests\Integration\Helpers\TestDocumentFactory; @@ -35,7 +35,7 @@ protected function setUp(): void self::getContainer()->get('event_dispatcher')->addListener( ElementInvalidationEvent::class, fn (ElementInvalidationEvent $event) => $event->addTag( - CacheTag::fromString('bar', new CustomCacheType('foo')), + CacheTag::fromString('bar', new CustomCacheTagType('foo')), ), ); } diff --git a/tests/Integration/Tagging/TagAdditionalTagTest.php b/tests/Integration/Tagging/TagAdditionalTagTest.php index 5abf34f..d8a0af5 100644 --- a/tests/Integration/Tagging/TagAdditionalTagTest.php +++ b/tests/Integration/Tagging/TagAdditionalTagTest.php @@ -2,11 +2,11 @@ namespace Neusta\Pimcore\HttpCacheBundle\Tests\Integration\Tagging; -use Neusta\Pimcore\HttpCacheBundle\Cache\CacheTag; -use Neusta\Pimcore\HttpCacheBundle\Cache\CacheType\CustomCacheType; -use Neusta\Pimcore\HttpCacheBundle\Cache\CacheType\ElementCacheType; -use Neusta\Pimcore\HttpCacheBundle\Element\ElementTaggingEvent; +use Neusta\Pimcore\HttpCacheBundle\CacheTag; +use Neusta\Pimcore\HttpCacheBundle\CacheTag\CacheTagType\CustomCacheTagType; +use Neusta\Pimcore\HttpCacheBundle\CacheTag\CacheTagType\ElementCacheTagType; use Neusta\Pimcore\HttpCacheBundle\Element\ElementType; +use Neusta\Pimcore\HttpCacheBundle\Element\Event\ElementTaggingEvent; use Neusta\Pimcore\HttpCacheBundle\Tests\Integration\Helpers\ArrangeCacheTest; use Neusta\Pimcore\HttpCacheBundle\Tests\Integration\Helpers\TestAssetFactory; use Neusta\Pimcore\HttpCacheBundle\Tests\Integration\Helpers\TestDocumentFactory; @@ -50,7 +50,7 @@ public function response_is_tagged_with_additional_tag_when_asset_is_loaded(): v self::getContainer()->get('event_dispatcher')->addListener( ElementTaggingEvent::class, fn (ElementTaggingEvent $event) => $event->addTag( - CacheTag::fromString('17', new ElementCacheType(ElementType::Asset)), + CacheTag::fromString('17', new ElementCacheTagType(ElementType::Asset)), ), ); @@ -80,7 +80,7 @@ public function response_is_tagged_with_additional_tag_when_document_is_loaded() self::getContainer()->get('event_dispatcher')->addListener( ElementTaggingEvent::class, fn (ElementTaggingEvent $event) => $event->addTag( - CacheTag::fromString('23', new ElementCacheType(ElementType::Document)), + CacheTag::fromString('23', new ElementCacheTagType(ElementType::Document)), ), ); @@ -110,7 +110,7 @@ public function response_is_tagged_with_additional_tag_when_object_is_loaded(): self::getContainer()->get('event_dispatcher')->addListener( ElementTaggingEvent::class, fn (ElementTaggingEvent $event) => $event->addTag( - CacheTag::fromString('17', new ElementCacheType(ElementType::Object)), + CacheTag::fromString('17', new ElementCacheTagType(ElementType::Object)), ), ); @@ -142,7 +142,7 @@ public function response_is_tagged_with_custom_tag_when_element_is_loaded(): voi self::getContainer()->get('event_dispatcher')->addListener( ElementTaggingEvent::class, fn (ElementTaggingEvent $event) => $event->addTag( - CacheTag::fromString('bar', new CustomCacheType('foo')), + CacheTag::fromString('bar', new CustomCacheTagType('foo')), ), ); diff --git a/tests/Unit/Adapter/FOSHttpCache/CacheInvalidatorAdapterTest.php b/tests/Unit/Adapter/FOSHttpCache/CacheInvalidatorAdapterTest.php index 01656c2..ed90a79 100644 --- a/tests/Unit/Adapter/FOSHttpCache/CacheInvalidatorAdapterTest.php +++ b/tests/Unit/Adapter/FOSHttpCache/CacheInvalidatorAdapterTest.php @@ -4,7 +4,7 @@ use FOS\HttpCache\CacheInvalidator as FosCacheInvalidator; use Neusta\Pimcore\HttpCacheBundle\Adapter\FOSHttpCache\CacheInvalidatorAdapter; -use Neusta\Pimcore\HttpCacheBundle\Cache\CacheTags; +use Neusta\Pimcore\HttpCacheBundle\CacheTags; use PHPUnit\Framework\TestCase; use Prophecy\Argument; use Prophecy\PhpUnit\ProphecyTrait; diff --git a/tests/Unit/Cache/CacheInvalidator/OnlyWhenActiveCacheInvalidatorTest.php b/tests/Unit/Cache/CacheInvalidator/OnlyWhenActiveCacheInvalidatorTest.php index 9f9de17..be4a651 100644 --- a/tests/Unit/Cache/CacheInvalidator/OnlyWhenActiveCacheInvalidatorTest.php +++ b/tests/Unit/Cache/CacheInvalidator/OnlyWhenActiveCacheInvalidatorTest.php @@ -2,10 +2,10 @@ namespace Neusta\Pimcore\HttpCacheBundle\Tests\Unit\Cache\CacheInvalidator; -use Neusta\Pimcore\HttpCacheBundle\Cache\CacheInvalidator; -use Neusta\Pimcore\HttpCacheBundle\Cache\CacheInvalidator\OnlyWhenActiveCacheInvalidator; -use Neusta\Pimcore\HttpCacheBundle\Cache\CacheTags; use Neusta\Pimcore\HttpCacheBundle\CacheActivator; +use Neusta\Pimcore\HttpCacheBundle\CacheInvalidator; +use Neusta\Pimcore\HttpCacheBundle\CacheInvalidator\OnlyWhenActiveCacheInvalidator; +use Neusta\Pimcore\HttpCacheBundle\CacheTags; use PHPUnit\Framework\TestCase; use Prophecy\Argument; use Prophecy\PhpUnit\ProphecyTrait; diff --git a/tests/Unit/Cache/CacheInvalidator/RemoveDisabledTagsCacheInvalidatorTest.php b/tests/Unit/Cache/CacheInvalidator/RemoveDisabledTagsCacheInvalidatorTest.php index 6f6441e..1780f51 100644 --- a/tests/Unit/Cache/CacheInvalidator/RemoveDisabledTagsCacheInvalidatorTest.php +++ b/tests/Unit/Cache/CacheInvalidator/RemoveDisabledTagsCacheInvalidatorTest.php @@ -2,11 +2,11 @@ namespace Neusta\Pimcore\HttpCacheBundle\Tests\Unit\Cache\CacheInvalidator; -use Neusta\Pimcore\HttpCacheBundle\Cache\CacheInvalidator; -use Neusta\Pimcore\HttpCacheBundle\Cache\CacheInvalidator\RemoveDisabledTagsCacheInvalidator; -use Neusta\Pimcore\HttpCacheBundle\Cache\CacheTag; -use Neusta\Pimcore\HttpCacheBundle\Cache\CacheTagChecker; -use Neusta\Pimcore\HttpCacheBundle\Cache\CacheTags; +use Neusta\Pimcore\HttpCacheBundle\CacheInvalidator; +use Neusta\Pimcore\HttpCacheBundle\CacheInvalidator\RemoveDisabledTagsCacheInvalidator; +use Neusta\Pimcore\HttpCacheBundle\CacheTag; +use Neusta\Pimcore\HttpCacheBundle\CacheTag\CacheTagChecker; +use Neusta\Pimcore\HttpCacheBundle\CacheTags; use PHPUnit\Framework\TestCase; use Prophecy\PhpUnit\ProphecyTrait; use Prophecy\Prophecy\ObjectProphecy; diff --git a/tests/Unit/Cache/CacheTagChecker/ElementCacheTagCheckerTest.php b/tests/Unit/Cache/CacheTagChecker/ElementCacheTagCheckerTest.php index 259b2c2..e56c2d5 100644 --- a/tests/Unit/Cache/CacheTagChecker/ElementCacheTagCheckerTest.php +++ b/tests/Unit/Cache/CacheTagChecker/ElementCacheTagCheckerTest.php @@ -2,10 +2,10 @@ namespace Neusta\Pimcore\HttpCacheBundle\Tests\Unit\Cache\CacheTagChecker; -use Neusta\Pimcore\HttpCacheBundle\Cache\CacheTag; -use Neusta\Pimcore\HttpCacheBundle\Cache\CacheTagChecker; -use Neusta\Pimcore\HttpCacheBundle\Cache\CacheTagChecker\ElementCacheTagChecker; -use Neusta\Pimcore\HttpCacheBundle\Cache\CacheType\CustomCacheType; +use Neusta\Pimcore\HttpCacheBundle\CacheTag; +use Neusta\Pimcore\HttpCacheBundle\CacheTag\CacheTagChecker; +use Neusta\Pimcore\HttpCacheBundle\CacheTag\CacheTagChecker\ElementCacheTagChecker; +use Neusta\Pimcore\HttpCacheBundle\CacheTag\CacheTagType\CustomCacheTagType; use Neusta\Pimcore\HttpCacheBundle\Element\ElementRepository; use PHPUnit\Framework\TestCase; use Pimcore\Model\Asset; @@ -35,7 +35,7 @@ protected function setUp(): void */ public function it_delegates_cache_tag_check_to_next_cache_tag_checker(): void { - $tag = CacheTag::fromString('foo', new CustomCacheType('custom')); + $tag = CacheTag::fromString('foo', new CustomCacheTagType('custom')); $elementCacheTagChecker = new ElementCacheTagChecker( $this->innerCacheTagChecker->reveal(), $this->elementRepository->reveal(), diff --git a/tests/Unit/Cache/CacheTagChecker/StaticCacheTagCheckerTest.php b/tests/Unit/Cache/CacheTagChecker/StaticCacheTagCheckerTest.php index 023aafd..76303a5 100644 --- a/tests/Unit/Cache/CacheTagChecker/StaticCacheTagCheckerTest.php +++ b/tests/Unit/Cache/CacheTagChecker/StaticCacheTagCheckerTest.php @@ -2,9 +2,9 @@ namespace Neusta\Pimcore\HttpCacheBundle\Tests\Unit\Cache\CacheTagChecker; -use Neusta\Pimcore\HttpCacheBundle\Cache\CacheTag; -use Neusta\Pimcore\HttpCacheBundle\Cache\CacheTagChecker\StaticCacheTagChecker; -use Neusta\Pimcore\HttpCacheBundle\Cache\CacheType\CustomCacheType; +use Neusta\Pimcore\HttpCacheBundle\CacheTag; +use Neusta\Pimcore\HttpCacheBundle\CacheTag\CacheTagChecker\StaticCacheTagChecker; +use Neusta\Pimcore\HttpCacheBundle\CacheTag\CacheTagType\CustomCacheTagType; use PHPUnit\Framework\TestCase; final class StaticCacheTagCheckerTest extends TestCase @@ -28,7 +28,7 @@ public function it_returns_true_when_cache_type_is_enabled(): void { self::assertTrue( (new StaticCacheTagChecker(['foo' => true]))->isEnabled( - CacheTag::fromString('foo', new CustomCacheType('foo')), + CacheTag::fromString('foo', new CustomCacheTagType('foo')), ), ); } @@ -40,7 +40,7 @@ public function it_returns_false_when_cache_type_is_disabled(): void { self::assertFalse( (new StaticCacheTagChecker(['foo' => false]))->isEnabled( - CacheTag::fromString('foo', new CustomCacheType('foo')), + CacheTag::fromString('foo', new CustomCacheTagType('foo')), ), ); } @@ -52,7 +52,7 @@ public function it_returns_false_when_cache_type_is_not_set(): void { self::assertFalse( (new StaticCacheTagChecker(['bar' => true]))->isEnabled( - CacheTag::fromString('foo', new CustomCacheType('foo')), + CacheTag::fromString('foo', new CustomCacheTagType('foo')), ), ); } diff --git a/tests/Unit/Cache/ResponseTagger/OnlyWhenActiveResponseTaggerTest.php b/tests/Unit/Cache/ResponseTagger/OnlyWhenActiveResponseTaggerTest.php index 3512462..fd2ea0b 100644 --- a/tests/Unit/Cache/ResponseTagger/OnlyWhenActiveResponseTaggerTest.php +++ b/tests/Unit/Cache/ResponseTagger/OnlyWhenActiveResponseTaggerTest.php @@ -2,10 +2,10 @@ namespace Neusta\Pimcore\HttpCacheBundle\Tests\Unit\Cache\ResponseTagger; -use Neusta\Pimcore\HttpCacheBundle\Cache\CacheTags; -use Neusta\Pimcore\HttpCacheBundle\Cache\ResponseTagger; -use Neusta\Pimcore\HttpCacheBundle\Cache\ResponseTagger\OnlyWhenActiveResponseTagger; use Neusta\Pimcore\HttpCacheBundle\CacheActivator; +use Neusta\Pimcore\HttpCacheBundle\CacheTags; +use Neusta\Pimcore\HttpCacheBundle\ResponseTagger; +use Neusta\Pimcore\HttpCacheBundle\ResponseTagger\OnlyWhenActiveResponseTagger; use PHPUnit\Framework\TestCase; use Prophecy\Argument; use Prophecy\PhpUnit\ProphecyTrait; diff --git a/tests/Unit/Cache/ResponseTagger/RemoveDisabledTagsResponseTaggerTest.php b/tests/Unit/Cache/ResponseTagger/RemoveDisabledTagsResponseTaggerTest.php index 7cf836e..16a4a7c 100644 --- a/tests/Unit/Cache/ResponseTagger/RemoveDisabledTagsResponseTaggerTest.php +++ b/tests/Unit/Cache/ResponseTagger/RemoveDisabledTagsResponseTaggerTest.php @@ -2,11 +2,11 @@ namespace Neusta\Pimcore\HttpCacheBundle\Tests\Unit\Cache\ResponseTagger; -use Neusta\Pimcore\HttpCacheBundle\Cache\CacheTag; -use Neusta\Pimcore\HttpCacheBundle\Cache\CacheTagChecker; -use Neusta\Pimcore\HttpCacheBundle\Cache\CacheTags; -use Neusta\Pimcore\HttpCacheBundle\Cache\ResponseTagger; -use Neusta\Pimcore\HttpCacheBundle\Cache\ResponseTagger\RemoveDisabledTagsResponseTagger; +use Neusta\Pimcore\HttpCacheBundle\CacheTag; +use Neusta\Pimcore\HttpCacheBundle\CacheTag\CacheTagChecker; +use Neusta\Pimcore\HttpCacheBundle\CacheTags; +use Neusta\Pimcore\HttpCacheBundle\ResponseTagger; +use Neusta\Pimcore\HttpCacheBundle\ResponseTagger\RemoveDisabledTagsResponseTagger; use PHPUnit\Framework\TestCase; use Prophecy\PhpUnit\ProphecyTrait; use Prophecy\Prophecy\ObjectProphecy; diff --git a/tests/Unit/Element/InvalidateElementListenerTest.php b/tests/Unit/Element/InvalidateElementListenerTest.php index 21d541b..33f4bcc 100644 --- a/tests/Unit/Element/InvalidateElementListenerTest.php +++ b/tests/Unit/Element/InvalidateElementListenerTest.php @@ -2,11 +2,11 @@ namespace Neusta\Pimcore\HttpCacheBundle\Tests\Unit\Element; -use Neusta\Pimcore\HttpCacheBundle\Cache\CacheInvalidator; -use Neusta\Pimcore\HttpCacheBundle\Cache\CacheTag; -use Neusta\Pimcore\HttpCacheBundle\Cache\CacheTags; -use Neusta\Pimcore\HttpCacheBundle\Element\ElementInvalidationEvent; -use Neusta\Pimcore\HttpCacheBundle\Element\InvalidateElementListener; +use Neusta\Pimcore\HttpCacheBundle\CacheInvalidator; +use Neusta\Pimcore\HttpCacheBundle\CacheTag; +use Neusta\Pimcore\HttpCacheBundle\CacheTags; +use Neusta\Pimcore\HttpCacheBundle\Element\Event\ElementInvalidationEvent; +use Neusta\Pimcore\HttpCacheBundle\Element\EventListener\InvalidateElementListener; use PHPUnit\Framework\TestCase; use Pimcore\Event\Model\AssetEvent; use Pimcore\Event\Model\DataObjectEvent; diff --git a/tests/Unit/Element/TagElementListenerTest.php b/tests/Unit/Element/TagElementListenerTest.php index 0bc2dfc..fe0cb2e 100644 --- a/tests/Unit/Element/TagElementListenerTest.php +++ b/tests/Unit/Element/TagElementListenerTest.php @@ -2,11 +2,11 @@ namespace Neusta\Pimcore\HttpCacheBundle\Tests\Unit\Element; -use Neusta\Pimcore\HttpCacheBundle\Cache\CacheTag; -use Neusta\Pimcore\HttpCacheBundle\Cache\CacheTags; -use Neusta\Pimcore\HttpCacheBundle\Cache\ResponseTagger; -use Neusta\Pimcore\HttpCacheBundle\Element\ElementTaggingEvent; -use Neusta\Pimcore\HttpCacheBundle\Element\TagElementListener; +use Neusta\Pimcore\HttpCacheBundle\CacheTag; +use Neusta\Pimcore\HttpCacheBundle\CacheTags; +use Neusta\Pimcore\HttpCacheBundle\Element\Event\ElementTaggingEvent; +use Neusta\Pimcore\HttpCacheBundle\Element\EventListener\TagElementListener; +use Neusta\Pimcore\HttpCacheBundle\ResponseTagger; use PHPUnit\Framework\TestCase; use Pimcore\Event\Model\AssetEvent; use Pimcore\Event\Model\DataObjectEvent; diff --git a/tests/app/config/services.php b/tests/app/config/services.php index 1cccc0f..d9e71d1 100644 --- a/tests/app/config/services.php +++ b/tests/app/config/services.php @@ -2,7 +2,6 @@ namespace Symfony\Component\DependencyInjection\Loader\Configurator; -use Neusta\Pimcore\HttpCacheBundle\CacheActivator; use Neusta\Pimcore\HttpCacheBundle\Tests\Integration\Helpers\ClearRuntimeCacheListener; use Pimcore\Event\AssetEvents; use Pimcore\Event\DataObjectEvents; @@ -25,6 +24,6 @@ ->tag('kernel.event_listener', ['event' => DocumentEvents::POST_UPDATE]) ->tag('kernel.event_listener', ['event' => DocumentEvents::POST_DELETE]); - $services->set(CacheActivator::class) + $services->alias('test.cache_activator', 'neusta_pimcore_http_cache.cache_activator') ->public(); };