Skip to content

Commit 471b526

Browse files
committed
found a performance bug in reductions/impl.
1 parent 0421cc2 commit 471b526

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

deps.edn

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,11 @@
153153
:jdk-11
154154
{:jvm-opts ["--add-opens=java.base/jdk.internal.ref=ALL-UNNAMED"]}
155155
:jdk-17
156+
{:jvm-opts ["--add-modules" "jdk.incubator.foreign,jdk.incubator.vector"
157+
"--enable-native-access=ALL-UNNAMED"
158+
"--add-opens=java.base/jdk.internal.ref=ALL-UNNAMED"
159+
"--add-opens=java.base/sun.nio.ch=ALL-UNNAMED"]}
160+
:jdk-21
156161
{:jvm-opts ["--add-modules" "jdk.incubator.foreign,jdk.incubator.vector"
157162
"--enable-native-access=ALL-UNNAMED"
158163
"--add-opens=java.base/jdk.internal.ref=ALL-UNNAMED"

src/tech/v3/dataset/reductions/impl.clj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
(reify
4848
hamf-proto/Reducer
4949
(->init-val-fn [r] init-fn)
50-
(->rfn [r] (hamf-rf/double-accumulator
50+
(->rfn [r] (hamf-rf/long-accumulator
5151
acc v (.invokePrim rfn acc (.readDouble col v))))
5252
hamf-proto/ParallelReducer
5353
(->merge-fn [r] merge-fn)))

0 commit comments

Comments
 (0)