Skip to content

Commit beba5a5

Browse files
committed
Fixes #447
1 parent 05b027f commit beba5a5

File tree

3 files changed

+13
-1
lines changed

3 files changed

+13
-1
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,8 @@
11
# Changelog
2+
# 7.038
3+
* Upgrade to hamf 2.020.
4+
* Fix for [issue 447](https://github.com/techascent/tech.ml.dataset/issues/447) - filter column by keyword.
5+
26
# 7.037
37
* Nippy loading is about 2x faster in the case of large string tables.
48
* Arrow read pathways support :text-as-strings? to mirror :strings-as-text? on the write side so you can save out uncompressed data in the fastest-to-read format.

deps.edn

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{:paths ["src" "resources" "target/classes"]
22
:deps {;;org.clojure/clojure {:mvn/version "1.11.1"}
3-
cnuernber/dtype-next {:mvn/version "10.125"}
3+
cnuernber/dtype-next {:mvn/version "10.127"}
44
techascent/tech.io {:mvn/version "4.31"
55
:exclusions [org.apache.commons/commons-compress]}
66
org.apache.datasketches/datasketches-java {:mvn/version "4.2.0"}

test/tech/v3/dataset_test.clj

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1767,6 +1767,14 @@
17671767
(is (= :all (:print-index-range (meta (ds/sort-by-column sds :x)))))
17681768
(is (= :all (:print-index-range (meta (ds/filter-column sds :x pos?)))))))
17691769

1770+
1771+
(deftest issue-447-filter-column-by-keyword
1772+
(is (= [:a :a :a :a :a]
1773+
(-> (ds/->dataset {:a [:a :b :a :c :a :d :a :e :a :f]})
1774+
(ds/filter-column :a :a)
1775+
(ds/column :a)
1776+
(vec)))))
1777+
17701778
(comment
17711779
(require '[criterium.core :as crit])
17721780
(def data (vec (repeatedly 100000 (fn [] {:a (rand-int 20) :b (rand) :c (rand)}))))

0 commit comments

Comments
 (0)