Skip to content

Commit d1ff3d5

Browse files
committed
Add missing generic parameter to view models
1 parent 8506015 commit d1ff3d5

File tree

4 files changed

+19
-19
lines changed

4 files changed

+19
-19
lines changed

patternfx-core/src/main/java/com/techsenger/patternfx/core/AbstractChildComponent.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ public abstract class AbstractChildComponent<T extends AbstractChildView<?, ?>>
2828

2929
protected class Mediator extends AbstractParentComponent.Mediator implements ChildMediator {
3030

31-
private final ReadOnlyObjectWrapper<ParentViewModel> parent = new ReadOnlyObjectWrapper<>();
31+
private final ReadOnlyObjectWrapper<ParentViewModel<?>> parent = new ReadOnlyObjectWrapper<>();
3232

3333
private final AbstractChildComponent<?> component = AbstractChildComponent.this;
3434

@@ -45,12 +45,12 @@ public Mediator() {
4545
}
4646

4747
@Override
48-
public ReadOnlyObjectProperty<ParentViewModel> parentProperty() {
48+
public ReadOnlyObjectProperty<ParentViewModel<?>> parentProperty() {
4949
return this.parent.getReadOnlyProperty();
5050
}
5151

5252
@Override
53-
public ParentViewModel getParent() {
53+
public ParentViewModel<?> getParent() {
5454
return this.parent.get();
5555
}
5656
}

patternfx-core/src/main/java/com/techsenger/patternfx/core/AbstractParentComponent.java

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,9 @@ protected class Mediator extends AbstractComponent.Mediator implements ParentMed
3333

3434
private final ListBinder childrenBinder;
3535

36-
private final ObservableList<ChildViewModel> modifiableChildren = FXCollections.observableArrayList();
36+
private final ObservableList<ChildViewModel<?>> modifiableChildren = FXCollections.observableArrayList();
3737

38-
private final ObservableList<ChildViewModel> children =
38+
private final ObservableList<ChildViewModel<?>> children =
3939
FXCollections.unmodifiableObservableList(modifiableChildren);
4040

4141
private final AbstractParentComponent<?> component = AbstractParentComponent.this;
@@ -46,29 +46,29 @@ public Mediator() {
4646
}
4747

4848
@Override
49-
public SubtreeIterator<ParentViewModel> depthFirstIterator() {
50-
return new AbstractDepthFirstIterator<ParentViewModel>(getView().getViewModel()) {
49+
public SubtreeIterator<ParentViewModel<?>> depthFirstIterator() {
50+
return new AbstractDepthFirstIterator<ParentViewModel<?>>(getView().getViewModel()) {
5151

5252
@Override
53-
List<ParentViewModel> getChildren(ParentViewModel parent) {
54-
return (List) children;
53+
List<ParentViewModel<?>> getChildren(ParentViewModel<?> parent) {
54+
return (List) parent.getMediator().getChildren();
5555
}
5656
};
5757
}
5858

5959
@Override
60-
public SubtreeIterator<ParentViewModel> breadthFirstIterator() {
61-
return new AbstractBreadthFirstIterator<ParentViewModel>(getView().getViewModel()) {
60+
public SubtreeIterator<ParentViewModel<?>> breadthFirstIterator() {
61+
return new AbstractBreadthFirstIterator<ParentViewModel<?>>(getView().getViewModel()) {
6262

6363
@Override
64-
List<ParentViewModel> getChildren(ParentViewModel parent) {
65-
return (List) children;
64+
List<ParentViewModel<?>> getChildren(ParentViewModel<?> parent) {
65+
return (List) parent.getMediator().getChildren();
6666
}
6767
};
6868
}
6969

7070
@Override
71-
public ObservableList<ChildViewModel> getChildren() {
71+
public ObservableList<ChildViewModel<?>> getChildren() {
7272
return children;
7373
}
7474
}

patternfx-core/src/main/java/com/techsenger/patternfx/core/ChildMediator.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,12 +30,12 @@ public interface ChildMediator extends ParentMediator {
3030
*
3131
* @return the property containing the parent component
3232
*/
33-
ReadOnlyObjectProperty<ParentViewModel> parentProperty();
33+
ReadOnlyObjectProperty<ParentViewModel<?>> parentProperty();
3434

3535
/**
3636
* Returns the value of {@link #parentProperty()}.
3737
*
3838
* @return the parent component, or {@code null} if this component has no parent
3939
*/
40-
ParentViewModel getParent();
40+
ParentViewModel<?> getParent();
4141
}

patternfx-core/src/main/java/com/techsenger/patternfx/core/ParentMediator.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,19 +29,19 @@ public interface ParentMediator extends ComponentMediator {
2929
*
3030
* @return a non-null, unmodifiable observable list of child ViewModels
3131
*/
32-
ObservableList<ChildViewModel> getChildren();
32+
ObservableList<ChildViewModel<?>> getChildren();
3333

3434
/**
3535
* Returns an iterator that traverses the component subtree starting from this component in depth-first order.
3636
*
3737
* @return an {@link Iterator} that iterates over this component and all of its descendants
3838
*/
39-
SubtreeIterator<ParentViewModel> depthFirstIterator();
39+
SubtreeIterator<ParentViewModel<?>> depthFirstIterator();
4040

4141
/**
4242
* Returns an iterator that traverses the component subtree starting from this component in breadth-first order.
4343
*
4444
* @return an {@link Iterator} that iterates over this component and all of its descendants
4545
*/
46-
SubtreeIterator<ParentViewModel> breadthFirstIterator();
46+
SubtreeIterator<ParentViewModel<?>> breadthFirstIterator();
4747
}

0 commit comments

Comments
 (0)