Revert back to using net472 for tests in the short term. XUnit console runner doesn't support .NET Core 3.1 and makes it difficult to implement the logging factory under .NET Core 2.1. Hoping to multi-target - will investigate running tests via Visual Studio runner if possible.

Author: techyian

tests/MMALSharp.Tests/MMALFixture.cs

@@ -6,6 +6,9 @@
 using System;
 using System.IO;
 using System.Linq;
+using Microsoft.Extensions.Logging;
+using MMALSharp.Common.Utility;
+using NLog.Extensions.Logging;
 using Xunit;
 
 namespace MMALSharp.Tests
@@ -17,6 +20,16 @@ public class MMALFixture : IDisposable
 
         public MMALFixture()
         {
+            var loggerFactory = LoggerFactory.Create(builder =>
+            {
+
+                builder
+                    .ClearProviders()
+                    .SetMinimumLevel(LogLevel.Trace)
+                    .AddNLog("NLog.config");
+            });
+
+            MMALLog.LoggerFactory = loggerFactory;
         }
 
         public void CheckAndAssertFilepath(string filepath)

tests/MMALSharp.Tests/MMALSharp.Tests.csproj

@@ -1,8 +1,8 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
-    <OutputType>Exe</OutputType>
+    <!--<OutputType>Exe</OutputType>-->
     <AssemblyTitle>MMALSharp.Tests</AssemblyTitle>
-    <TargetFramework>netcoreapp2.2</TargetFramework>
+    <TargetFramework>net472</TargetFramework>
     <IsPackable>false</IsPackable>
     <AssemblyName>MMALSharp.Tests</AssemblyName>
     <PackageId>MMALSharp.Tests</PackageId>
@@ -15,7 +15,9 @@
     <Folder Include="Properties\" />    
   </ItemGroup>
   <ItemGroup>
+    <PackageReference Include="Microsoft.Extensions.Logging" Version="3.1.0" />
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.4.0" />
+    <PackageReference Include="NLog.Extensions.Logging" Version="1.6.1" />
     <PackageReference Include="StyleCop.Analyzers" Version="1.0.2">
       <PrivateAssets>All</PrivateAssets>
     </PackageReference>
@@ -34,6 +36,9 @@
     <Service Include="{82a7f48d-3b50-4b1e-b82e-3ada8210c358}" />
   </ItemGroup>
   <ItemGroup>
+    <None Update="NLog.config">
+      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
+    </None>
     <None Update="xunit.runner.json">
       <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
     </None>

tests/MMALSharp.Tests/NLog.config

@@ -0,0 +1,23 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<!-- XSD manual extracted from package NLog.Schema: https://www.nuget.org/packages/NLog.Schema-->
+<nlog xmlns="http://www.nlog-project.org/schemas/NLog.xsd" xsi:schemaLocation="NLog NLog.xsd"
+      xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+      autoReload="true"
+      internalLogFile="${basedir}/console-example-internal.log"
+      internalLogLevel="Info" >
+
+  <!-- the targets to write to -->
+  <targets>
+    <!-- write logs to file -->
+    <target xsi:type="File" name="target1" fileName="${basedir}/mmal-log-${shortdate}.log"
+            layout="${date}|${level:uppercase=true}|${message} ${exception}|${logger}|${all-event-properties}" />
+    <target xsi:type="Console" name="target2"
+            layout="${date}|${level:uppercase=true}|${message} ${exception}|${logger}|${all-event-properties}" />
+  </targets>
+
+  <!-- rules to map from logger name to target -->
+  <rules>
+    <logger name="*" minlevel="Trace" writeTo="target1" />
+    <logger name="*" minlevel="Info" writeTo="target2" />
+  </rules>
+</nlog>