src/io/local_cache.rs: add fixme for setting readonly

alexander-bauer · alexander-bauer · commit b14c8ca89b35 · 2017-06-03T11:12:17.000-04:00
diff --git a/src/io/local_cache.rs b/src/io/local_cache.rs
@@ -307,6 +307,8 @@ impl<B: IoProvider> LocalCache<B> {
         }
 
         // Make the file readonly once it's at its final path.
+        // XXX: It would be better to set these using the already-open file handle owned by the
+        // tempfile, but mkstemp doesn't give us access.
         let mut perms = match fs::metadata(&final_path) {
             Ok(p) => p,
             Err(e) => return OpenResult::Err(e.into()),

Original file line number	Diff line number	Diff line change
`@@ -307,6 +307,8 @@ impl<B: IoProvider> LocalCache<B> {`
`307`	`307`	`}`
`308`	`308`
`309`	`309`	`// Make the file readonly once it's at its final path.`
	`310`	`+ // XXX: It would be better to set these using the already-open file handle owned by the`
	`311`	`+ // tempfile, but mkstemp doesn't give us access.`
`310`	`312`	`let mut perms = match fs::metadata(&final_path) {`
`311`	`313`	`Ok(p) => p,`
`312`	`314`	`Err(e) => return OpenResult::Err(e.into()),`