Fix issue where planActSeparateModelsSetting was initialized with non-undefined value

Author: saoudrizwan

src/core/webview/ClineProvider.ts

@@ -143,7 +143,8 @@ export class ClineProvider implements vscode.WebviewViewProvider {
 		// Set defaults for new users
 		;(async () => {
 			const existingPlanActSeparateModelsSetting = await this.getGlobalState("planActSeparateModelsSetting")
-			if (existingPlanActSeparateModelsSetting === undefined) {
+			// initial state may be undefined or empty string, so we check for existence of expected values
+			if (existingPlanActSeparateModelsSetting !== true && existingPlanActSeparateModelsSetting !== false) {
 				// If api provider is not set, it's a new user. In order to get past the welcome screen, the user needs to choose an api provider and api key (logging into cline sets provider to cline). This is a good opportunity to set values for NEW users that we don't want to modify defaults for existing users. For example, existing users may already be using model switching between plan/act, but new users shouldn't be opted in to this behavior by default.
 				const apiProvider = await this.getGlobalState("apiProvider")
 				if (!apiProvider) {
@@ -1989,7 +1990,7 @@ Here is the project's README to help you get started:\n\n${mcpDetails.readmeCont
 			asksageApiUrl,
 			xaiApiKey,
 			thinkingBudgetTokens,
-			planActSeparateModelsSetting,
+			planActSeparateModelsSettingRaw,
 		] = await Promise.all([
 			this.getGlobalState("apiProvider") as Promise<ApiProvider | undefined>,
 			this.getGlobalState("apiModelId") as Promise<string | undefined>,
@@ -2072,6 +2073,12 @@ Here is the project's README to help you get started:\n\n${mcpDetails.readmeCont
 
 		const mcpMarketplaceEnabled = vscode.workspace.getConfiguration("cline").get<boolean>("mcpMarketplace.enabled", true)
 
+		// On win11 state sometimes initializes as empty string instead of undefined
+		let planActSeparateModelsSetting: boolean | undefined = undefined
+		if (planActSeparateModelsSettingRaw === true || planActSeparateModelsSettingRaw === false) {
+			planActSeparateModelsSetting = planActSeparateModelsSettingRaw
+		}
+
 		return {
 			apiConfiguration: {
 				apiProvider,