fix(tests): resolve TypeScript and linter errors

claude · claude · commit 898556c5b02e · 2025-12-20T15:03:06.000Z
- Remove unused ParameterData import from data-type.ts
- Fix member delimiter style (use commas not semicolons) in data-type.ts
- Change ParserOptions type annotations to type assertions for partial objects
- Add non-null assertions for optional collation property access
- Use 'as unknown as' pattern for ColumnMetadata[] and Message casts
- Fix Message import (default export, not named export)
diff --git a/test/unit/data-type.ts b/test/unit/data-type.ts
@@ -1,4 +1,4 @@
-import { typeByName as TYPES, type ParameterData } from '../../src/data-type';
+import { typeByName as TYPES } from '../../src/data-type';
 import { type InternalConnectionOptions } from '../../src/connection';
 
 import { assert } from 'chai';
@@ -1500,7 +1500,7 @@ describe('VarBinary', function() {
 
   describe('.generateParameterData', function() {
     it('correctly converts `null` values', () => {
-      const testCases: Array<{ value: null; length: number; expected: Buffer }> = [
+      const testCases: Array<{ value: null, length: number, expected: Buffer }> = [
         { value: null, length: 1, expected: Buffer.from([]) },
         { value: null, length: 9000, expected: Buffer.from([]) }
       ];
@@ -1512,7 +1512,7 @@ describe('VarBinary', function() {
     });
 
     it('correctly converts `number` values', () => {
-      const testCases: Array<{ value: number; length: number; expected: Buffer }> = [
+      const testCases: Array<{ value: number, length: number, expected: Buffer }> = [
         { value: 1, length: 1, expected: Buffer.from('3100', 'hex') },
       ];
       for (const { value, length, expected } of testCases) {
diff --git a/test/unit/token/colmetadata-token-parser-test.ts b/test/unit/token/colmetadata-token-parser-test.ts
@@ -6,7 +6,7 @@ import Debug from '../../../src/debug';
 import { assert } from 'chai';
 
 const debug = new Debug();
-const options: ParserOptions = { tdsVersion: '7_2', useUTC: false };
+const options = { tdsVersion: '7_2', useUTC: false } as ParserOptions;
 
 describe('Colmetadata Token Parser', () => {
   describe('parsing the column metadata for a result with many columns', function() {
@@ -111,11 +111,11 @@ describe('Colmetadata Token Parser', () => {
     assert.strictEqual(token.columns[0].userType, 2);
     assert.strictEqual(token.columns[0].flags, 3);
     assert.strictEqual(token.columns[0].type.name, 'VarChar');
-    assert.strictEqual(token.columns[0].collation.lcid, 0x0409);
-    assert.strictEqual(token.columns[0].collation.codepage, 'CP1257');
-    assert.strictEqual(token.columns[0].collation.flags, 0x85);
-    assert.strictEqual(token.columns[0].collation.version, 0x7);
-    assert.strictEqual(token.columns[0].collation.sortId, 0x9a);
+    assert.strictEqual(token.columns[0].collation!.lcid, 0x0409);
+    assert.strictEqual(token.columns[0].collation!.codepage, 'CP1257');
+    assert.strictEqual(token.columns[0].collation!.flags, 0x85);
+    assert.strictEqual(token.columns[0].collation!.version, 0x7);
+    assert.strictEqual(token.columns[0].collation!.sortId, 0x9a);
     assert.strictEqual(token.columns[0].colName, 'name');
     assert.strictEqual(token.columns[0].dataLength, length);
   });
diff --git a/test/unit/token/done-token-parser-test.ts b/test/unit/token/done-token-parser-test.ts
@@ -5,7 +5,7 @@ import Debug from '../../../src/debug';
 import { assert } from 'chai';
 
 const debug = new Debug();
-const options: ParserOptions = { tdsVersion: '7_2', useUTC: false };
+const options = { tdsVersion: '7_2', useUTC: false } as ParserOptions;
 
 function parse(status: number, curCmd: number, doneRowCount: number) {
   const doneRowCountLow = doneRowCount % 0x100000000;
diff --git a/test/unit/token/env-change-token-parser-test.ts b/test/unit/token/env-change-token-parser-test.ts
@@ -5,7 +5,7 @@ import Debug from '../../../src/debug';
 import { assert } from 'chai';
 
 const debug = new Debug();
-const options: ParserOptions = { tdsVersion: '7_2', useUTC: false };
+const options = { tdsVersion: '7_2', useUTC: false } as ParserOptions;
 
 describe('Env Change Token Parser', () => {
   it('should write to database', async () => {
diff --git a/test/unit/token/feature-ext-parser-test.ts b/test/unit/token/feature-ext-parser-test.ts
@@ -5,7 +5,7 @@ import Debug from '../../../src/debug';
 import { assert } from 'chai';
 
 const debug = new Debug();
-const options: ParserOptions = { tdsVersion: '7_2', useUTC: false };
+const options = { tdsVersion: '7_2', useUTC: false } as ParserOptions;
 
 describe('Feature Ext Parser', () => {
   it('should be fed authentication', async () => {
diff --git a/test/unit/token/fedauth-info-parser-test.ts b/test/unit/token/fedauth-info-parser-test.ts
@@ -5,7 +5,7 @@ import Debug from '../../../src/debug';
 import { assert } from 'chai';
 
 const debug = new Debug();
-const options: ParserOptions = { tdsVersion: '7_2', useUTC: false };
+const options = { tdsVersion: '7_2', useUTC: false } as ParserOptions;
 
 describe('Fedauth Info Parser', () => {
   it('should contain fed auth info', async () => {
diff --git a/test/unit/token/infoerror-token-parser-test.ts b/test/unit/token/infoerror-token-parser-test.ts
@@ -5,7 +5,7 @@ import Debug from '../../../src/debug';
 import { assert } from 'chai';
 
 const debug = new Debug();
-const options: ParserOptions = { tdsVersion: '7_2', useUTC: false };
+const options = { tdsVersion: '7_2', useUTC: false } as ParserOptions;
 
 describe('Infoerror token parser', () => {
   it('should have correct info', async () => {
diff --git a/test/unit/token/loginack-token-parser-test.ts b/test/unit/token/loginack-token-parser-test.ts
@@ -5,7 +5,7 @@ import Debug from '../../../src/debug';
 import { assert } from 'chai';
 
 const debug = new Debug();
-const options: ParserOptions = { tdsVersion: '7_2', useUTC: false };
+const options = { tdsVersion: '7_2', useUTC: false } as ParserOptions;
 
 describe('Loginack Token Parser', () => {
   it('should have correct info', async () => {
diff --git a/test/unit/token/nbcrow-token-parser-test.ts b/test/unit/token/nbcrow-token-parser-test.ts
@@ -8,10 +8,10 @@ import WritableTrackingBuffer from '../../../src/tracking-buffer/writable-tracki
 import Debug from '../../../src/debug';
 
 const debug = new Debug();
-const options: ParserOptions = {
+const options = {
   useUTC: false,
   tdsVersion: '7_2'
-};
+} as ParserOptions;
 
 describe('NBCRow Token Parser', function() {
   describe('parsing a row with many columns', function() {
@@ -33,7 +33,7 @@ describe('NBCRow Token Parser', function() {
         buffer.writeUsVarchar(i.toString());
       }
 
-      const parser = Parser.parseTokens([buffer.data], debug, options, colMetadata as ColumnMetadata[]);
+      const parser = Parser.parseTokens([buffer.data], debug, options, colMetadata as unknown as ColumnMetadata[]);
       const result = await parser.next();
       assert.isFalse(result.done);
       const token = result.value;
diff --git a/test/unit/token/order-token-parser-test.ts b/test/unit/token/order-token-parser-test.ts
@@ -5,7 +5,7 @@ import Debug from '../../../src/debug';
 import { assert } from 'chai';
 
 const debug = new Debug();
-const options: ParserOptions = { tdsVersion: '7_2', useUTC: false };
+const options = { tdsVersion: '7_2', useUTC: false } as ParserOptions;
 
 describe('Order Token Parser', () => {
   it('should have one column', async () => {
diff --git a/test/unit/token/row-token-parser-test.ts b/test/unit/token/row-token-parser-test.ts
diff --git a/test/unit/token/sspi-token-parser-test.ts b/test/unit/token/sspi-token-parser-test.ts
diff --git a/test/unit/token/token-stream-parser-test.ts b/test/unit/token/token-stream-parser-test.ts
