refactor(tests): replace generic assertions with specific ones

- Replace assert.ok(boolean) / assert.isOk(boolean) with assert.isTrue()
- Replace assert.ok(!boolean) with assert.isFalse()
- Replace assert.ok(value) for existence checks with assert.isDefined()
- Replace assert.ok(false) with assert.fail()
- Replace assert.ok(x instanceof Y) with assert.instanceOf(x, Y)
- Replace assert.ok(~str.indexOf(x)) with assert.include(str, x)
- Replace assert.isOk(/regex/.test(str)) with assert.match(str, /regex/)
- Replace assert.isTrue(buf.equals(x)) with assert.deepEqual(buf, x)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: arthurschreiber

test/integration/bulk-load-test.ts

@@ -142,7 +142,7 @@ describe('BulkLoad', function() {
 
   it('checks constraints if the `checkConstraints` option is set to `true`', function(done) {
     const bulkLoad = connection.newBulkLoad('#tmpTestTable3', { checkConstraints: true }, (err, rowCount) => {
-      assert.ok(err, 'An error should have been thrown to indicate the conflict with the CHECK constraint.');
+      assert.isDefined(err, 'An error should have been thrown to indicate the conflict with the CHECK constraint.');
 
       assert.strictEqual(rowCount, 0);
 

test/integration/connection-test.ts

@@ -87,15 +87,15 @@ describe('Initiate Connect Test', function() {
 
     connection.on('errorMessage', function(error) {
       // console.log(`${error.number} : ${error.message}`)
-      return assert.ok(~error.message.indexOf('failed') || ~error.message.indexOf('登录失败'));
+      assert.isTrue(error.message.includes('failed') || error.message.includes('登录失败'));
     });
 
     if (process.env.TEDIOUS_DEBUG) {
       connection.on('debug', console.log);
     }
 
     connection.connect(function(err) {
-      assert.ok(err);
+      assert.isDefined(err);
 
       connection.close();
     });
@@ -154,7 +154,7 @@ describe('Initiate Connect Test', function() {
     });
 
     connection.connect(function(err) {
-      assert.ok(err);
+      assert.isDefined(err);
 
       connection.close();
     });
@@ -427,7 +427,7 @@ describe('Ntlm Test', function() {
 
         break;
       default:
-        assert.ok(false, 'Unexpected value for domainCase: ' + domainCase);
+        assert.fail('Unexpected value for domainCase: ' + domainCase);
     }
 
     let row = 0;
@@ -706,7 +706,7 @@ describe('Insertion Tests', function() {
     });
 
     request.on('doneInProc', function(rowCount, more) {
-      assert.ok(more);
+      assert.isTrue(more);
       assert.strictEqual(rowCount, 1);
     });
 
@@ -905,7 +905,7 @@ describe('Insertion Tests', function() {
       });
 
       request.on('doneInProc', function(rowCount, more) {
-        assert.ok(more);
+        assert.isTrue(more);
         assert.strictEqual(rowCount, 1);
       });
 
@@ -953,7 +953,7 @@ describe('Insertion Tests', function() {
     });
 
     request.on('doneInProc', function(rowCount, more) {
-      assert.ok(more);
+      assert.isTrue(more);
       assert.strictEqual(rowCount, 2);
     });
 
@@ -998,7 +998,7 @@ describe('Insertion Tests', function() {
     const config = getConfig();
 
     const request = new Request('bad syntax here', function(err) {
-      assert.ok(err);
+      assert.isDefined(err);
 
       connection.close();
     });
@@ -1015,7 +1015,7 @@ describe('Insertion Tests', function() {
 
     connection.on('errorMessage', function(error) {
       // console.log("#{error.number} : #{error.message}")
-      assert.ok(error);
+      assert.isDefined(error);
     });
 
     if (process.env.TEDIOUS_DEBUG) {
@@ -1248,16 +1248,16 @@ update #tab1 set name = 'a3' where name like 'a%'\
     });
 
     request.on('doneProc', function(rowCount, more, returnStatus) {
-      assert.ok(!more);
+      assert.isFalse(more);
       assert.strictEqual(returnStatus, 0);
     });
 
     request.on('doneInProc', function(rowCount, more) {
-      assert.ok(more);
+      assert.isTrue(more);
     });
 
-    request.on('row', function(columns) {
-      assert.ok(true);
+    request.on('row', function(_columns) {
+      // Row received as expected
     });
 
     let connection = new Connection(config);
@@ -1314,7 +1314,7 @@ update #tab1 set name = 'a3' where name like 'a%'\
     let connection = new Connection(config);
 
     connection.on('resetConnection', function() {
-      assert.ok(true);
+      // Reset connection event received as expected
     });
 
     connection.connect(function(err) {
@@ -1324,11 +1324,8 @@ update #tab1 set name = 'a3' where name like 'a%'\
         testAnsiNullsOptionOff,
         function(callback) {
           connection.reset(function(err) {
-            if (connection.config.options.tdsVersion < '7_2') {
-              // TDS 7_1 doesnt send RESETCONNECTION acknowledgement packet
-              assert.ok(true);
-            }
-
+            // TDS 7_1 doesnt send RESETCONNECTION acknowledgement packet
+            // For 7_2+ the resetConnection event handler confirms receipt
             callback(err);
           });
         },
@@ -1382,23 +1379,23 @@ update #tab1 set name = 'a3' where name like 'a%'\
     });
 
     request.on('doneInProc', (rowCount, more) => {
-      assert.ok(false);
+      assert.fail('Expected no doneInProc event');
     });
 
     request.on('doneProc', (rowCount, more) => {
-      assert.ok(false);
+      assert.fail('Expected no doneProc event');
     });
 
     request.on('done', (rowCount, more, rows) => {
-      assert.ok(false);
+      assert.fail('Expected no done event');
     });
 
     request.on('columnMetadata', (columnsMetadata) => {
-      assert.ok(false);
+      assert.fail('Expected no columnMetadata event');
     });
 
     request.on('row', (columns) => {
-      assert.ok(false);
+      assert.fail('Expected no row event');
     });
 
     const connection = new Connection({
@@ -1442,23 +1439,23 @@ update #tab1 set name = 'a3' where name like 'a%'\
     );
 
     request.on('doneInProc', function(rowCount, more) {
-      assert.ok(false);
+      assert.fail('Expected no doneInProc event');
     });
 
     request.on('doneProc', function(rowCount, more) {
-      assert.ok(false);
+      assert.fail('Expected no doneProc event');
     });
 
     request.on('done', function(rowCount, more, rows) {
-      assert.ok(false);
+      assert.fail('Expected no done event');
     });
 
     request.on('columnMetadata', function(columnsMetadata) {
-      assert.ok(false);
+      assert.fail('Expected no columnMetadata event');
     });
 
     request.on('row', function(columns) {
-      assert.ok(false);
+      assert.fail('Expected no row event');
     });
 
     const config = getConfig();

test/integration/errors-test.ts

@@ -50,7 +50,7 @@ describe('Errors Test', function() {
   `;
 
     execSql(done, sql, function(err) {
-      assert.ok(err instanceof RequestError);
+      assert.instanceOf(err, RequestError);
       assert.strictEqual((err as RequestError).number, 2627);
     });
   });
@@ -63,7 +63,7 @@ describe('Errors Test', function() {
   `;
 
     execSql(done, sql, function(err) {
-      assert.ok(err instanceof RequestError);
+      assert.instanceOf(err, RequestError);
       assert.strictEqual((err as RequestError).number, 515);
     });
   });
@@ -74,7 +74,7 @@ describe('Errors Test', function() {
   ';
 
     execSql(done, sql, function(err) {
-      assert.ok(err instanceof RequestError);
+      assert.instanceOf(err, RequestError);
       assert.strictEqual((err as RequestError).number, 3701);
     });
   });

test/integration/instance-lookup-test.ts

@@ -29,7 +29,7 @@ describe('Instance Lookup Test', function() {
       signal: controller.signal
     });
 
-    assert.ok(port);
+    assert.isDefined(port);
   });
 
   it('should test bad Instance', async function() {

test/integration/parameterised-statements-test.ts

@@ -51,7 +51,7 @@ function execSql(
   request.addParameter('param', type, value, options);
 
   request.on('doneInProc', function(rowCount, more) {
-    assert.ok(more);
+    assert.isTrue(more);
     assert.strictEqual(rowCount, 1);
   });
 
@@ -117,7 +117,7 @@ function execSqlOutput(
   request.addOutputParameter('paramOut', type);
 
   request.on('doneInProc', function(rowCount, more) {
-    assert.ok(more);
+    assert.isTrue(more);
     assert.strictEqual(rowCount, 1);
   });
 
@@ -138,7 +138,7 @@ function execSqlOutput(
       assert.strictEqual(returnValue, expectedValue);
     }
 
-    assert.ok(metadata);
+    assert.isDefined(metadata);
   });
 
   const connectionConfig = Object.assign({}, config, { options: Object.assign({}, config.options, connectionOptions) });
@@ -1097,7 +1097,7 @@ describe('Parameterised Statements Test', function() {
         });
 
         request.on('doneInProc', function(rowCount, more) {
-          assert.ok(more);
+          assert.isTrue(more);
           assert.strictEqual(rowCount, 1);
         });
 
@@ -1140,7 +1140,7 @@ describe('Parameterised Statements Test', function() {
     request.addParameter('param2', TYPES.VarChar, 'qwerty');
 
     request.on('doneInProc', function(rowCount, more) {
-      assert.ok(more);
+      assert.isTrue(more);
       assert.strictEqual(rowCount, 1);
     });
 
@@ -1216,7 +1216,7 @@ end')\
 
       request.on('doneInProc', function(rowCount, more) {
         assert.strictEqual(rowCount, undefined);
-        assert.ok(more);
+        assert.isTrue(more);
       });
 
       request.on('row', function(columns) {

test/integration/pause-resume-test.ts

@@ -88,7 +88,7 @@ describe('Pause-Resume Test', function() {
     });
 
     request.on('row', (columns) => {
-      assert.ok(!paused);
+      assert.isFalse(paused);
 
       rowsReceived++;
 
@@ -135,7 +135,7 @@ describe('Pause-Resume Test', function() {
             connection.cancel();
           }, 200);
         } else if (columns[0].value > 1000) {
-          assert.ok(false, 'Received rows after pause');
+          assert.fail('Received rows after pause');
         }
       });
 
@@ -170,7 +170,7 @@ describe('Pause-Resume Test', function() {
     request.pause();
 
     request.on('row', (columns) => {
-      assert.ok(!paused);
+      assert.isFalse(paused);
 
       assert.strictEqual(columns[0].value, 1);
     });

test/integration/prepare-execute-statements-test.ts

@@ -35,7 +35,7 @@ describe('Prepare Execute Statement', function() {
     const connection = new Connection(config);
 
     request.on('prepared', function() {
-      assert.ok(request.handle);
+      assert.isDefined(request.handle);
       connection.execute(request, { param: value });
     });
 
@@ -84,7 +84,7 @@ describe('Prepare Execute Statement', function() {
       request.addParameter('param', TYPES.Int);
 
       request.on('prepared', function() {
-        assert.ok(request.handle);
+        assert.isDefined(request.handle);
 
         assert.lengthOf(returnValues, 1);
         assert.strictEqual(returnValues[0].parameterName, 'handle');
@@ -166,7 +166,7 @@ describe('Prepare Execute Statement', function() {
     const connection = new Connection(config);
 
     request.on('prepared', function() {
-      assert.ok(request.handle);
+      assert.isDefined(request.handle);
       connection.unprepare(request);
     });