Directories array

[DocEmmetBrown]

Hi,
I've encountered a weird issue using the directory variable for the client.

if my array contains only one string ex : directories => [ '/' ],, I get an error on the backup server :

Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Failed to parse template rsnapshot/config.erb:
  Filepath: /etc/puppet/modules/rsnapshot/templates/config.erb
  Line: 103
  Detail: undefined method `each' for "/":String
 at /etc/puppet/modules/rsnapshot/manifests/server/config.pp:165 on node online-backup-48.as2.io
Warning: Not using cache on failed catalog
Error: Could not retrieve catalog; skipping run

I managed to make it work with this syntax :

directories => [ [ '/']],

but it's pretty strange.

I'm running puppet client & master 3.8 on Debian Wheezy on all the machines.

Thanx a lot !

[tedivm]

I've noticed you have a fork already- if you issue a pull request I'll happily take a look. Otherwise it'll probably be a couple of weeks, as I just got back from an extended trip and am still catching up on things.

Regardless, thanks for the bug report! I hope you're enjoying this module.

[DocEmmetBrown]

Hi Robert,

yep, I forked, and I will submit pull requests when I think I have a clean code :)

A missed a few features (like being able to change backup directory on a client basis, and a few others.

I'll try to implement them cleanly, and get back to you !

Thanx for your work, It's a great puppet module !

[tedivm]

@DocEmmetBrown still planning a pull request?