Merge pull request #237 from tegonal/improve/ask-to-print-help-if-value-is-missing

don't print the help if one misses the argument, ask instead

Author: robstoll

src/utility/parse-args.sh

@@ -143,11 +143,21 @@ function parseArgumentsInternal {
 
 	local -ri parseArguments_arrLength="${#parseArguments_paramArr[@]}"
 
+	function parseArgumentsInternal_ask_printHelp() {
+		if askYesOrNo "Shall I print the help for you?"; then
+			parseArgumentsInternal_printHelp
+		fi
+	}
+
+	function parseArgumentsInternal_printHelp() {
+		parse_args_printHelp parseArguments_paramArr "$parseArguments_examples" "$parseArguments_version" 4
+	}
+
 	local -i parseArguments_numOfArgumentsParsed=0
 	while (($# > 0)); do
 		parseArguments_argName="$1"
 		if [[ $parseArguments_argName == --help ]]; then
-			parse_args_printHelp parseArguments_paramArr "$parseArguments_examples" "$parseArguments_version" 4
+			parseArgumentsInternal_printHelp
 			if ! ((parseArguments_numOfArgumentsParsed == 0)); then
 				logWarning "there were arguments defined prior to --help, they were all ignored and instead the help is shown"
 			elif (($# > 1)); then
@@ -172,10 +182,8 @@ function parseArgumentsInternal {
 			if [[ $parseArguments_argName =~ $parseArguments_regex ]]; then
 				if (($# < 2)); then
 					logError "no value defined for parameter \033[1;36m%s\033[0m (pattern %s) in %s" "$parseArguments_paramName" "$parseArguments_pattern" "${BASH_SOURCE[2]}"
-					echo >&2 "following the help documentation:"
-					echo >&2 ""
-					parse_args_printHelp >&2 parseArguments_paramArr "$parseArguments_examples" "$parseArguments_version" 4
 					printStackTrace
+					parseArgumentsInternal_ask_printHelp
 					exit 9
 				fi
 				# that's where the black magic happens, we are assigning to global (not local to this function) variables here
@@ -192,9 +200,7 @@ function parseArgumentsInternal {
 			else
 				logError "unknown argument \033[1;36m%s\033[0m" "$parseArguments_argName"
 			fi
-			if askYesOrNo "Shall I print the help for you?"; then
-				parse_args_printHelp >&2 parseArguments_paramArr "$parseArguments_examples" "$parseArguments_version" 4
-			fi
+			parseArgumentsInternal_ask_printHelp
 			exit 9
 		fi
 		shift 1 || traceAndDie "could not shift by 1"