return with error if parsing (fn) args fails

Author: robstoll

.gt/lib/tegonal-gh-commons/src/gt/pull-hook-functions.sh

@@ -30,7 +30,7 @@ function gt_pullHook_tegonal_gh_commons_before() {
 	local _tag source _target
 	# shellcheck disable=SC2034   # is passed to parseFnArgs by name
 	local -ra params=(_tag source _target)
-	parseFnArgs params "$@"
+	parseFnArgs params "$@" || return $?
 
 	replaceTegonalGhCommonsPlaceholders_Tegonal "$source" "tegonal-scripts" "$TEGONAL_SCRIPTS_LATEST_VERSION" "scripts"
 }
@@ -39,7 +39,7 @@ function gt_pullHook_tegonal_gh_commons_after() {
 	local _tag source target
 	# shellcheck disable=SC2034   # is passed to parseFnArgs by name
 	local -ra params=(_tag source target)
-	parseFnArgs params "$@"
+	parseFnArgs params "$@" || return $?
 
 	if [[ $source =~ .*/src/gt/signing-key.public.asc.actual_sig ]]; then
 		mv "$target" "$(dirname "$target")/signing-key.public.asc.sig"

.gt/lib/tegonal-gh-commons/src/gt/tegonal.data.source.sh

@@ -4,10 +4,10 @@ v2.8.2	src/.github/workflows/cleanup.yml	../.github/workflows/cleanup.yml	.*	705
 v2.8.2	src/.github/dependabot.yml	../.github/dependabot.yml	.*	9f631eac687bd929d16f1ac3569fe8ef48ed9263fa2fee11265c4fc27d3b5a9fab1a5c4d63438ccd394fe33ae09003dac4af0094c3ff4fd84f7d8b0aeaa4fbcf
 v2.8.2	src/.github/CODE_OF_CONDUCT.md	../.github/CODE_OF_CONDUCT.md	.*	5dc73021b3972b3200c12fb2754e335321d07c5f7372977368b9964252501b665ddd12bf267939d4a34dc7ee8d3040cef8f4abaf0aed6dd2ce23c865e0300383
 v2.8.2	src/.github/PULL_REQUEST_TEMPLATE.md	../.github/PULL_REQUEST_TEMPLATE.md	.*	9112d1ea1f72ea250cdfe686fc152e63f2e0cdcea9c46935289471d7a3f54c35af8a3f283570f5d863e936c7782939c7b1548cb7d4ccda712bbf9314926f58cb
-v2.8.2	src/gt/pull-hook-functions.sh	lib/tegonal-gh-commons/src/gt/pull-hook-functions.sh	.*	6190f8d9f1fa9295fc562b0a34d73fec0792753020ed2a19c9b8a3e855a2c453d642763e831eb47aeb20cdbb78ef2aeb7f8d11bf03aae6784843072f05433596
+v2.8.2	src/gt/pull-hook-functions.sh	../lib/tegonal-gh-commons/src/gt/pull-hook-functions.sh	.*	6190f8d9f1fa9295fc562b0a34d73fec0792753020ed2a19c9b8a3e855a2c453d642763e831eb47aeb20cdbb78ef2aeb7f8d11bf03aae6784843072f05433596
 v2.8.2	src/.github/Contributor Agreement.txt	../.github/Contributor Agreement.txt	.*	0b9a8a954edf302ca5fe0062b7e283d3da06a6bc0631a812663095a78b3a734cefb43b725ae342694d770be75206124c42a1150e168fac33f28aebea0bda35ec
 v2.8.2	src/gt/signing-key.public.asc	signing-key.public.asc	.*	36edec73464b610713fe8ba32b7c8c26d378d74d590883ba00ca3175efc4f1b753b60ae6aa03ddd1038642899c1394861e02038853734a43d4bf845762b91708
 v2.8.2	src/gt/signing-key.public.asc.actual_sig	signing-key.public.asc.actual_sig	.*	50eacd712448066974382e7e05ac4fe42e9026dafd0d963c763b7e402d31a9ceb1d012897b2bc7e69d37d670148d57647d563870e5ca2832d8cdde91c92f55db
 v2.8.2	src/dotfiles/.editorconfig	../.editorconfig	.*	ab20f56af1aa48e8be29e3b43fba449b1401d17ca5aab0b7b4f0ce65621ede33ff3c68144d350cb3a820c4a573218d0af5ecab9458c19701427f9d1c5d15211c
 v2.8.2	src/dotfiles/.shellcheckrc	../.shellcheckrc	.*	2284b5a0f7d94916bf881b4e1f1ba3cbeb92ad51442b56dd6049bbcf9f4d7da4de3e82c1ae75a70e281cb2fbf390eb7676cbe553a630a1a58cd7895cfd2be2f6
-v2.8.2	src/gt/tegonal.data.source.sh	lib/tegonal-gh-commons/src/gt/tegonal.data.source.sh	.*	2c6600541c12c35c9a7a202cec91de5b2f01d4a3cb067fa57fb0c21ebb15be2cbe191967fa209bd69a8100c77e6e6df08031824ff43e6d0f81a95476ce6619c8
+v2.8.2	src/gt/tegonal.data.source.sh	../lib/tegonal-gh-commons/src/gt/tegonal.data.source.sh	.*	2c6600541c12c35c9a7a202cec91de5b2f01d4a3cb067fa57fb0c21ebb15be2cbe191967fa209bd69a8100c77e6e6df08031824ff43e6d0f81a95476ce6619c8

.gt/remotes/tegonal-gh-commons/pull-hook.sh

@@ -1815,7 +1815,7 @@ function myFunction() {
 
 	# shellcheck disable=SC2034   # is passed by name to parseFnArgs
 	local -ra params=(command dir)
-	parseFnArgs params "$@"
+	parseFnArgs params "$@" || return $?
 
 	# pass your variables storing the arguments to other scripts
 	echo "command: $command, dir: $dir"
@@ -1827,7 +1827,7 @@ function myFunctionWithVarargs() {
 	local command dir varargs
 	# shellcheck disable=SC2034   # is passed by name to parseFnArgs
 	local -ra params=(command dir varargs)
-	parseFnArgs params "$@"
+	parseFnArgs params "$@" || return $?
 
 	# use varargs in another script
 	echo "command: $command, dir: $dir, varargs: ${varargs*}"

.gt/remotes/tegonal-gh-commons/pulled.tsv

@@ -42,7 +42,7 @@ function prepareNextDevCycle() {
 		additionalPattern "$additionalPatternParamPattern" "is ignored as additional pattern is specified internally, still here as release-files uses this argument"
 		beforePrFn "$beforePrFnParamPattern" "$beforePrFnParamDocu"
 	)
-	parseArguments params "" "$TEGONAL_SCRIPTS_VERSION" "$@"
+	parseArguments params "" "$TEGONAL_SCRIPTS_VERSION" "$@" || return $?
 	# we don't check if all args are set (and neither set default values) as we currently don't use
 	# any param in here but just delegate to prepareFilesNextDevCycle.
 

README.md

@@ -56,7 +56,7 @@ function release() {
 		nextVersion "$nextVersionParamPattern" "$nextVersionParamDocu"
 		prepareOnly "$prepareOnlyParamPattern" "$prepareOnlyParamDocu"
 	)
-	parseArguments params "" "$TEGONAL_SCRIPTS_VERSION" "$@"
+	parseArguments params "" "$TEGONAL_SCRIPTS_VERSION" "$@" || return $?
 	# we don't check if all args are set (and neither set default values) as we currently don't use
 	# any param in here but just delegate to releaseFiles.
 
@@ -66,7 +66,7 @@ function release() {
 
 	function release_afterVersionHook() {
 		local version projectsRootDir additionalPattern
-		parseArguments afterVersionHookParams "" "$TEGONAL_SCRIPTS_VERSION" "$@"
+		parseArguments afterVersionHookParams "" "$TEGONAL_SCRIPTS_VERSION" "$@" || return $?
 
 		# same as in pull-hook.sh
 		local -r githubUrl="https://github.com/tegonal/scripts"

scripts/prepare-next-dev-cycle.sh

@@ -59,7 +59,7 @@ function jelastic_deploy() {
 		nodeGroup '-n|--nodeGroup' 'The nodeGroup to use'
 		tag '-t|--tag' 'The tag which shall be deployed'
 	)
-	parseArguments params "" "$TEGONAL_SCRIPTS_VERSION" "$@"
+	parseArguments params "" "$TEGONAL_SCRIPTS_VERSION" "$@" || return $?
 	exitIfNotAllArgumentsSet params "" "$TEGONAL_SCRIPTS_VERSION"
 
 	jelastic_signin "$url" "$login" "$password" || die "could not login to jelastic instance"

scripts/release.sh

@@ -72,7 +72,7 @@ function jelastic_signin() {
 	# params is required for parseFnArgs thus:
 	# shellcheck disable=SC2034
 	local -ra params=(url login password)
-	parseFnArgs params "$@"
+	parseFnArgs params "$@" || return $?
 
 	echo "Signing in..."
 	jelastic_exec "users/authentication/signin" --login "$login" --password "$password" --platformUrl "$url" >/dev/null

src/ci/jelastic/deploy.sh

@@ -55,7 +55,7 @@ function preReleaseCheckGit() {
 		branch "$branchParamPattern" "$branchParamDocu"
 	)
 
-	parseArguments params "" "$TEGONAL_SCRIPTS_VERSION" "$@"
+	parseArguments params "" "$TEGONAL_SCRIPTS_VERSION" "$@" || return $?
 	if ! [[ -v branch ]]; then branch="main"; fi
 	exitIfNotAllArgumentsSet params "" "$TEGONAL_SCRIPTS_VERSION"
 	exitIfArgIsNotVersion "$version" "$versionParamPatternLong"