Skip to content

Commit ffe5769

Browse files
committed
leave TODOs for 5.0.0
1 parent af2c72e commit ffe5769

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

src/qa/run-shellcheck-pull-hooks.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ if ! [[ -v dir_of_tegonal_scripts ]]; then
3737
fi
3838
sourceOnce "$dir_of_tegonal_scripts/qa/run-shellcheck.sh"
3939

40+
#TODO move to run-shellcheck with 5.0.0
4041
function runShellcheckPullHooks() {
4142
if ! (($# == 1)); then
4243
logError "Exactly one parameter needs to be passed to runShellcheckPullHooks, given \033[0;36m%s\033[0m\nFollowing a description of the parameters:" "$#"

src/setup.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,8 @@ set -euo pipefail
3131
shopt -s inherit_errexit
3232
unset CDPATH
3333

34+
#TODO 5.0.0 rename file to setup_tegonal_scripts.sh -- this way consumers will not run into shellcheck issues when they name a file setup.sh as well
35+
3436
if (($# != 1)); then
3537
printf >&2 "\033[0;31mERROR\033[0m: You need to pass the path to the tegonal scripts directory as first argument. Following an example\n"
3638
echo >&2 "source \"\$dir_of_tegonal_scripts/setup.sh\" \"\$dir_of_tegonal_scripts\""

0 commit comments

Comments
 (0)