Fix the Unit tests and update the golden file

- Update the golden file to remove the creationTimestamp: null
- Regenerated pkg/cmd/pipeline/testdata/signed.yaml and pkg/cmd/task/testdata/signed.yaml
  with fresh, valid signatures using the existing keys which was failing earlier
- Replaced log.Fatalf() with return fmt.Errorf() for proper error handling

Signed-off-by: Shiv Verma <[email protected]>

Author: pratap0007

pkg/actions/list.go

@@ -16,9 +16,7 @@ package actions
 
 import (
 	"context"
-	"fmt"
 	"io"
-	"os"
 
 	"github.com/tektoncd/cli/pkg/cli"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
@@ -44,7 +42,6 @@ func PrintObjects(groupResource schema.GroupVersionResource, w io.Writer, dynami
 func ListV1(gr schema.GroupVersionResource, c *cli.Clients, opts metav1.ListOptions, ns string, obj interface{}) error {
 	unstructuredObj, err := list(gr, c.Dynamic, c.Tekton.Discovery(), ns, opts)
 	if err != nil {
-		fmt.Fprintf(os.Stderr, "Failed to list objects from %s namespace \n", ns)
 		return err
 	}
 

pkg/cmd/bundle/list_test.go

@@ -20,7 +20,6 @@ const (
 	examplePullTask = `apiVersion: tekton.dev/v1beta1
 kind: Task
 metadata:
-  creationTimestamp: null
   name: foobar
 spec:
   params:
@@ -29,7 +28,6 @@ spec:
 	examplePullPipeline = `apiVersion: tekton.dev/v1beta1
 kind: Pipeline
 metadata:
-  creationTimestamp: null
   name: foobar
 spec:
   params:
@@ -48,15 +46,15 @@ func TestListCommand(t *testing.T) {
 		{
 			name:           "no-format",
 			format:         "",
-			expectedStdout: "*Warning*: This is an experimental command, its usage and behavior can change in the next release(s)\npipeline.tekton.dev/foobar\ntask.tekton.dev/foobar\n",
+			expectedStdout: "*Warning*: This is an experimental command, its usage and behavior can change in the next release(s)\ntask.tekton.dev/foobar\npipeline.tekton.dev/foobar\n",
 		}, {
 			name:           "name-format",
 			format:         "name",
-			expectedStdout: "*Warning*: This is an experimental command, its usage and behavior can change in the next release(s)\npipeline.tekton.dev/foobar\ntask.tekton.dev/foobar\n",
+			expectedStdout: "*Warning*: This is an experimental command, its usage and behavior can change in the next release(s)\ntask.tekton.dev/foobar\npipeline.tekton.dev/foobar\n",
 		}, {
 			name:           "yaml-format",
 			format:         "yaml",
-			expectedStdout: "*Warning*: This is an experimental command, its usage and behavior can change in the next release(s)\n" + examplePullPipeline + "---\n" + examplePullTask,
+			expectedStdout: "*Warning*: This is an experimental command, its usage and behavior can change in the next release(s)\n" + examplePullTask + "---\n" + examplePullPipeline,
 		}, {
 			name:           "specify-kind-task",
 			format:         "name",

pkg/cmd/clustertriggerbinding/testdata/TestClusterTriggerBindingDescribe_WithOutputYaml.golden

@@ -1,7 +1,6 @@
 apiVersion: triggers.tekton.dev/v1beta1
 kind: ClusterTriggerBinding
 metadata:
-  creationTimestamp: null
   name: ctb1
 spec:
   params:

pkg/cmd/eventlistener/testdata/TestEventListenerDescribe_OutputYAMLWithMultipleBindingAndInterceptors.golden

@@ -1,7 +1,6 @@
 apiVersion: triggers.tekton.dev/v1beta1
 kind: EventListener
 metadata:
-  creationTimestamp: null
   name: el1
   namespace: ns
 spec:

pkg/cmd/pipeline/testdata/TestPipelineDescribe_with_spec_multiple_param_run_output.golden

@@ -1,7 +1,6 @@
 apiVersion: tekton.dev/v1
 kind: pipeline
 metadata:
-  creationTimestamp: null
   name: pipeline
   namespace: ns
 spec:

pkg/cmd/pipeline/testdata/TestPipelineDescribe_with_spec_multiple_resource_param_run_output_v1beta1.golden

@@ -1,7 +1,6 @@
 apiVersion: tekton.dev/v1beta1
 kind: pipeline
 metadata:
-  creationTimestamp: null
   name: pipeline
   namespace: ns
 spec:

pkg/cmd/pipeline/testdata/TestPipelineStart_ExecuteCommand-Dry_Run_using_--filename_v1.golden

@@ -1,7 +1,6 @@
 apiVersion: tekton.dev/v1
 kind: PipelineRun
 metadata:
-  creationTimestamp: null
   generateName: test-pipeline-run-
   namespace: ns
 spec:

pkg/cmd/pipeline/testdata/TestPipelineStart_ExecuteCommand-Dry_Run_with_--pipeline-timeout,_--tasks-timeout,_--finally-timeout_specified.golden

@@ -1,7 +1,6 @@
 apiVersion: tekton.dev/v1
 kind: PipelineRun
 metadata:
-  creationTimestamp: null
   generateName: test-pipeline-run-
   labels:
     jemange: desfrites

pkg/cmd/pipeline/testdata/TestPipelineStart_ExecuteCommand-Dry_Run_with_--pipeline-timeout,_--tasks-timeout_specified.golden

@@ -1,7 +1,6 @@
 apiVersion: tekton.dev/v1
 kind: PipelineRun
 metadata:
-  creationTimestamp: null
   generateName: test-pipeline-run-
   labels:
     jemange: desfrites

pkg/cmd/pipeline/testdata/TestPipelineStart_ExecuteCommand-Dry_Run_with_--pipeline-timeout_specified.golden

@@ -1,7 +1,6 @@
 apiVersion: tekton.dev/v1
 kind: PipelineRun
 metadata:
-  creationTimestamp: null
   generateName: test-pipeline-run-
   labels:
     jemange: desfrites