Fix resource versions sorting

This patch fix versions sorting to sort version
strings using sematic versioning rule

Signed-off-by: Shiv Verma <shverma@redhat.com>

Author: pratap0007

api/pkg/cli/hub/get_resource.go

@@ -21,6 +21,7 @@ import (
 	"sort"
 	"strings"
 
+	"github.com/Masterminds/semver/v3"
 	rclient "github.com/tektoncd/hub/api/v1/gen/http/resource/client"
 )
 
@@ -231,9 +232,8 @@ func (t *tektonHubClient) GetResourceVersionslist(r ResourceOption) ([]string, e
 	for i := range opts.hubResVersions.Versions {
 		ver = append(ver, *opts.hubResVersions.Versions[i].Version)
 	}
-	sort.Sort(sort.Reverse(sort.StringSlice(ver)))
 
-	return ver, nil
+	return sortVersionsSemanticaly(ver), nil
 }
 
 // Endpoint computes the endpoint url using input provided
@@ -484,7 +484,58 @@ func findArtifactHubResourceVersions(data []byte) ([]string, error) {
 	for _, r := range resp.AvailableVersions {
 		versions = append(versions, r.Version)
 	}
-	sort.Sort(sort.Reverse(sort.StringSlice(versions)))
 
-	return versions, nil
+	return sortVersionsSemanticaly(versions), nil
+}
+
+// sortVersionsSemanticaly sorts version strings using semantic versioning rules
+// Returns versions in descending order (latest first), preserving original format
+func sortVersionsSemanticaly(versions []string) []string {
+	if len(versions) <= 1 {
+		return versions
+	}
+
+	// Create a struct to hold both original string and parsed version
+	type versionPair struct {
+		original string
+		semver   *semver.Version
+	}
+
+	var validVersions []versionPair
+	var invalidVersions []string
+
+	// Parse versions, keeping original strings and invalid ones separate
+	for _, v := range versions {
+		// Try to parse as semantic version
+		version, err := semver.NewVersion(v)
+		if err != nil {
+			// If it's not a valid semver, keep it as string for fallback sorting
+			invalidVersions = append(invalidVersions, v)
+		} else {
+			validVersions = append(validVersions, versionPair{
+				original: v,
+				semver:   version,
+			})
+		}
+	}
+
+	// Sort valid versions by their semver objects in descending order (latest first)
+	sort.Slice(validVersions, func(i, j int) bool {
+		return validVersions[i].semver.GreaterThan(validVersions[j].semver)
+	})
+
+	// Sort invalid versions alphabetically in descending order as fallback
+	sort.Sort(sort.Reverse(sort.StringSlice(invalidVersions)))
+
+	// Convert back to original strings and combine results
+	var result []string
+
+	// Add properly sorted semantic versions first (in original format)
+	for _, vp := range validVersions {
+		result = append(result, vp.original)
+	}
+
+	result = append(result, invalidVersions...)
+
+	return result
 }

api/pkg/cli/hub/get_resource_test.go

@@ -39,3 +39,12 @@ func TestGetResourceEndpoint(t *testing.T) {
 	url = opt.Endpoint()
 	assert.Equal(t, "/v1/resource/tekton/task/abc/0.1.1", url)
 }
+
+func TestSortVersionsSemanticaly(t *testing.T) {
+	// includes valid semver and some invalid strings (alpha/beta)
+	in := []string{"0.9.0", "1.0.0", "v0.10.0", "alpha", "2.0.0", "1.2.3", "beta"}
+	out := sortVersionsSemanticaly(in)
+
+	// valid semvers should be in descending order first
+	assert.Equal(t, []string{"2.0.0", "1.2.3", "1.0.0", "v0.10.0", "0.9.0", "beta", "alpha"}, out)
+}

go.mod

@@ -7,6 +7,7 @@ toolchain go1.23.8
 require (
 	github.com/ActiveState/vt10x v1.3.1
 	github.com/AlecAivazis/survey/v2 v2.3.7
+	github.com/Masterminds/semver/v3 v3.4.0
 	github.com/Netflix/go-expect v0.0.0-20220104043353-73e0943537d2
 	github.com/fatih/color v1.18.0
 	github.com/go-co-op/gocron v1.37.0

go.sum

@@ -111,6 +111,8 @@ github.com/AzureAD/microsoft-authentication-library-for-go v1.3.1 h1:gUDtaZk8het
 github.com/AzureAD/microsoft-authentication-library-for-go v1.3.1/go.mod h1:wP83P5OoQ5p6ip3ScPr0BAq0BvuPAvacpEuSzyouqAI=
 github.com/BurntSushi/toml v0.3.1/go.mod h1:xHWCNGjB5oqiDr8zfno3MHue2Ht5sIBksp03qcyfWMU=
 github.com/BurntSushi/xgb v0.0.0-20160522181843-27f122750802/go.mod h1:IVnqGOEym/WlBOVXweHU+Q+/VP0lqqI8lqeDx9IjBqo=
+github.com/Masterminds/semver/v3 v3.4.0 h1:Zog+i5UMtVoCU8oKka5P7i9q9HgrJeGzI9SA1Xbatp0=
+github.com/Masterminds/semver/v3 v3.4.0/go.mod h1:4V+yj/TJE1HU9XfppCwVMZq3I84lprf4nC11bSS5beM=
 github.com/Microsoft/go-winio v0.4.11/go.mod h1:VhR8bwka0BXejwEJY73c50VrPtXAaKcyvVC4A4RozmA=
 github.com/Microsoft/go-winio v0.4.14/go.mod h1:qXqCSQ3Xa7+6tgxaGTIe4Kpcdsi+P8jBhyzoq1bpyYA=
 github.com/Microsoft/go-winio v0.4.15-0.20190919025122-fc70bd9a86b5/go.mod h1:tTuCMEN+UleMWgg9dVx4Hu52b1bJo+59jBh3ajtinzw=