Remove older versions of task and stepactions resolver installersets

This will remove the older versions of task and stepactions resolver
installersets and keep only latest 2 versions during operator upgrade

Signed-off-by: Shiv Verma <[email protected]>

Author: pratap0007

pkg/reconciler/shared/tektonconfig/upgrade/post_upgrade.go

@@ -19,6 +19,7 @@ package upgrade
 import (
 	"context"
 	"fmt"
+	"slices"
 	"strings"
 
 	"github.com/tektoncd/operator/pkg/apis/operator/v1alpha1"
@@ -34,6 +35,10 @@ import (
 	"k8s.io/client-go/rest"
 )
 
+const (
+	taskVersiondRetentionCount = 2
+)
+
 // performs storage versions upgrade
 // lists all the resources and keeps only one storage version
 func upgradeStorageVersion(ctx context.Context, logger *zap.SugaredLogger, k8sClient kubernetes.Interface, operatorClient versioned.Interface, restConfig *rest.Config) error {
@@ -108,3 +113,71 @@ func removeClusterTaskInstallerSets(ctx context.Context, logger *zap.SugaredLogg
 	}
 	return nil
 }
+
+// removeVersionedTaskInstallerSets removes the versioned resolver tasks installersets except latest 2 versions
+func removeVersionedTaskInstallerSets(ctx context.Context, logger *zap.SugaredLogger, k8sClient kubernetes.Interface, operatorClient versioned.Interface, restConfig *rest.Config) error {
+
+	if !v1alpha1.IsOpenShiftPlatform() {
+		return nil
+	}
+
+	taskInstallerSetsLabelSelector := metav1.LabelSelector{
+		MatchLabels: map[string]string{
+			v1alpha1.InstallerSetType: fmt.Sprintf("%s-%s", "custom", "versionedresolvertask"),
+		},
+	}
+	taskInstallerSetsLabel, err := common.LabelSelector(taskInstallerSetsLabelSelector)
+	if err != nil {
+		return err
+	}
+
+	return findAndDeleteInstallerSetsByLabelName(ctx, logger, operatorClient, taskInstallerSetsLabel)
+}
+
+// removeVersionedStepActionsInstallerSets removes the versioned resolver step actions installersets except latest 2 versions
+func removeVersionedStepActionsInstallerSets(ctx context.Context, logger *zap.SugaredLogger, k8sClient kubernetes.Interface, operatorClient versioned.Interface, restConfig *rest.Config) error {
+
+	if !v1alpha1.IsOpenShiftPlatform() {
+		return nil
+	}
+
+	stepActionsInstallerSetsLabelSelector := metav1.LabelSelector{
+		MatchLabels: map[string]string{
+			v1alpha1.InstallerSetType: fmt.Sprintf("%s-%s", "custom", "versionedresolverstepaction"),
+		},
+	}
+	stepActionsInstallerSetsLabel, err := common.LabelSelector(stepActionsInstallerSetsLabelSelector)
+	if err != nil {
+		return err
+	}
+
+	return findAndDeleteInstallerSetsByLabelName(ctx, logger, operatorClient, stepActionsInstallerSetsLabel)
+}
+
+func findAndDeleteInstallerSetsByLabelName(ctx context.Context, logger *zap.SugaredLogger, operatorClient versioned.Interface, installerSetsLabel string) error {
+	tsClient := operatorClient.OperatorV1alpha1().TektonInstallerSets()
+
+	installerSets, err := tsClient.List(ctx, metav1.ListOptions{LabelSelector: installerSetsLabel})
+	if err != nil {
+		return err
+	}
+	if len(installerSets.Items) < taskVersiondRetentionCount {
+		return nil
+	}
+
+	installerListName := []string{}
+	for _, taskIS := range installerSets.Items {
+		installerListName = append(installerListName, taskIS.Name)
+	}
+
+	slices.Sort(installerListName)
+	slices.Reverse(installerListName)
+
+	for i := taskVersiondRetentionCount; i < len(installerListName); i++ {
+		if err := tsClient.Delete(ctx, installerListName[i], metav1.DeleteOptions{}); err != nil {
+			logger.Errorw("failed to delete a installerset", "installerSetName", installerListName[i], err)
+			return err
+		}
+	}
+	return nil
+}

pkg/reconciler/shared/tektonconfig/upgrade/upgrade.go

@@ -38,8 +38,10 @@ var (
 
 	// post upgrade functions
 	postUpgradeFunctions = []upgradeFunc{
-		upgradeStorageVersion,          // upgrade #1: performs storage version migration
-		removeClusterTaskInstallerSets, // upgrade #2: removes the clusterTask installerset
+		upgradeStorageVersion,                   // upgrade #1: performs storage version migration
+		removeClusterTaskInstallerSets,          // upgrade #2: removes the clusterTask installerset
+		removeVersionedTaskInstallerSets,        // upgrade #3: remove the older versioned resolver task installersets
+		removeVersionedStepActionsInstallerSets, // upgrade #4: remove the older versioned step action resolver installersets
 	}
 )