Fix: Syncer Service Transformer

1. Default Kueue Namespace on openshiftr must be openshift-kueue-operator bit kueue-system
  update the image prefix  as container name in deployment is controller not workload-controller

Author: pramodbindal

pkg/reconciler/common/transformers.go

@@ -55,7 +55,7 @@ const (
 	PrunerImagePrefix               = "IMAGE_PRUNER_"
 	SchedulerImagePrefix            = "IMAGE_SCHEDULER_"
 	MulticlusterProxyAAEImagePrefix = "IMAGE_MULTICLUSTERPROXYAAE_"
-	SyncerServiceImagePrefix        = "IMAGE_SYNCER_SERVICE_"
+	SyncerServiceImagePrefix        = "IMAGE_SYNCER_SERVICE_WORKLOAD_"
 	ResultsImagePrefix              = "IMAGE_RESULTS_"
 	HubImagePrefix                  = "IMAGE_HUB_"
 	DashboardImagePrefix            = "IMAGE_DASHBOARD_"

pkg/reconciler/openshift/const.go

@@ -1,6 +1,7 @@
 package openshift
 
 const (
+	KueueNameSpace                  = "openshift-kueue-operator"
 	OperandOpenShiftPipelinesAddons = "openshift-pipelines-addons"
 	OperandOpenShiftPipelineAsCode  = "openshift-pipeline-as-code"
 	// NamespaceSCCAnnotation is used to set SCC for a given namespace

pkg/reconciler/openshift/syncerservice/extension.go

@@ -22,7 +22,9 @@ import (
 	mf "github.com/manifestival/manifestival"
 	"github.com/tektoncd/operator/pkg/apis/operator/v1alpha1"
 	"github.com/tektoncd/operator/pkg/reconciler/common"
+	"github.com/tektoncd/operator/pkg/reconciler/openshift"
 	occommon "github.com/tektoncd/operator/pkg/reconciler/openshift/common"
+	corev1 "k8s.io/api/core/v1"
 )
 
 func OpenShiftExtension(ctx context.Context) common.Extension {
@@ -36,6 +38,12 @@ func (oe openshiftExtension) Transformers(comp v1alpha1.TektonComponent) []mf.Tr
 		occommon.RemoveRunAsUser(),
 		occommon.RemoveRunAsGroup(),
 		occommon.ApplyCABundlesToDeployment,
+		common.DeploymentEnvVars([]corev1.EnvVar{
+			{
+				Name:  "KUEUE_NAMESPACE",
+				Value: openshift.KueueNameSpace,
+			},
+		}),
 	}
 }
 

pkg/reconciler/openshift/tektonmulticlusterproxyaae/extension.go

@@ -20,6 +20,7 @@ import (
 	"context"
 
 	mf "github.com/manifestival/manifestival"
+	"github.com/tektoncd/operator/pkg/reconciler/openshift"
 	corev1 "k8s.io/api/core/v1"
 
 	"github.com/tektoncd/operator/pkg/apis/operator/v1alpha1"
@@ -40,7 +41,7 @@ func (oe openshiftExtension) Transformers(comp v1alpha1.TektonComponent) []mf.Tr
 		common.DeploymentEnvVars([]corev1.EnvVar{
 			{
 				Name:  "WORKERS_SECRET_NAMESPACE",
-				Value: "openshift-kueue-operator",
+				Value: openshift.KueueNameSpace,
 			},
 		}),
 	}

pkg/reconciler/openshift/tektonmulticlusterproxyaae/extension_test.go

@@ -24,6 +24,7 @@ import (
 	mf "github.com/manifestival/manifestival"
 	"github.com/tektoncd/operator/pkg/apis/operator/v1alpha1"
 	"github.com/tektoncd/operator/pkg/reconciler/common"
+	"github.com/tektoncd/operator/pkg/reconciler/openshift"
 	appsv1 "k8s.io/api/apps/v1"
 	corev1 "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/runtime"
@@ -40,7 +41,7 @@ func TestOpenShiftExtensionTransformers(t *testing.T) {
 			t.Fatalf("unexpected error applying transformers: %v", err)
 		}
 
-		assertDeploymentEnvVar(t, newManifest, "WORKERS_SECRET_NAMESPACE", "openshift-kueue-operator")
+		assertDeploymentEnvVar(t, newManifest, "WORKERS_SECRET_NAMESPACE", openshift.KueueNameSpace)
 	})
 
 	// spec.options.deployments allows users to override env vars set by the extension.