fix(kustomize): move platform-specific CRDs to shared base

Newer kustomize versions enforce a security restriction that
rejects direct file references pointing outside the kustomization
root. config/kubernetes/base and config/openshift/base both
referenced CRD files via ../../base/generated-crds/..., which
violates that restriction and caused kustomize build to silently
fail during releases (the error was swallowed because the pipeline
does not set pipefail).

Move tektondashboards and tektonaddons CRDs from their platform-
specific kustomization.yaml files into config/base/kustomization.yaml
where controller-gen already writes all generated CRDs. The extra
CRDs on each platform are harmless — their reconcilers are
platform-gated.

Signed-off-by: Jawed khelil <jkhelil@redhat.com>
Assisted-by: Claude Sonnet 4.6 (via Cursor)
Co-authored-by: Cursor <cursoragent@cursor.com>

Author: jkhelil

config/base/kustomization.yaml

@@ -44,4 +44,6 @@ resources:
 - generated-crds/operator.tekton.dev_tektonpruners.yaml
 - generated-crds/operator.tekton.dev_tektonresults.yaml
 - generated-crds/operator.tekton.dev_tektonschedulers.yaml
+- generated-crds/operator.tekton.dev_tektondashboards.yaml
+- generated-crds/operator.tekton.dev_tektonaddons.yaml
 - generated-crds/operator.tekton.dev_tektontriggers.yaml

config/kubernetes/base/kustomization.yaml

@@ -30,7 +30,6 @@ apiVersion: kustomize.config.k8s.io/v1beta1
 kind: Kustomization
 resources:
 - ../../base/
-- ../../base/generated-crds/operator.tekton.dev_tektondashboards.yaml
 - ../../webhooks/
 - operator_service.yaml
 - pipelinesascode.yaml

config/openshift/base/kustomization.yaml

@@ -52,7 +52,6 @@ patchesStrategicMerge:
 
 resources:
 - ../../base/
-- ../../base/generated-crds/operator.tekton.dev_tektonaddons.yaml
 - ../../webhooks
 - operator_service.yaml
 - operator_servicemonitor.yaml