Skip to content

Cleanup 🧹 pipelinerunresolution_test.go 🧹 and move mock data, status mutations and selectors to testing framework. #8921

@twoGiants

Description

@twoGiants

Summary

Refactor pipelinerunresolution_test.go a bit and move testing helpers to the new testing framework location:

  • Move all mock data creation to pkg/reconciler/testing/factory.go, i.e. var p = ..., var pts = ..., newTaskRun(), ...
    • rename the single letter variables to proper names e.g. p => pipeline, pts = pipelineTasks, ...
  • Move all status transformers to pkg/reconciler/testing/status.go, i.e makeSucceed(), withCanceled()...
  • Move all selectors to pkg/reconciler/testing/selectors.go, i.e. nopGetCustomRun, ...

This is a good first issue.

Related issue #8906.

/help
/good-first-issue
/kind cleanup

Metadata

Metadata

Assignees

Labels

good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/cleanupCategorizes issue or PR as related to cleaning up code, process, or technical debt.

Type

No type

Projects

Status

Todo

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions