Skip to content

Commit 60db981

Browse files
omertuctekton-robot
authored andcommitted
Rename Decade to Century
We had an issue [1] with long expiration so I noticed the name was wrong [1] rh-ecosystem-edge/recert#167 Signed-off-by: Omer Tuchfeld <omer@tuchfeld.dev>
1 parent 484656e commit 60db981

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

pkg/interceptors/server/server.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ import (
3333
)
3434

3535
const (
36-
Decade = 100 * 365 * 24 * time.Hour
36+
Century = 100 * 365 * 24 * time.Hour
3737
interceptorTLSSecretKey = "INTERCEPTOR_TLS_SECRET_NAME"
3838
interceptorTLSSvcKey = "INTERCEPTOR_TLS_SVC_NAME"
3939
)
@@ -159,7 +159,7 @@ func (is *Server) ExecuteInterceptor(r *http.Request) ([]byte, error) {
159159
}
160160

161161
func CreateAndValidateCerts(ctx context.Context, coreV1Interface corev1.CoreV1Interface, logger *zap.SugaredLogger, service *Server, tc triggersv1alpha1.TriggersV1alpha1Interface) {
162-
serverCert, caCert, err := createCerts(ctx, coreV1Interface, time.Now().Add(Decade), logger, false)
162+
serverCert, caCert, err := createCerts(ctx, coreV1Interface, time.Now().Add(Century), logger, false)
163163
if err != nil {
164164
return
165165
}
@@ -278,7 +278,7 @@ func (is *Server) checkCertValidity(ctx context.Context, serverCert, caCert []by
278278
if _, err := cert.Verify(opts); err != nil {
279279
logger.Errorf("failed to verify certificate: %v", err.Error())
280280

281-
serverCertNew, caCertNew, err := createCerts(ctx, coreV1Interface, time.Now().Add(Decade), logger, true)
281+
serverCertNew, caCertNew, err := createCerts(ctx, coreV1Interface, time.Now().Add(Century), logger, true)
282282
if err != nil {
283283
logger.Errorf("failed to create certs %v", err)
284284
}

pkg/interceptors/server/server_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ func Test_SecretNotExist(t *testing.T) {
212212
logger := zaptest.NewLogger(t)
213213
ctx, _ := test.SetupFakeContext(t)
214214
clientSet := fakekubeclient.Get(ctx).CoreV1()
215-
_, _, err := createCerts(ctx, clientSet, time.Now().Add(Decade), logger.Sugar(), false)
215+
_, _, err := createCerts(ctx, clientSet, time.Now().Add(Century), logger.Sugar(), false)
216216
if err != nil && !strings.Contains(err.Error(), "not found") {
217217
t.Error(err)
218218
}
@@ -241,7 +241,7 @@ func createSecret(t *testing.T, noAfter time.Time, certExpire bool) (v1.CoreV1In
241241
}
242242

243243
func Test_CreateSecret(t *testing.T) {
244-
_, sCert, caCert, err := createSecret(t, time.Now().Add(Decade), true)
244+
_, sCert, caCert, err := createSecret(t, time.Now().Add(Century), true)
245245
if err != nil {
246246
t.Error(err)
247247
}

0 commit comments

Comments
 (0)