Skip to content

Commit b8df761

Browse files
authored
fix: Update the action that checks for unreleased changelog items to always create the template files necessary for semantic-release (#302)
* fix: Update the action that checks for unreleased changelog items to always create the template files necessary for semantic-release * refactor: Update note in summary to account for the reusable workflow name
1 parent df28663 commit b8df761

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

.github/workflows/_reusable-package-release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ jobs:
124124
- name: Add note to summary
125125
run: |
126126
echo "## Python Semantic Release Preview (noop)" >> "$GITHUB_STEP_SUMMARY"
127-
echo "See the stdout from the \`Python Semantic Release (noop for preview)\` step in the \`print-inputs\` job for more details." >> "$GITHUB_STEP_SUMMARY"
127+
echo "See the stdout from the \`Python Semantic Release (noop for preview)\` step in the \`package-release / print-inputs\` job for more details." >> "$GITHUB_STEP_SUMMARY"
128128
outputs:
129129
found-changes: ${{ (steps.find-changes-local.outputs.found-changes && fromJSON(steps.find-changes-local.outputs.found-changes)) || (steps.find-changes-public.outputs.found-changes && fromJSON(steps.find-changes-public.outputs.found-changes)) }}
130130
# Update the package version using the python-semantic-release package (https://github.com/python-semantic-release/python-semantic-release)

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,10 @@ Things to be included in the next release go here.
2222

2323
- Bumped dependency versions.
2424

25+
### Fixed
26+
27+
- Fixed the `package-release` workflow to no longer have issues with the `semantic-release --noop` command.
28+
2529
---
2630

2731
## v1.6.0 (2025-01-03)

actions/find_unreleased_changelog_items/main.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -146,10 +146,9 @@ def main() -> None:
146146
issue_messages.append("No PRs have been merged since the last release")
147147

148148
# Copy the files to the correct location
149-
if not issue_messages:
150-
shutil.copy(CHANGELOG_FILE, template_changelog_filepath)
151-
with template_release_notes_filepath.open("w", encoding="utf-8") as template_release_notes:
152-
template_release_notes.write(release_notes_content.strip() + "\n")
149+
shutil.copy(CHANGELOG_FILE, template_changelog_filepath)
150+
with template_release_notes_filepath.open("w", encoding="utf-8") as template_release_notes:
151+
template_release_notes.write(release_notes_content.strip() + "\n")
153152

154153
if issue_messages:
155154
add_contents_to_github_summary(

0 commit comments

Comments
 (0)