Skip to content

Commit c92847f

Browse files
committed
fix: address Copilot review comments on accessibility PR #616
- Add aria-pressed attribute to high-contrast toggle button in App.vue so assistive technology can announce the button's on/off state - Fix lint formatting in a11y.spec.ts error page test declaration Notes on pre-existing fixes verified in this pass: - CountdownTimer unit tests for SR announcements already present - ErrorToasts compact spacing test already present - SCALE_COMPONENT_EXCLUDES replaced by isScaleShadowDomNode() filter - router/index.ts already cancels focusTimerId on every navigation - localStorage guarded with try/catch in both getInitialHighContrast/toggleHighContrast - BreakglassSessionCard/BreakglassCard cluster duplication already fixed - NotFoundView CTA already uses CSS variables
1 parent 3e05a8b commit c92847f

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

frontend/src/App.vue

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -414,6 +414,7 @@ watch(
414414
type="button"
415415
:class="['hc-toggle-button', { 'hc-active': highContrast }]"
416416
:aria-label="highContrast ? 'Disable high contrast mode' : 'Enable high contrast mode'"
417+
:aria-pressed="highContrast"
417418
@click="toggleHighContrast"
418419
>
419420
<scale-icon-action-eye :decorative="true"></scale-icon-action-eye>

frontend/tests/e2e/a11y.spec.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -344,7 +344,9 @@ test.describe("Accessibility (axe-core WCAG 2.1 AA + AAA)", () => {
344344

345345
// ── Error pages ──────────────────────────────────────────────
346346
for (const errorPage of ERROR_PAGES_TO_AUDIT) {
347-
test(`${errorPage.name} (${errorPage.path}) has no critical/serious a11y violations [${mode.name}]`, async ({ page }) => {
347+
test(`${errorPage.name} (${errorPage.path}) has no critical/serious a11y violations [${mode.name}]`, async ({
348+
page,
349+
}) => {
348350
await mode.setup(page);
349351

350352
await performMockLogin(page);

0 commit comments

Comments
 (0)