opendf.exceptions.python_exception.SemanticException: alias usage should respect positional order : MD.month

[hankcs]

Dear authors,

When running the simplified expression generated by OpenDF, sometimes MD raised the following exception:

File "OpenDF/test/research/run_dialog/run_utility.py", line 70, in execute_dialog
igl, ex = construct_graph(isexp, d_context, constr_tag=OUTLINE_SIMP, no_post_check=True)
File "OpenDF/opendf/graph/constr_graph.py", line 91, in construct_graph
raise ex
File "OpenDF/opendf/graph/constr_graph.py", line 87, in construct_graph
root = ast_top_down_construct(prs[0], None, d_context, register=register, top_only=top_only,
File "OpenDF/opendf/graph/constr_graph.py", line 293, in ast_top_down_construct
_ = ast_top_down_construct(nd, n, d_context, register, False, constr_tag)
File "OpenDF/opendf/graph/constr_graph.py", line 293, in ast_top_down_construct
_ = ast_top_down_construct(nd, n, d_context, register, False, constr_tag)
File "OpenDF/opendf/graph/constr_graph.py", line 293, in ast_top_down_construct
_ = ast_top_down_construct(nd, n, d_context, register, False, constr_tag)
File "OpenDF/opendf/graph/constr_graph.py", line 264, in ast_top_down_construct
raise SemanticException('alias usage should respect positional order : %s.%s' % (typ, alias))
opendf.exceptions.python_exception.SemanticException: alias usage should respect positional order : MD.month

Dialog 37

GUID: a70dc17b-7e6b-4a7a-a8fb-71bdaad5f39d OpenDF:

• U1: Please put in dentist appt 2:30 12/19
• A1: I've put that on your calendar. Your status is set to Busy.
• U2: Is there anything I have on the schedule before that?
• A2: No, I didn't find any events before yesterday at 2:30 PM.

Program:

 CreateEvent(
    AND(
       has_subject(
          dentist appt ) ,
       starts_at(
          MD(
             day= 19 ,
             month= toMonth(
                12 ) ) ) ,
       starts_at(
          HourMinutePm(
             hours= 2 ,
             minutes= 30 ) ) ) ) 

[hankcs]

Another instance:

Dialog 62

GUID: 2a6a1b3d-fa50-4ce3-9cd0-5d56fd3e954b OpenDF:

• U1: I gotta know the weather during my hike this weekend
• A1: It will be clear with a high of 0.00 °F and a low of 0.00 °F on Saturday around 10:00 AM.
• U2: After the hike set up lunch with Stephanie at the Cheesecake Factory for 11:30 am.
• A2: I didn't find anyone named Stephanie in your address book.
• U3: Make a meeting with Bob at Indianapolis on February 2nd.
• A3: Does one of these work?

 CreateEvent(
    AND(
       with_attendee(
          Bob ) ,
       at_location(
          Indianapolis ) ,
       starts_at(
          MD(
             day= 2 ,
             month= FEBRUARY ) ) ) ) 

[meron-tl]

Changed input order in simplification for MD, MDY. commit ab04bdb.
Please verify.

[hankcs]

Hi, the above commit indeed fixes some cases. But in other cases, day comes before month. E.g., the 3rd turn in Dialog 62:

 CreateEvent(
    AND(
       with_attendee(
          Bob ) ,
       at_location(
          Indianapolis ) ,
       starts_at(
          MD(
             day= 2 ,
             month= FEBRUARY ) ) ) ) 

Is it possible to make this parameter order flexible like Python?

[meron-tl]

Disabled the checks of parameter order, when parameter name is given. 23a3452

Because of the original SMCalFlow treatment of parameter naming (either positional OR named), this is a bit tricky.

In most cases, disabling the checks is ok, but there could be some unusual cases where this would lead to unexpected consequences.

Note that Node.inputs is an ordered dictionary (i.e. by order that the inputs were given), and that traversing the graph (e.g. during evaluation) is done according to this order.

There may be some cases where the design assumes the parameters are given in a specific order (maybe not "best practice"), and forcing a different order could cause some problems in evaluation (e.g. if the inputs are implicitly dependent of each other...). But typically this is not the case.