RuntimeError: ParserException("Syntax error at `LexToken(OPEN_ARGUMENTS,'(',1,40)`")

[hankcs]

Dear authors,

There seems to a bug when expressions suggested by MultipleEventSuggestionsException are executed:

Dialog 16

GUID: 4a53ad40-3012-4b3b-bae2-02dad4b71c13:

• U1: Create meeting for today at noon and make my ShowAs status Busy
• A1: I've put that on your calendar. Your status is set to Busy.
• U2: I would like to set a lunch appointment at 1 am after that.
• A2: I've put that on your calendar. Your status is set to Busy.

Data:

{"dialogue_id": "4a53ad40-3012-4b3b-bae2-02dad4b71c13", "turns": [{"agent_utterance": {"described_entities": [], "original_text": "I've put that on your calendar. Your status is set to Busy.", "tokens": ["I", "'ve", "put", "that", "on", "your", "calendar", ".", "Your", "status", "is", "set", "to", "Busy", "."]}, "lispress": " CreateEvent( AND( has_status( ShowAsStatus( Busy ) ) , starts_at( Today( ) ) , starts_at( Noon( ) ) ) ) ", "program_execution_oracle": {"has_exception": false, "refer_are_correct": true}, "skip": true, "turn_index": 0, "user_utterance": {"original_text": "Create meeting for today at noon and make my ShowAs status Busy", "tokens": ["Create", "meeting", "for", "today", "at", "noon", "and", "make", "my", "ShowAs", "status", "Busy"]}}, {"agent_utterance": {"described_entities": [], "original_text": "I've put that on your calendar. Your status is set to Busy.", "tokens": ["I", "'ve", "put", "that", "on", "your", "calendar", ".", "Your", "status", "is", "set", "to", "Busy", "."]}, "lispress": " CreateEvent( AND( has_subject( lunch  appointment ) , starts_at( NextTime( time= NumberAM( 1 ) ) ) ) ) ", "program_execution_oracle": {"has_exception": false, "refer_are_correct": true}, "skip": true, "turn_index": 1, "user_utterance": {"original_text": "I would like to set a lunch appointment at 1 am after that.", "tokens": ["I", "would", "like", "to", "set", "a", "lunch", "appointment", "at", "1", "am", "after", "that", "."]}}]}

U1's request gets a MultipleEventSuggestionsException:

When I try to execute AcceptSuggestion, ParserException was raised. The expression caused the issue was:

ModifyEventRequest(AND(starts_at(DateTime(date=Date(year=2022, month=1, day=3), time=Time(hour=11, minute=0))), ends_at(DateTime(date=Date(year=2022, month=1, day=3), time=Time(hour=11, minute=30))), at_location(online)))

[hankcs]

I'm able to replicate the bug in a short snippet:

            from opendf.graph.dialog_context import DialogContext
            d_context = DialogContext()
            d_context.suppress_exceptions = True  # avoid exit in
            from opendf.graph.nodes.node import Node
            ttree = Node.call_construct(
                'AND(TimeSlot(start=DateTime?(date=Date(year=2022,month=1,day=3))),AND(TimeSlot(start=GE(DateTime?(time=Time(hour=11,minute=0)))),TimeSlot(start=LE(DateTime?(time=Time(hour=13,minute=0))))),AND(TimeSlot(start=DateTime(date=Date(year=2022,month=1,day=3),time=Time(hour=11,minute=0))),TimeSlot(end=DateTime(date=Date(year=2022,month=1,day=3),time=Time(hour=11,minute=30)))))',
                d_context)[0]
            Node.get_truncated_constraint_tree(ttree, 'TimeSlot', 'DateTime', 'start')

The expression was dumped from MultipleEventSuggestionsException.

[hankcs]

Log:

Node.get_truncated_constraint_tree(ttree, 'TimeSlot', 'DateTime', 'start')
File "OpenDF/opendf/graph/nodes/node.py", line 2500, in get_truncated_constraint_tree
r, e = Node.call_construct(sexp, d_context)
File "OpenDF/opendf/graph/nodes/node.py", line 1857, in call_construct
g, ex = construct_graph(sexp, d_context, register=register, top_only=top_only, constr_tag=constr_tag,
File "OpenDF/opendf/graph/constr_graph.py", line 91, in construct_graph
raise ex
File "OpenDF/opendf/graph/constr_graph.py", line 86, in construct_graph
prs = parse_p_expressions(sexp)
File "OpenDF/opendf/parser/pexp_parser.py", line 460, in parse_p_expressions
return parser.parse(expressions)
File "OpenDF/opendf/parser/pexp_parser.py", line 351, in parse
self.parser.parse(input=expressions, lexer=self.lexer)
File "OpenDF/venv/lib/python3.8/site-packages/ply/yacc.py", line 333, in parse
return self.parseopt_notrack(input, lexer, debug, tracking, tokenfunc)
File "OpenDF/venv/lib/python3.8/site-packages/ply/yacc.py", line 1201, in parseopt_notrack
tok = call_errorfunc(self.errorfunc, errtoken, self)
File "OpenDF/venv/lib/python3.8/site-packages/ply/yacc.py", line 192, in call_errorfunc
r = errorfunc(token)
File "OpenDF/opendf/parser/pexp_parser.py", line 443, in p_error
raise ParserException(p)
opendf.exceptions.python_exception.ParserException: Syntax error at `LexToken(OPEN_ARGUMENTS,'(',1,35)`

[hankcs]

Another instance found:

 do(
    Let(
       x0 ,
       :end(
          FindEvents(
             has_subject(
                Gym session ) ) ) ) ,
    CreateEvent(
       AND(
          has_subject(
             making belts ) ,
          starts_at(
             $ x0 ) ,
          ends_at(
             AND(
                GE(
                   $ x0 ) ,
                EndOfWorkDay(
                   ) ) ) ) ) ) 

Log:

File "OpenDF/opendf/applications/smcalflow/nodes/functions.py", line 1360, in exec
d = Event.create_suggestion(cp, self)
File "OpenDF/opendf/applications/smcalflow/nodes/objects.py", line 893, in create_suggestion
return Event.get_event_factory().create_event_suggestion(root, parent, avoid_id)
File "OpenDF/opendf/applications/smcalflow/nodes/event_factory.py", line 784, in create_event_suggestion
self.get_suggestions_from_database(root, root.context, subj, atts, avoid_id)
File "OpenDF/opendf/applications/smcalflow/nodes/event_factory.py", line 860, in get_suggestions_from_database
selection = self.create_database_selection(root, d_context, subject, attendees_ids, ignore_event_id)
File "OpenDF/opendf/applications/smcalflow/nodes/event_factory.py", line 924, in create_database_selection
ttree = Node.get_truncated_constraint_tree(root, 'Event', 'TimeSlot', 'slot')
File "OpenDF/opendf/graph/nodes/node.py", line 2500, in get_truncated_constraint_tree
r, e = Node.call_construct(sexp, d_context)
File "OpenDF/opendf/graph/nodes/node.py", line 1857, in call_construct
g, ex = construct_graph(sexp, d_context, register=register, top_only=top_only, constr_tag=constr_tag,
File "OpenDF/opendf/graph/constr_graph.py", line 91, in construct_graph
raise ex
File "OpenDF/opendf/graph/constr_graph.py", line 86, in construct_graph
prs = parse_p_expressions(sexp)
File "OpenDF/opendf/parser/pexp_parser.py", line 460, in parse_p_expressions
return parser.parse(expressions)
File "OpenDF/opendf/parser/pexp_parser.py", line 351, in parse
self.parser.parse(input=expressions, lexer=self.lexer)
File "OpenDF/venv/lib/python3.8/site-packages/ply/yacc.py", line 333, in parse
return self.parseopt_notrack(input, lexer, debug, tracking, tokenfunc)
File "OpenDF/venv/lib/python3.8/site-packages/ply/yacc.py", line 1201, in parseopt_notrack
tok = call_errorfunc(self.errorfunc, errtoken, self)
File "OpenDF/venv/lib/python3.8/site-packages/ply/yacc.py", line 192, in call_errorfunc
r = errorfunc(token)
File "OpenDF/opendf/parser/pexp_parser.py", line 443, in p_error
raise ParserException(p)
opendf.exceptions.python_exception.ParserException: Syntax error at `LexToken(OPEN_ARGUMENTS,'(',1,14)`

[hankcs]

Another instance:

Dialog 70

GUID: 32e9e708-d4b9-4a96-9da7-b74d3973c2ec OpenDF:

• U1: Please save the time after the meeting with Abby until the end of the day for a 1:1 with Elli
• A1: Is this good?
• U2: also i need a meeting with abby tomorrow after work ends
• A2: How's this?
• U3: That looks good
• A3: I've put that on your calendar.

[meron-tl]

Fixed a problem with the creation of the s-exp (e.g. '$#17()' -> '$#17'). Please verify, commit 4a64636