refactor: add common methods for type check

Author: danielkaradachki

src/cldr/info.js

@@ -1,4 +1,5 @@
 import defaultData from './default-data';
+import isString from '../common/is-string';
 import { errors } from '../errors';
 
 function availableLocaleInfo(fullName, suffixes) {
@@ -29,7 +30,7 @@ export const cldr = defaultData;
 
 export function getLocaleInfo(locale) {
     let info;
-    if (typeof locale === "string") {
+    if (isString(locale)) {
         info = localeInfo(locale);
     } else {
         info = locale;

src/common/is-number.js

@@ -0,0 +1,3 @@
+export default function isNumber(value) {
+    return typeof value === "number";
+}

src/common/is-string.js

@@ -0,0 +1,3 @@
+export default function isString(value) {
+    return typeof value === "string";
+}

src/dates/date-pattern.js

@@ -1,4 +1,5 @@
 import formatString from '../common/format-string';
+import isString from '../common/is-string';
 import { EMPTY } from '../common/constants';
 
 const REMOVAL_PENALTY = 120;
@@ -192,7 +193,7 @@ function skeletonFromOptions(options) {
 export default function datePattern(format, info) {
     const calendar = info.calendar;
     let result;
-    if (typeof format === "string") {
+    if (isString(format)) {
         if (calendar.patterns[format]) {
             result = calendar.patterns[format];
         } else {

src/dates/split-date-format.js

@@ -1,4 +1,5 @@
 import { DEFAULT_LOCALE } from '../common/constants';
+import isNumber from '../common/is-number';
 import datePattern from './date-pattern';
 import dateNameType from './date-name-type';
 import { dateFormatRegExp, DATE_FIELD_MAP } from './constants';
@@ -39,7 +40,6 @@ const NAME_TYPES = {
 };
 
 const LITERAL = 'literal';
-const NUMBER = 'number';
 
 function addLiteral(parts, value) {
     const lastPart = parts[parts.length - 1];
@@ -88,7 +88,7 @@ export default function splitDateFormat(format, locale = DEFAULT_LOCALE) {
             const names = NAME_TYPES[type];
 
             if (names) {
-                const minLength = typeof names.minLength === NUMBER ? names.minLength : names.minLength[specifier];
+                const minLength = isNumber(names.minLength) ? names.minLength : names.minLength[specifier];
                 const patternLength = value.length;
 
                 if (patternLength >= minLength) {

src/format.js

@@ -2,14 +2,15 @@ import { formatDate } from './dates';
 import { formatNumber } from './numbers';
 import { EMPTY } from './common/constants';
 import isDate from './common/is-date';
+import isNumber from './common/is-number';
 
 const formatRegExp = /\{(\d+)(:[^\}]+)?\}/g;
 
 export function toString(value, format, locale) {
     if (format) {
         if (isDate(value)) {
             return formatDate(value, format, locale);
-        } else if (typeof value === "number") {
+        } else if (isNumber(value)) {
             return formatNumber(value, format, locale);
         }
     }

src/numbers/format-number.js

@@ -1,5 +1,6 @@
 import { localeInfo } from '../cldr';
 import { CURRENCY, ACCOUNTING, DECIMAL, PERCENT, SCIENTIFIC, DEFAULT_LOCALE, NUMBER_PLACEHOLDER, EMPTY } from '../common/constants';
+import isString from '../common/is-string';
 import standardNumberFormat from './standard-number-format';
 import customNumberFormat from './custom-number-format';
 
@@ -35,7 +36,7 @@ function standardFormatOptions(format) {
 
 function getFormatOptions(format) {
     let formatOptions;
-    if (typeof format === "string") {
+    if (isString(format)) {
         formatOptions = standardFormatOptions(format);
     } else {
         formatOptions = format;

src/numbers/parse-number.js

@@ -1,5 +1,6 @@
 import { localeInfo, localeCurrency, currencyDisplays } from '../cldr';
 import { PERCENT, NUMBER_PLACEHOLDER, CURRENCY_PLACEHOLDER, DEFAULT_LOCALE, EMPTY, POINT } from '../common/constants';
+import isNumber from '../common/is-number';
 import isCurrencyStyle from './is-currency-style';
 
 const exponentRegExp = /[eE][\-+]?[0-9]+/;
@@ -48,7 +49,7 @@ export default function parseNumber(value, locale = DEFAULT_LOCALE, format = {})
         return null;
     }
 
-    if (typeof value === "number") {
+    if (isNumber(value)) {
         return value;
     }