fix(formatNumber): use locale specific decimal separator for scientific formatting

Author: danielkaradachki

src/numbers/standard-number-format.js

@@ -12,6 +12,7 @@ const DECIMAL_PLACEHOLDER = "n";
 const CURRENCY = "currency";
 const PERCENT = "percent";
 const EMPTY = "";
+const POINT = ".";
 
 function fractionOptions(options) {
     let { minimumFractionDigits, maximumFractionDigits, style } = options;
@@ -69,14 +70,15 @@ function currencyUnitPattern(info, value) {
 
 
 export default function standardNumberFormat(number, options, info) {
+    const symbols = info.numbers.symbols;
     const { style } = options;
 
     //return number in exponential format
     if (style === "scientific") {
-        return options.minimumFractionDigits !== undefined ? number.toExponential(options.minimumFractionDigits) : number.toExponential();
+        let exponential = options.minimumFractionDigits !== undefined ? number.toExponential(options.minimumFractionDigits) : number.toExponential();
+        return exponential.replace(POINT, symbols.decimal);
     }
 
-    const symbols = info.numbers.symbols;
     let value = number;
     let symbol;
 

test/numbers.js

@@ -87,24 +87,26 @@ describe('formatNumber', () => {
 });
 
 describe('standard scientific formatting', () => {
+    const value = 123;
+
     it('should apply format', () => {
-        const number = 123;
-        expect(formatNumber(number, 'e')).toEqual(number.toExponential());
+        expect(formatNumber(value, 'e')).toEqual(value.toExponential());
     });
 
     it('should apply format with precision', () => {
-        const number = 123;
-        expect(formatNumber(number, 'e10')).toEqual(number.toExponential(10));
+        expect(formatNumber(value, 'e10')).toEqual(value.toExponential(10));
     });
 
     it('should apply format when passing options object', () => {
-        const number = 123;
-        expect(formatNumber(number, { style: 'scientific' })).toEqual(number.toExponential());
+        expect(formatNumber(value, { style: 'scientific' })).toEqual(value.toExponential());
     });
 
     it('should apply format with precision when passing options object', () => {
-        const number = 123;
-        expect(formatNumber(number, { style: 'scientific', minimumFractionDigits: 10})).toEqual(number.toExponential(10));
+        expect(formatNumber(value, { style: 'scientific', minimumFractionDigits: 10})).toEqual(value.toExponential(10));
+    });
+
+    it('should use locale specific decimal separator', () => {
+        expect(formatNumber(value, { style: 'scientific' }, 'bg')).toEqual('1,23e+2');
     });
 });