Skip to content

Commit 345a92c

Browse files
committed
chore: reapply dropdowns new spec
1 parent a189bdf commit 345a92c

File tree

6 files changed

+496
-592
lines changed

6 files changed

+496
-592
lines changed

aria/autocomplete_aria.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ The popup element of the AutoComplete has to implement the WAI-ARIA specificatio
3333
| `.k-autocomplete-popup-container` | `role=region` | When the component container is appended to the `<body>` element of the document, it requires you to assing a `landmark` role to it. Otherwise, append it to an element with an appropriate `landmark` role. |
3434
| | `aria-label` or `aria-labelledby` | When the container has a `region` role assigned, povides a label. |
3535
| `.k-list .k-no-data` | `aria-live=polite` | Identifies the element as a live region in the `polite` state, meaning assistive technology users are informed about changes to the region at the next available opportunity. |
36+
| `.k-list-item-icon` | `aria-hidden=true` | Ensures that the icon itself is hidden from assistive technologies since it is decorative. |
3637
| `.k-list-content[role="listbox"]` | `role=listbox` | For grouped lists, the wrapper must have `role=listbox`. For ungrouped lists, the UL element has this role instead. |
3738
| | `aria-label` or `aria-labelledby` | Provides a label for grouped listboxes. |
3839
| `.k-list-ul[role="listbox"]` | `role=listbox` | For ungrouped lists, the `ul` element has `role=listbox` with appropriate aria-label/labelledby. |
@@ -41,7 +42,7 @@ The popup element of the AutoComplete has to implement the WAI-ARIA specificatio
4142
| | `id` | List items should have an `id` attribute for `aria-activedescendant` navigation. |
4243
| `.k-list-item:not(.k-focus)` | `tabindex=-1` | Only the focused option should have `tabindex=0`, all others should be `-1`. |
4344
| `.k-list-item.k-selected` | `aria-selected=true` | Indicates the selected state of the item. |
44-
| `.k-list-header` | `role=presentation` | For grouped lists, the group header element should have `role=presentation`. |
45+
| `.k-list-group-item` | `role=presentation` | For grouped lists, the group header element should have `role=presentation`. |
4546
| | `id` | The group header must have an id that the corresponding `ul` element references via `aria-labelledby`. |
4647

4748
### Adaptive Mode

aria/combobox_aria.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ The popup element of the ComboBox has to implement the WAI-ARIA specification fo
3737
| `.k-combobox-popup-container` | `role=region` | When the component container is appended to the `<body>` element of the document, it requires you to assing a `landmark` role to it. Otherwise, append it to an element with an appropriate `landmark` role. |
3838
| | `aria-label` or `aria-labelledby` | When the container has a `region` role assigned, povides a label. |
3939
| `.k-list .k-no-data` | `aria-live=polite` | Identifies the element as a live region in the `polite` state, meaning assistive technology users are informed about changes to the region at the next available opportunity. |
40+
| `.k-list-item-icon` | `aria-hidden=true` | Ensures that the icon itself is hidden from assistive technologies since it is decorative. |
4041
| `.k-list-content[role="listbox"]` | `role=listbox` | For grouped lists, the wrapper must have `role=listbox`. For ungrouped lists, the UL element has this role instead. |
4142
| | `aria-label` or `aria-labelledby` | Provides a label for grouped listboxes. |
4243
| `.k-list-ul[role="listbox"]` | `role=listbox` | For ungrouped lists, the `ul` element has `role=listbox` with appropriate aria-label/labelledby. |
@@ -45,7 +46,7 @@ The popup element of the ComboBox has to implement the WAI-ARIA specification fo
4546
| | `id` | List items should have an `id` attribute for `aria-activedescendant` navigation. |
4647
| `.k-list-item:not(.k-focus)` | `tabindex=-1` | Only the focused option should have `tabindex=0`, all others should be `-1`. |
4748
| `.k-list-item.k-selected` | `aria-selected=true` | Indicates the selected state of the item. |
48-
| `.k-list-header` | `role=presentation` | For grouped lists, the group header element should have `role=presentation`. |
49+
| `.k-list-group-item` | `role=presentation` | For grouped lists, the group header element should have `role=presentation`. |
4950
| | `id` | The group header must have an id that the corresponding `ul` element references via `aria-labelledby`. |
5051

5152
### Adaptive Mode

aria/dropdownlist_aria.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ The listbox placed in the popup element of the DropDownList has to implement the
5151
| `.k-dropdownlist-popup-container` | `role=region` | When the component container is appended to the `<body>` element of the document, it requires you to assing a `landmark` role to it. Otherwise, append it to an element with an appropriate `landmark` role. |
5252
| | `aria-label` or `aria-labelledby` | When the container has a `region` role assigned, povides a label. |
5353
| `.k-list .k-no-data` | `aria-live=polite` | Identifies the element as a live region in the `polite` state, meaning assistive technology users are informed about changes to the region at the next available opportunity. |
54+
| `.k-list-item-icon` | `aria-hidden=true` | Ensures that the icon itself is hidden from assistive technologies since it is decorative. |
5455
| `.k-list-content[role="listbox"]` | `role=listbox` | For grouped lists, the wrapper must have `role=listbox`. For ungrouped lists, the UL element has this role instead. |
5556
| | `aria-label` or `aria-labelledby` | Provides a label for grouped listboxes. |
5657
| `.k-list-ul[role="listbox"]` | `role=listbox` | For ungrouped lists, the `ul` element has `role=listbox` with appropriate aria-label/labelledby. |
@@ -59,7 +60,7 @@ The listbox placed in the popup element of the DropDownList has to implement the
5960
| | `id` | List items should have an `id` attribute for `aria-activedescendant` navigation. |
6061
| `.k-list-item:not(.k-focus)` | `tabindex=-1` | Only the focused option should have `tabindex=0`, all others should be `-1`. |
6162
| `.k-list-item.k-selected` | `aria-selected=true` | Indicates the selected state of the item. |
62-
| `.k-list-header` | `role=presentation` | For grouped lists, the group header element should have `role=presentation`. |
63+
| `.k-list-group-item` | `role=presentation` | For grouped lists, the group header element should have `role=presentation`. |
6364
| | `id` | The group header must have an id that the corresponding `ul` element references via `aria-labelledby`. |
6465

6566
### Adaptive Mode

aria/multiselect_aria.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ The popup element of the MultiSelect must implement the WAI-ARIA specification f
3737
| `.k-multiselect-popup-container` | `role=region` | When the component container is appended to the `<body>` element of the document, it requires you to assing a `landmark` role to it. Otherwise, append it to an element with an appropriate `landmark` role. |
3838
| | `aria-label` or `aria-labelledby` | When the container has a `region` role assigned, povides a label. |
3939
| `.k-list .k-no-data` | `aria-live=polite` | Identifies the element as a live region in the `polite` state, meaning assistive technology users are informed about changes to the region at the next available opportunity. |
40+
| `.k-list-item-icon` | `aria-hidden=true` | Ensures that the icon itself is hidden from assistive technologies since it is decorative. |
4041
| `.k-list-content[role="listbox"]` | `role=listbox` | For grouped lists, the wrapper must have `role=listbox`. For ungrouped lists, the UL element has this role instead. |
4142
| | `aria-label` or `aria-labelledby` | Provides a label for grouped listboxes. |
4243
| | `aria-multiselectable=true` | Announces multiselection capability of the listbox popup. |
@@ -47,7 +48,7 @@ The popup element of the MultiSelect must implement the WAI-ARIA specification f
4748
| | `id` | List items should have an `id` attribute for `aria-activedescendant` navigation. |
4849
| `.k-list-item:not(.k-focus)` | `tabindex=-1` | Only the focused option should have `tabindex=0`, all others should be `-1`. |
4950
| `.k-list-item.k-selected` | `aria-selected=true` | Indicates the selected state of the item. |
50-
| `.k-list-header` | `role=presentation` | For grouped lists, the group header element should have `role=presentation`. |
51+
| `.k-list-group-item` | `role=presentation` | For grouped lists, the group header element should have `role=presentation`. |
5152
| | `id` | The group header must have an id that the corresponding `ul` element references via `aria-labelledby`. |
5253

5354
### Adaptive Mode

packages/html/src/list/list-item.spec.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ export const ListItem: KendoComponent<KendoListItemProps & KendoListItemState &
7878
{...(tabIndex !== undefined && { tabIndex })}
7979
>
8080
{showCheckbox && <Checkbox checked={checked} />}
81-
{iconName && <span className="k-list-item-icon-wrapper"><Icon icon={iconName} className={classNames("k-list-item-icon", iconClassName)} /></span>}
81+
{iconName && <span className="k-list-item-icon-wrapper"><Icon icon={iconName} className={classNames("k-list-item-icon", iconClassName)} aria-hidden="true" /></span>}
8282
<span className="k-list-item-text">{textOrChildren}</span>
8383
{actions && <div className="k-list-item-actions">{actions}</div>}
8484
{description && <span className="k-list-item-description">{description}</span>}

0 commit comments

Comments
 (0)