Skip to content

Commit 91921a3

Browse files
author
Kendo Bot
committed
Sync with Kendo UI Professional
1 parent 143af07 commit 91921a3

File tree

7 files changed

+26
-32
lines changed

7 files changed

+26
-32
lines changed

package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,10 @@
1111
"version": "1.0.0",
1212
"dependencies": {},
1313
"devDependencies": {
14-
"@progress/kendo-theme-bootstrap": "4.41.2",
15-
"@progress/kendo-theme-default": "4.41.2",
16-
"@progress/kendo-theme-material": "4.41.2",
17-
"@progress/kendo-theme-classic": "4.41.2",
14+
"@progress/kendo-theme-bootstrap": "4.42.0",
15+
"@progress/kendo-theme-default": "4.42.0",
16+
"@progress/kendo-theme-material": "4.42.0",
17+
"@progress/kendo-theme-classic": "4.42.0",
1818
"amd-optimize": "0.6.1",
1919
"autoprefixer": "^9.1.5",
2020
"axe-core": "^4.3.0",

src/kendo.listbox.js

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -945,8 +945,17 @@ var __meta__ = { // jshint ignore:line
945945
},
946946

947947
_list: function () {
948-
var that = this;
949-
$("<ul class='" + LIST_CLASS + "' role='listbox'></ul>").appendTo(that._innerWrapper);
948+
var that = this,
949+
list = $("<ul class='" + LIST_CLASS + "' role='listbox'></ul>"),
950+
selectable = that.options.selectable,
951+
selectableOptions = Selectable.parseOptions(selectable);
952+
953+
if (selectableOptions.multiple) {
954+
list.attr("aria-multiselectable", "true");
955+
}
956+
957+
list.appendTo(that._innerWrapper);
958+
950959
if(that.options.navigatable) {
951960
that._getList().attr(TABINDEX, that._getTabIndex());
952961
}
@@ -1071,10 +1080,6 @@ var __meta__ = { // jshint ignore:line
10711080
var selectable = that.options.selectable;
10721081
var selectableOptions = Selectable.parseOptions(selectable);
10731082

1074-
if (selectableOptions.multiple) {
1075-
that.element.attr("aria-multiselectable", "true");
1076-
}
1077-
10781083
that.selectable = new Selectable(that._innerWrapper, {
10791084
aria: true,
10801085
multiple: selectableOptions.multiple,

src/kendo.listview.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -518,6 +518,10 @@ var __meta__ = { // jshint ignore:line
518518
}
519519
});
520520

521+
if(multi) {
522+
that.element.attr("aria-multiselectable", true);
523+
}
524+
521525
if (navigatable) {
522526
that.element.on("keydown" + NS, function(e) {
523527

src/kendo.selectable.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,10 +56,6 @@ var __meta__ = { // jshint ignore:line
5656

5757
multiple = that.options.multiple;
5858

59-
if (this.options.aria && multiple) {
60-
that.element.attr("aria-multiselectable", true);
61-
}
62-
6359
that.userEvents = new kendo.UserEvents(that.element, {
6460
global: true,
6561
allowSelection: true,

tests/listbox/aria.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,12 @@
4949

5050
axeRunFixture(done);
5151
});
52+
53+
it("multiselectable ListBox has 'aria-multiselectable' on the element with role='listbox'", function() {
54+
createListBox();
55+
56+
assert.equal(Mocha.fixture.find("[role='listbox']").attr("aria-multiselectable"), "true");
57+
});
5258
});
5359

5460
describe("ListBox aria", function () {

tests/selectable/selectable.js

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -750,24 +750,6 @@
750750
assert.isOk(ul.children().eq(2).hasClass(SELECTED), "Third item must be selected");
751751
});
752752

753-
it("multiple selection adds aria attribute", function() {
754-
new Selectable(ul, { aria: true, multiple: true });
755-
756-
assert.isOk(ul.is("[aria-multiselectable]"));
757-
});
758-
759-
it("non-aria selectable does not add aria-multiselectable", function() {
760-
new Selectable(ul, { multiple: true });
761-
762-
assert.isOk(!ul.is("[aria-multiselectable]"));
763-
});
764-
765-
it("non-aria selectable does not add aria-multiselectable", function() {
766-
new Selectable(ul, { aria: true });
767-
768-
assert.isOk(!ul.is("[aria-multiselectable]"));
769-
});
770-
771753
it("_invalidateSelectables calls _collidesWithActiveElement", function() {
772754
var selectable = new Selectable(ul, { multiple: true });
773755

typescript/kendo.all.d.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6202,6 +6202,7 @@ declare namespace kendo.ui {
62026202
dataSource?: any|any|kendo.data.DataSource | undefined;
62036203
detailTemplate?: string|Function | undefined;
62046204
editable?: boolean | "inline" | "incell" | "popup" | GridEditable | undefined;
6205+
encodeTitles?: boolean;
62056206
excel?: GridExcel | undefined;
62066207
filterable?: boolean | GridFilterable | undefined;
62076208
groupable?: boolean | GridGroupable | undefined;

0 commit comments

Comments
 (0)