Merge pull request #2 from lukaspour/fix/policy

Added randomness into global names to make module universal

Author: mhd999

iam.tf

@@ -1,19 +1,46 @@
 resource "aws_iam_role" "lambda_role" {
-  name = "${var.name_prefix}_lambda_role"
-
-  assume_role_policy = <<EOF
-{
-  "Version": "2012-10-17",
-  "Statement": [
-    {
-      "Action": "sts:AssumeRole",
-      "Principal": {
-        "Service": "lambda.amazonaws.com"
-      },
-      "Effect": "Allow",
-      "Sid": "stmtLambdaAssumeRole"
+  name               = "${var.name_prefix}_lambda_role_${random_string.lambda_postfix_generator.result}"
+  assume_role_policy = "${data.aws_iam_policy_document.lambda_assume.json}"
+}
+
+data "aws_iam_policy_document" "lambda_assume" {
+  statement {
+    effect = "Allow"
+
+    actions = [
+      "sts:AssumeRole",
+    ]
+
+    principals {
+      type = "Service"
+
+      identifiers = [
+        "lambda.amazonaws.com",
+      ]
     }
-  ]
+  }
 }
-EOF
+
+resource "aws_iam_role_policy" "lambda_main" {
+  name   = "${var.name_prefix}_lambda_policy_${random_string.lambda_postfix_generator.result}"
+  role   = "${aws_iam_role.lambda_role.name}"
+  policy = "${data.aws_iam_policy_document.lambda_services_dashboard.json}"
+}
+
+data "aws_iam_policy_document" "lambda_services_dashboard" {
+  statement {
+    effect = "Allow"
+
+    actions = [
+      "ecs:*",
+      "cloudwatch:*",
+      "logs:CreateLogGroup",
+      "logs:CreateLogStream",
+      "logs:PutLogEvents",
+    ]
+
+    resources = [
+      "arn:aws:logs:*:*:*",
+    ]
+  }
 }

main.tf

@@ -1,11 +1,19 @@
+resource "random_string" "lambda_postfix_generator" {
+  length  = 16
+  upper   = true
+  lower   = true
+  number  = true
+  special = false
+}
+
 resource "aws_sns_topic" "alarm_topic" {
-  name = "${var.topic_name}"
+  name = "${var.topic_name}-${random_string.lambda_postfix_generator.result}"
 }
 
 resource "aws_lambda_function" "notify_slack" {
   s3_bucket     = "${var.lambda_s3_bucket}"
   s3_key        = "${var.s3_key}"
-  function_name = "${var.name_prefix}-slack-notify"
+  function_name = "${var.name_prefix}-slack-notify-${random_string.lambda_postfix_generator.result}"
   handler       = "${var.handler}"
   runtime       = "go1.x"
   timeout       = "${var.timeout}"