Skip to content

Upgrading jquery.min.js #29

@westurner

Description

@westurner

jquery.min.js has jQuery Core 1.11.1

From https://code.jquery.com/jquery/ :

  • latest 1.11 is 1.11.3
  • latest 1 is 1.12.4
  • latest 3 is 3.4.1

None of these seem that pressing for sphinxjp.themes.basicstrap, but it may be better to upgrade to latest for anything else on the page that depends on jquery:
https://www.cvedetails.com/vulnerability-list/vendor_id-6538/Jquery.html

FWIW, https://github.com/sphinx-doc/sphinx/tree/master/sphinx/themes/basic/static has jQuery Core 3.4.1

  • Does 3.4.1 break anything in sphinxjp.themes.basicstrap?

(edit; also (this could be a separate issue))

jquery.cookie.min.js has jquery-cookie v1.4.1, which is the latest release, but
https://github.com/carhartl/jquery-cookie says it's been superseded by
https://github.com/js-cookie/js-cookie

  • What would swapping in js-cookie instead of jquery-cookie require?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions