Skip to content

Commit a708883

Browse files
authored
Merge pull request #875 from telosnetwork/develop
Removing check for showing the execute button, bumping wharfkit to get fixed cleos transaction format
2 parents e784823 + a413715 commit a708883

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

src/pages/ProposalItem.vue

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -301,7 +301,10 @@ export default defineComponent({
301301
activeProducersApproved.value = activeProducers.value.filter(
302302
item => item.status,
303303
);
304-
304+
// Commenting this out, the logic is bad.
305+
// BPs can be involved in non-BP proposals, so we can't just check if BPs are involved and then assume 2/3 + 1
306+
// And if no BPs are involved, doesn't mean we need 100% approval, most msigs are 2/3 or 5/7, etc...
307+
/*
305308
if (activeProducers.value.length === 0) {
306309
// No BPs are involved in the proposal, so we need to 100% of the requested approvals
307310
isApproved.value = proposal.provided_approvals.length === totalRequestedApprovals;
@@ -310,6 +313,8 @@ export default defineComponent({
310313
const approval = (activeProducers.value.length * 2 / 3) + 1;
311314
isApproved.value = activeProducersApproved.value.length >= Math.floor(approval);
312315
}
316+
*/
317+
isApproved.value = true;
313318
314319
const transactions = await handleTransactionHistory(proposal.block_num);
315320

yarn.lock

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2680,10 +2680,10 @@
26802680
"@wharfkit/token" "^1.1.2"
26812681
tslib "^2.1.0"
26822682

2683-
"@wharfkit/antelope@1.0.9":
2684-
version "1.0.9"
2685-
resolved "https://registry.yarnpkg.com/@wharfkit/antelope/-/antelope-1.0.9.tgz#87388b8ab86f6f0e63950284661b7e8da16e76a7"
2686-
integrity sha512-kqJJmvp+//OG372HELb8IdSMvSZI9u/S6TPiljB5sm3Yl4rRLJL+EV8SxmfuAY/kF5asbHQkW2HWR8L12HXZ6w==
2683+
"@wharfkit/antelope@1.0.10":
2684+
version "1.0.10"
2685+
resolved "https://registry.yarnpkg.com/@wharfkit/antelope/-/antelope-1.0.10.tgz#5c63d6b67a4b62038575cd86ef47edaa8d1f57dd"
2686+
integrity sha512-12m4nD6+ZZl+mwzySuFkeiJCOrbXQT6mqg9amr1l/JtRewRdxeN9QTsEoPjE5MCTXbJc84X51KCT71ysglse0Q==
26872687
dependencies:
26882688
bn.js "^4.11.9"
26892689
brorand "^1.1.0"

0 commit comments

Comments
 (0)