fix(core-notification): fix component resizing

elissa-matsushita · jraff · commit 85e1b00313cd · 2021-03-19T12:33:14.000-04:00
adding event listener so height is adjusted properly
diff --git a/packages/Notification/Notification.jsx b/packages/Notification/Notification.jsx
@@ -74,14 +74,12 @@ class Notification extends React.Component {
 
   componentDidMount() {
     if (this.props.dismissible) {
-      this.adjustContentHeight()
+      window.addEventListener('resize', this.adjustContentHeight)
     }
   }
 
-  componentDidUpdate() {
-    if (this.props.dismissible) {
-      this.adjustContentHeight()
-    }
+  componentWillUnmount() {
+    window.removeEventListener('resize', this.adjustContentHeight)
   }
 
   adjustContentHeight = () => {

Original file line number	Diff line number	Diff line change
`@@ -74,14 +74,12 @@ class Notification extends React.Component {`
`74`	`74`
`75`	`75`	`componentDidMount() {`
`76`	`76`	`if (this.props.dismissible) {`
`77`		`- this.adjustContentHeight()`
	`77`	`+ window.addEventListener('resize', this.adjustContentHeight)`
`78`	`78`	`}`
`79`	`79`	`}`
`80`	`80`
`81`		`- componentDidUpdate() {`
`82`		`- if (this.props.dismissible) {`
`83`		`- this.adjustContentHeight()`
`84`		`- }`
	`81`	`+ componentWillUnmount() {`
	`82`	`+ window.removeEventListener('resize', this.adjustContentHeight)`
`85`	`83`	`}`
`86`	`84`
`87`	`85`	`adjustContentHeight = () => {`