Skip to content

Commit af03699

Browse files
author
Jian Liew
committed
fixed up padding for button and card
1 parent c282ae4 commit af03699

File tree

5 files changed

+12
-8
lines changed

5 files changed

+12
-8
lines changed

udsnative/src/main/java/com/telus/udsnative/components/button/Button.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ fun Button(
8888
onClick = onClick,
8989
enabled = appearance.state != ButtonState.Inactive
9090
)
91-
.padding(2.dp + tokens.outerBorderGap)
91+
.padding(2.dp + tokens.outerBorderGap) //outer border padding
9292
.indication(
9393
interactionSource = interactionSource,
9494
indication = null
@@ -103,7 +103,7 @@ fun Button(
103103
color = tokens.borderColor.color
104104
)
105105
.clip(shape = RoundedCornerShape(tokens.borderRadius))
106-
.padding(start = tokens.paddingLeft, top = tokens.paddingTop, end = tokens.paddingRight, bottom = tokens.paddingBottom),
106+
.padding(start = tokens.paddingLeft, top = tokens.paddingTop +2.dp, end = tokens.paddingRight, bottom = tokens.paddingBottom + 2.dp), //inner button padding
107107
horizontalArrangement = Arrangement.spacedBy(
108108
space = contentSpacing,
109109
alignment = contentAlignment

udsnative/src/main/java/com/telus/udsnative/components/card/CardAppearance.kt

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,17 +5,14 @@ import com.telus.udsnative.models.Appearance
55
class CardAppearance(variant: CardVariant): Appearance {
66
val background: Background
77
val padding: Padding
8-
val viewport: Viewport // Temporary hardcoded value until viewport is removed from theme file
98

109
init {
1110
this.background = variant.background
1211
this.padding = variant.padding
13-
this.viewport = variant.viewport
1412
}
1513

1614
override fun asMap(): Map<String, Any> = mapOf(
1715
"background" to background.name,
18-
"padding" to padding.name,
19-
"viewport" to viewport.name
16+
"padding" to padding.name
2017
)
2118
}

udsnative/src/main/java/com/telus/udsnative/components/typography/TypographyAppearance.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ class TypographyAppearance(variant: TypographyVariant) : Appearance {
1414
"colour" to variant.colour.name,
1515
"compact" to variant.compact,
1616
"inverse" to variant.inverse,
17-
"size" to variant.size.name
17+
"size" to variant.size.name,
18+
"viewport" to variant.viewport.name // Temporary hardcoded value until viewport is removed from theme file
1819
)
1920
}

udsnative/src/main/java/com/telus/udsnative/components/typography/TypographyVariant.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ data class TypographyVariant(
77
val colour: TypographyColor = TypographyColor.default,
88
val compact: Boolean = false,
99
val inverse: Boolean = false,
10-
val size: TypographySize = TypographySize.default
10+
val size: TypographySize = TypographySize.default,
11+
val viewport: TypographyViewport = TypographyViewport.lg
1112

1213
) : Variant
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
package com.telus.udsnative.components.typography
2+
3+
enum class TypographyViewport {
4+
xs, sm, md, lg, xl
5+
}

0 commit comments

Comments
 (0)